http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13451 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13451 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 34359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34359&action=edit Bug 13451: Holidays.t assumes default data This patch removes that assumption by expressly setting data to be default. TEST PLAN --------- 1) Ensure that branch code is NOT 'MPL' in the repeatable_holidays table in your database. 2) Ensure that branch codes 'MPL' and 'CPL' do not exist in the branches table in your database. 3) prove t/db_dependent/Holidays.t -- this should bomb horribly. 4) Apply patch 5) prove t/db_dependent/Holidays.t -- all tests should succeed. 6) run koha qa tests -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13451 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34359|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 34377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34377&action=edit [SIGNED OFF] Bug 13451: Holidays.t assumes default data This patch removes that assumption by expressly setting data to be default. TEST PLAN --------- 1) Ensure that branch code is NOT 'MPL' in the repeatable_holidays table in your database. 2) Ensure that branch codes 'MPL' and 'CPL' do not exist in the branches table in your database. 3) prove t/db_dependent/Holidays.t -- this should bomb horribly. 4) Apply patch 5) prove t/db_dependent/Holidays.t -- all tests should succeed. 6) run koha qa tests Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13451 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34377|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34379&action=edit [PASSED QA] Bug 13451: Holidays.t assumes default data This patch removes that assumption by expressly setting data to be default. TEST PLAN --------- 1) Ensure that branch code is NOT 'MPL' in the repeatable_holidays table in your database. 2) Ensure that branch codes 'MPL' and 'CPL' do not exist in the branches table in your database. 3) prove t/db_dependent/Holidays.t -- this should bomb horribly. 4) Apply patch 5) prove t/db_dependent/Holidays.t -- all tests should succeed. 6) run koha qa tests Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tests pass without holidays in the calendar. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13451 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- No string changes, pushed to 3.18.x will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes.