[Bug 33509] New: Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternat holdings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Bug ID: 33509 Summary: Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternat holdings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, michaela.sieber@kit.edu Depends on: 33032 With bug 33032 in 22.11.04 we now show "Other holdings" in the staff interface result list, when the alternate holdings field is not present in the record. Before this patch we showed "No items", which is correct in this case. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33032 [Bug 33032] Alternate holdings broken in staff interface search results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Staff search result list |Staff search result list |shows "other holdings" with |shows "other holdings" with |AlternateHoldingsField when |AlternateHoldingsField when |there are no alternat |there are no alternate |holdings |holdings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149575&action=edit Bug 33509: Don't show Other holdings when there are no alternate holdings With bug 33509 alternate holdings defined in AlternateHoldingsField are shown in the staff interface result list. This works greatly when there are items or when there is are alternate holdings (the configured field/subfields exist in the record), but not when there are no items and no alternate holdings. To test: * Add 100a to AlternateHoldingsField * Make a search with some records without items Sample data: perl * Make sure the alternate holdings show when there are no items and 100a exists * Change to 100z * Verify the result list now shows "Other holdings:" with nothing below * Apply patch * Repeat * Alternate holdings should still show nicely * Without alternate holdings 'no items' is displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149575|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 149616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149616&action=edit Bug 33509: Don't show Other holdings when there are no alternate holdings With bug 33509 alternate holdings defined in AlternateHoldingsField are shown in the staff interface result list. This works greatly when there are items or when there is are alternate holdings (the configured field/subfields exist in the record), but not when there are no items and no alternate holdings. To test: * Add 100a to AlternateHoldingsField * Make a search with some records without items Sample data: perl * Make sure the alternate holdings show when there are no items and 100a exists * Change to 100z * Verify the result list now shows "Other holdings:" with nothing below * Apply patch * Repeat * Alternate holdings should still show nicely * Without alternate holdings 'no items' is displayed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149616|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149639&action=edit Bug 33509: Don't show Other holdings when there are no alternate holdings With bug 33509 alternate holdings defined in AlternateHoldingsField are shown in the staff interface result list. This works greatly when there are items or when there is are alternate holdings (the configured field/subfields exist in the record), but not when there are no items and no alternate holdings. To test: * Add 100a to AlternateHoldingsField * Make a search with some records without items Sample data: perl * Make sure the alternate holdings show when there are no items and 100a exists * Change to 100z * Verify the result list now shows "Other holdings:" with nothing below * Apply patch * Repeat * Alternate holdings should still show nicely * Without alternate holdings 'no items' is displayed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in| |21.11.21 --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org