https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |januszop@gmail.com |ity.org | Status|NEW |Needs Signoff --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 148245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148245&action=edit Bug 33238 (Bug 29886 follow-up) With IndependentBranches Koha explodes with Error 500 when a non superlibrarian tries to add to basket from suggestions With IndependentBranches Koha explodes with Error 500 when a non superlibrarian tries to add to basket from suggestions. In errorlog you would find "DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'branchcode' in where clause is ambiguous". Test plan: ========== 1. Have a Koha instance with IndependentBranches, some accepted suggestions, and a vendor defined. 2. Be a non superlibrarian librarian with permissions to manage acquisitions. 3. Create a new basket and try to add an item to the basket "From a suggestion". 4. Koha would generate error 500. 5. Apply the patch. 6. Try to add an item to the basket "From a suggestion". 7. You should succeed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148245|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149726&action=edit Bug 33238 (Bug 29886 follow-up) With IndependentBranches Koha explodes with Error 500 when a non superlibrarian tries to add to basket from suggestions With IndependentBranches Koha explodes with Error 500 when a non superlibrarian tries to add to basket from suggestions. In errorlog you would find "DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'branchcode' in where clause is ambiguous". Test plan: ========== 1. Have a Koha instance with IndependentBranches, some accepted suggestions, and a vendor defined. 2. Be a non superlibrarian librarian with permissions to manage acquisitions. 3. Create a new basket and try to add an item to the basket "From a suggestion". 4. Koha would generate error 500. 5. Apply the patch. 6. Try to add an item to the basket "From a suggestion". 7. You should succeed. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- QA script is not happy with this one. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149726|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 149751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149751&action=edit Bug 33238: Fix bad suggestions query (Bug 29886 follow-up) With IndependentBranches Koha explodes with Error 500 when a non superlibrarian tries to add to basket from suggestions. In errorlog you would find "DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'branchcode' in where clause is ambiguous". Test plan: ========== 1. Have a Koha instance with IndependentBranches, some accepted suggestions, and a vendor defined. 2. Be a non superlibrarian librarian with permissions to manage acquisitions. 3. Create a new basket and try to add an item to the basket "From a suggestion". 4. Koha would generate error 500. 5. Apply the patch. 6. Try to add an item to the basket "From a suggestion". 7. You should succeed. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|(Bug 29886 follow-up) With |Error adding suggestion to |IndependentBranches Koha |basket as |explodes with Error 500 |non-superlibrarian (Bug |when a non superlibrarian |29886 follow-up) |tries to add to basket from | |suggestions | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in| |21.11.21 CC| |arthur.suzuki@biblibre.com --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes.