[Bug 13307] New: Create a link to the last advanced search in search result page (OPAC)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Bug ID: 13307 Summary: Create a link to the last advanced search in search result page (OPAC) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: simith.doliveira@inlibro.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |simith.doliveira@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #1 from simith.doliveira@inlibro.com --- Created attachment 33741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33741&action=edit Create a link to the last advanced search in search result page (OPAC) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #2 from simith.doliveira@inlibro.com --- This patch add a link in the search result page to the last advanced search if the last search is a advanced search. If the last search is a simple search, no link is added. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) Testing: I - Open opac main page and execute a simple search validate no link II - Open opac advanced search page, chose some options and execute a search. validate a link - Click on the link validate the advanced search page and the options. III - Open opac advanced search page, chose some options and execute a search. validate a link - If it got some pages, click on next or a page, then click on the link validate the advanced search page and the options. IV - Open opac advanced search page, click the button "more options", chose some options (add a field to search - bouton [+]) and execute a search. validate a link - Click on the link validate the advanced search page and the options. V - Open opac advanced search page, chose some options and execute a search. validate a link - Execute a simple search validate no link. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com, | |francois.charbonnier@inlibr | |o.com, | |marjorie.barry-vila@ccsr.qc | |.ca, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- This is a nice feature and it seems to be working well. I have some suggestions for ways to make the patch conform better to some existing practices: - <script> blocks should not be added to masthead.inc. In the bootstrap theme JavaScript is placed at the end of the document: opac-bottom.inc - jQuery plugins which are included by OPAC pages should be minified. I think it's helpful to add both the minified and non-minified versions even if we only link to the minified version. But that's not an agreed-upon rule. - The "Return to the last advanced search" link should be added to the DOM (or made visible) using JavaScript since the feature depends on JavaScript. Users without JS should not see the link. I'm curious why you use the jQuery.cookie plugin in some code but not in the changes you made to masthead.inc? Finally: This patch makes changes to .htaccess and it should not. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33741|0 |1 is obsolete| | --- Comment #4 from simith.doliveira@inlibro.com --- Created attachment 33801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33801&action=edit Create a link to the last advanced search in search result page (OPAC) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from simith.doliveira@inlibro.com --- Concerning some suggestions/error : - <script> blocks should not be added to masthead.inc. In the bootstrap theme JavaScript is placed at the end of the document: opac-bottom.inc Done - jQuery plugins which are included by OPAC pages should be minified. I think it's helpful to add both the minified and non-minified versions even if we only link to the minified version. But that's not an agreed-upon rule. Done. But I included just the minifieds. - The "Return to the last advanced search" link should be added to the DOM (or made visible) using JavaScript since the feature depends on JavaScript. Users without JS should not see the link. The link is controlled by a cookie, this cookie est created by js, so, without js, no link. I'm curious why you use the jQuery.cookie plugin in some code but not in the changes you made to masthead.inc? Both use jQuery.cookie now. Finally: This patch makes changes to .htaccess and it should not. Corrected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |cbrannon@cdalibrary.org --- Comment #6 from Christopher Brannon <cbrannon@cdalibrary.org> --- After clicking "Return to the last advanced search" link, the top portion of the advanced search page, with all search boxes, disappears. Can't edit the original search terms! I will include a screen shot. Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #7 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 34050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34050&action=edit Search boxes disappear when returning to advanced search -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #8 from simith.doliveira@inlibro.com --- Created attachment 34095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34095&action=edit Fix Patch- Search boxes disappear when returning to advanced search -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34050|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #9 from Marc Véron <veron@veron.ch> --- I like this feature. However I found the following: 1) Search e.g. for Author = Goethe and Title = Faust 2) The link back to the last advanced search appears as expected. 3) After clicking the link, I get the advanced search page with Keyword = Goethe and Keyword = Faust (instead of Author and Title) Marc PS: Applying patch did a 3-way-merge -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #10 from simith.doliveira@inlibro.com --- Created attachment 34362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34362&action=edit Fix jquery.deseriable.min.js -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34362|0 |1 is obsolete| | --- Comment #11 from simith.doliveira@inlibro.com --- Created attachment 34363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34363&action=edit Fix jquery.deseriable.min.js -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #12 from simith.doliveira@inlibro.com --- Error comment 9 fixed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #13 from Marc Véron <veron@veron.ch> --- Created attachment 34374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34374&action=edit [Signed-off] Create a link to the last advanced search in search result page (OPAC) http://bugs.koha-community.org/show_bug.cgi?id=13307 Followed test plan, works as expected (together with other patches) Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #14 from Marc Véron <veron@veron.ch> --- Created attachment 34375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34375&action=edit [Signed-off] Fix Patch- Search boxes disappear when returning to advanced search http://bugs.koha-community.org/show_bug.cgi?id=13307 Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #15 from Marc Véron <veron@veron.ch> --- Created attachment 34376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34376&action=edit [Signed-off] Fix jquery.deseriable.min.js http://bugs.koha-community.org/show_bug.cgi?id=13307 Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33801|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34095|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34363|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|trivial |enhancement -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34374|0 |1 is obsolete| | Attachment #34375|0 |1 is obsolete| | Attachment #34376|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34590&action=edit [PASSED QA] Create a link to the last advanced search in search result page (OPAC) http://bugs.koha-community.org/show_bug.cgi?id=13307 Followed test plan, works as expected (together with other patches) Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> http://bugs.koha-community.org/show_bug.cgi?id=13364 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34591&action=edit [PASSED QA] Fix Patch- Search boxes disappear when returning to advanced search http://bugs.koha-community.org/show_bug.cgi?id=13307 Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> http://bugs.koha-community.org/show_bug.cgi?id=13364 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34592&action=edit [PASSED QA] Fix jquery.deseriable.min.js http://bugs.koha-community.org/show_bug.cgi?id=13307 Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> http://bugs.koha-community.org/show_bug.cgi?id=13364 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34593&action=edit [PASSED QA] Bug 13307 [QA Followup] Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> http://bugs.koha-community.org/show_bug.cgi?id=13364 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=1356 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Enhancement pushed to master. Thanks Simith! Note: I ammended the commit messages. Please try to include bug number and better descriptions of what the patches are for. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14351 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, it looks like a given-when structure slipped in with this. The feature is experimental and should not be used, I filed bug 14351. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org