http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 --- Comment #1 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 30752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30752&action=edit Bug 11401 - Add support for Norwegian national library card This patch makes it possible to sync patron data between Koha and the Norwegian national patron database, in both directions. In order to use this, a username/password from the Norwegian national database of libraries ("Base Bibliotek") is needed. A special key is also needed, in order to decrypt and encrypt PIN-codes/passwords. See http://www.lanekortet.no/ for more information (in Norwegian). While this is of course an implementation of a specific synchronization scheme for borrower data, attempts have been made to prepare the ground for other sync schemes that might be implemented later. Especially the structure of the new borrower_sync table might be reviewed with an eye to how it might fit other schemes. To test: Since the password and cryptographic key needed to use this functionality is only available to Norwegian library system vendors, only regression testing can be done on the submitted code. Suggested things to check: - Apply the patch and make sure the database update is done. This should add the new "borrower_sync" table and five new systmpreferences under the "Patrons" > "Norwegian patron database" category: - NorwegianPatronDBEnable - NorwegianPatronDBEndpoint - NorwegianPatronDBUsername - NorwegianPatronDBPassword - NorwegianPatronDBSearchNLAfterLocalHit - Check that patrons can be created, edited and deleted as usual, when NorwegianPatronDBEnable is set to "Disable" - Check that the new tests in t/NorwegianPatronDB.pm run ok, e.g. on a gitified setup: $ sudo koha-shell -c "PERL5LIB=/path/to/kohaclone prove -v t/NorwegianPatronDB.t" instancename - Check that all the other tests still run ok - Check that the POD in the new files itroduced by this patch looks ok: - Koha/NorwegianPatronDB.pm - members/nl-search.pl - misc/cronjobs/nl-sync-from-koha.pl - misc/cronjobs/nl-sync-to-koha.pl - t/NorwegianPatronDB.t Note: koha-qa.pl complains about tabs in deletemem.tt, but the lines it complains about have not been touched by this patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Magnus, I dont think you need to include the schema files, (one of them is conflicting). The RM can generate those when the patches are pushed -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 --- Comment #5 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 31711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31711&action=edit Bug 11401 - Add support for Norwegian national library card This patch makes it possible to sync patron data between Koha and the Norwegian national patron database, in both directions. In order to use this, the following information is necessary: - a username/password from the Norwegian national database of libraries ("Base Bibliotek"), available to all Norwegian libraries - a special key in order to decrypt and encrypt PIN-codes/passwords, which is only available to Norwegian library system vendors - a norwegian library vendor username/password See http://www.lanekortet.no/ for more information (in Norwegian). While this is of course an implementation of a specific synchronization scheme for borrower data, attempts have been made to prepare the ground for other sync schemes that might be implemented later. Especially the structure of the new borrower_sync table might be reviewed with an eye to how it might fit other schemes. To test: Since the password and cryptographic key needed to use this functionality is only available to Norwegian library system vendors, only regression testing can be done on the submitted code. Suggested things to check: - Apply the patch and make sure the database update is done. This should add the new "borrower_sync" table and five new systmpreferences under the "Patrons" > "Norwegian patron database" category: - NorwegianPatronDBEnable - NorwegianPatronDBEndpoint - NorwegianPatronDBUsername - NorwegianPatronDBPassword - NorwegianPatronDBSearchNLAfterLocalHit - Check that patrons can be created, edited and deleted as usual, when NorwegianPatronDBEnable is set to "Disable" - Check that the new tests in t/NorwegianPatronDB.pm run ok, e.g. on a gitified setup: $ sudo koha-shell -c "PERL5LIB=/path/to/kohaclone prove -v t/NorwegianPatronDB.t" instancename - Check that all the other tests still run ok - Check that the POD in the new files itroduced by this patch looks ok: - Koha/NorwegianPatronDB.pm - members/nl-search.pl - misc/cronjobs/nl-sync-from-koha.pl - misc/cronjobs/nl-sync-to-koha.pl - t/NorwegianPatronDB.t Note: koha-qa.pl complains about tabs in deletemem.tt, but the lines it complains about have not been touched by this patch. Update 2014-09-18: Rebase on master, split out changes to Koha::Schema, incorporate new way of authenticating with NL -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31710|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 31815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31815&action=edit Bug 11401 - Changes to Koha::Schema Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31711|0 |1 is obsolete| | --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 31816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31816&action=edit Bug 11401 - Add support for Norwegian national library card This patch makes it possible to sync patron data between Koha and the Norwegian national patron database, in both directions. In order to use this, the following information is necessary: - a username/password from the Norwegian national database of libraries ("Base Bibliotek"), available to all Norwegian libraries - a special key in order to decrypt and encrypt PIN-codes/passwords, which is only available to Norwegian library system vendors - a norwegian library vendor username/password See http://www.lanekortet.no/ for more information (in Norwegian). While this is of course an implementation of a specific synchronization scheme for borrower data, attempts have been made to prepare the ground for other sync schemes that might be implemented later. Especially the structure of the new borrower_sync table might be reviewed with an eye to how it might fit other schemes. To test: Since the password and cryptographic key needed to use this functionality is only available to Norwegian library system vendors, only regression testing can be done on the submitted code. Suggested things to check: - Apply the patch and make sure the database update is done. This should add the new "borrower_sync" table and five new systmpreferences under the "Patrons" > "Norwegian patron database" category: - NorwegianPatronDBEnable - NorwegianPatronDBEndpoint - NorwegianPatronDBUsername - NorwegianPatronDBPassword - NorwegianPatronDBSearchNLAfterLocalHit - Check that patrons can be created, edited and deleted as usual, when NorwegianPatronDBEnable is set to "Disable" - Check that the new tests in t/NorwegianPatronDB.pm run ok, e.g. on a gitified setup: $ sudo koha-shell -c "PERL5LIB=/path/to/kohaclone prove -v t/NorwegianPatronDB.t" instancename - Check that all the other tests still run ok - Check that the POD in the new files itroduced by this patch looks ok: - Koha/NorwegianPatronDB.pm - members/nl-search.pl - misc/cronjobs/nl-sync-from-koha.pl - misc/cronjobs/nl-sync-to-koha.pl - t/NorwegianPatronDB.t Note: koha-qa.pl complains about tabs in deletemem.tt, but the lines it complains about have not been touched by this patch. Update 2014-09-18: Rebase on master, split out changes to Koha::Schema, incorporate new way of authenticating with NL Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Have tested for regressions, none found, will sign off. The only suggestion I have is that we could perhaps use Module::Load::Conditional in C4/Members.pm, so that we don't have to load the module unless we need it. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin@catalyst.net.nz --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Magnus, I sat with Tomas and we noticed that you might have a typoe in the version number here: + 'Digest::SHA' => { + 'usage' => 'Norwegian national library card', + 'required' => '0', + 'min_ver' => '5.84_01', + }, Also, we might have to get Convert:BaseN packaged (also Test::DBIX::Class for this and Shibboleth) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 --- Comment #12 from Magnus Enger <magnus@enger.priv.no> --- (In reply to Katrin Fischer from comment #9)

Hi Magnuse,

- I'd like to see the change that Chris pointed out - make the loading of the module mandatory.

Did you mean *not* mandatory?

One important reason being that the new dependencies are not marked as mandatory, but without them the test suite won't work - a lot of the tests fail because of the missing dependencies on my system.

Hm, I have some checks for the modules I have used in t/NorwegianPatronDB.t which should ensure the tests in it are skipped if any of the modules are missing. However, I had use'd one of the modules (SOAP::Lite) at the top of the test script, maybe that was tripping you up? Or were you seeing other tests fail because of the National library card stuff? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Magnus Enger from comment #13)

(In reply to Chris Cormack from comment #8)

...

The only suggestion I have is that we could perhaps use Module::Load::Conditional in C4/Members.pm, so that we don't have to load the module unless we need it.

Something like

use Module::Load::Conditional qw( can_load ); can_load( modules => { 'Koha::NorwegianPatronDB qw( NLUpdateHashedPIN NLEncryptPIN NLSync )' => undef } );

instead of plain old

use Koha::NorwegianPatronDB qw( NLUpdateHashedPIN NLEncryptPIN NLSync );

?

Yep except wrap it in an if if (syspref is set) { can_load .... } eg in Koha::QueryParser::Driver::PQF we do if ( $format eq 'json' && can_load( modules => { 'JSON' => undef } ) ) { Hope this helps -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 --- Comment #16 from Robin Sheat <robin@catalyst.net.nz> --- libconvert-basen-perl has been uploaded to Debian, and is in the Koha repo. Can you please test it? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31816|0 |1 is obsolete| | --- Comment #17 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 32546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32546&action=edit Bug 11401 - Add support for Norwegian national library card This patch makes it possible to sync patron data between Koha and the Norwegian national patron database, in both directions. In order to use this, the following information is necessary: - a username/password from the Norwegian national database of libraries ("Base Bibliotek"), available to all Norwegian libraries - a special key in order to decrypt and encrypt PIN-codes/passwords, which is only available to Norwegian library system vendors - a norwegian library vendor username/password See http://www.lanekortet.no/ for more information (in Norwegian). While this is of course an implementation of a specific synchronization scheme for borrower data, attempts have been made to prepare the ground for other sync schemes that might be implemented later. Especially the structure of the new borrower_sync table might be reviewed with an eye to how it might fit other schemes. To test: Since the password and cryptographic key needed to use this functionality is only available to Norwegian library system vendors, only regression testing can be done on the submitted code. Suggested things to check: - Apply the patch and make sure the database update is done. This should add the new "borrower_sync" table and five new systmpreferences under the "Patrons" > "Norwegian patron database" category: - NorwegianPatronDBEnable - NorwegianPatronDBEndpoint - NorwegianPatronDBUsername - NorwegianPatronDBPassword - NorwegianPatronDBSearchNLAfterLocalHit - Check that patrons can be created, edited and deleted as usual, when NorwegianPatronDBEnable is set to "Disable" - Check that the new tests in t/NorwegianPatronDB.pm run ok, e.g. on a gitified setup: $ sudo koha-shell -c "PERL5LIB=/path/to/kohaclone prove -v t/NorwegianPatronDB.t" instancename - Check that all the other tests still run ok - Check that the POD in the new files itroduced by this patch looks ok: - Koha/NorwegianPatronDB.pm - members/nl-search.pl - misc/cronjobs/nl-sync-from-koha.pl - misc/cronjobs/nl-sync-to-koha.pl - t/NorwegianPatronDB.t Sponsored-by: Oslo Public Library Update 2014-09-18: - Rebase on master - Split out changes to Koha::Schema - Incorporate new way of authenticating with NL Update 2014-10-21: - Rebase on master - Use Module::Load to load Koha::NorwegianPatronDB in non-NL-specific scripts and modules - Fix the version number of Digest::SHA - Fix a missing semicolon in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we are not quite there yet :( Crypt/GCrypt.pm is marked non-mandatory, but seems to make the tests fail, if it's missing: OK C4/Installer/PerlDependencies.pm OK critic OK forbidden patterns OK pod OK valid FAIL C4/Members.pm OK critic OK forbidden patterns OK pod FAIL valid Use of uninitialized value in numeric eq (==) FAIL Koha/NorwegianPatronDB.pm OK critic OK forbidden patterns OK pod FAIL valid Can't locate Crypt/GCrypt.pm in @INC (you may need to install the Crypt::GCrypt module) (@INC contains: /home/katrin/kohaclone /home/katrin/qa-test-tools /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl .) OK installer/data/mysql/updatedatabase.pl OK critic OK forbidden patterns OK pod OK valid FAIL members/deletemem.pl OK critic OK forbidden patterns OK pod FAIL valid Use of uninitialized value in numeric eq (==) FAIL members/memberentry.pl OK critic OK forbidden patterns OK pod FAIL valid Use of uninitialized value in numeric eq (==) FAIL members/moremember.pl OK critic OK forbidden patterns OK pod FAIL valid Use of uninitialized value in numeric eq (==) FAIL members/nl-search.pl OK critic OK forbidden patterns OK pod FAIL valid Use of uninitialized value in numeric eq (==) BEGIN failed--compilation aborted Can't locate Crypt/GCrypt.pm in @INC (you may need to install the Crypt::GCrypt module) (@INC contains: /home/katrin/kohaclone /home/katrin/qa-test-tools /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl .) Compilation failed in require FAIL misc/cronjobs/nl-sync-from-koha.pl OK critic OK forbidden patterns FAIL pod *** ERROR: empty =head2 in file misc/cronjobs/nl-sync-from-koha.pl FAIL valid Can't locate Crypt/GCrypt.pm in @INC (you may need to install the Crypt::GCrypt module) (@INC contains: /home/katrin/kohaclone /home/katrin/qa-test-tools /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl .) BEGIN failed--compilation aborted Compilation failed in require FAIL misc/cronjobs/nl-sync-to-koha.pl OK critic OK forbidden patterns OK pod FAIL valid Compilation failed in require BEGIN failed--compilation aborted Can't locate Crypt/GCrypt.pm in @INC (you may need to install the Crypt::GCrypt module) (@INC contains: /home/katrin/kohaclone /home/katrin/qa-test-tools /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl .) Use of uninitialized value in numeric eq (==) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 --- Comment #21 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 32888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32888&action=edit Bug 11401 - QA followup - fix pod The QA script was complaining about some dodgy POD in C4/Members.pm, that was not introduced by bug 11401. This patch fixes the POD, to keep the QA script happy. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32889|0 |1 is obsolete| | --- Comment #23 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 32890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32890&action=edit Bug 11401 - QA followup 1) Be more careful when checking the NorwegianPatronDBEnable syspref. Before: if ( C4::Context->preference('NorwegianPatronDBEnable') == 1 ) { After: if ( C4::Context->preference('NorwegianPatronDBEnable') && C4::Context->preference('NorwegianPatronDBEnable') == 1 ) { This should avoid complaints if the syspref is not initialized. 2) Fix some empty =head2 POD sections 3) Fix some indentation in patrons.pref, to make xt/yaml_valid.t happy -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32950&action=edit [PASSED QA] Bug 11401 - Add support for Norwegian national library card This patch makes it possible to sync patron data between Koha and the Norwegian national patron database, in both directions. In order to use this, the following information is necessary: - a username/password from the Norwegian national database of libraries ("Base Bibliotek"), available to all Norwegian libraries - a special key in order to decrypt and encrypt PIN-codes/passwords, which is only available to Norwegian library system vendors - a norwegian library vendor username/password See http://www.lanekortet.no/ for more information (in Norwegian). While this is of course an implementation of a specific synchronization scheme for borrower data, attempts have been made to prepare the ground for other sync schemes that might be implemented later. Especially the structure of the new borrower_sync table might be reviewed with an eye to how it might fit other schemes. To test: Since the password and cryptographic key needed to use this functionality is only available to Norwegian library system vendors, only regression testing can be done on the submitted code. Suggested things to check: - Apply the patch and make sure the database update is done. This should add the new "borrower_sync" table and five new systmpreferences under the "Patrons" > "Norwegian patron database" category: - NorwegianPatronDBEnable - NorwegianPatronDBEndpoint - NorwegianPatronDBUsername - NorwegianPatronDBPassword - NorwegianPatronDBSearchNLAfterLocalHit - Check that patrons can be created, edited and deleted as usual, when NorwegianPatronDBEnable is set to "Disable" - Check that the new tests in t/NorwegianPatronDB.pm run ok, e.g. on a gitified setup: $ sudo koha-shell -c "PERL5LIB=/path/to/kohaclone prove -v t/NorwegianPatronDB.t" instancename - Check that all the other tests still run ok - Check that the POD in the new files itroduced by this patch looks ok: - Koha/NorwegianPatronDB.pm - members/nl-search.pl - misc/cronjobs/nl-sync-from-koha.pl - misc/cronjobs/nl-sync-to-koha.pl - t/NorwegianPatronDB.t Sponsored-by: Oslo Public Library Update 2014-09-18: - Rebase on master - Split out changes to Koha::Schema - Incorporate new way of authenticating with NL Update 2014-10-21: - Rebase on master - Use Module::Load to load Koha::NorwegianPatronDB in non-NL-specific scripts and modules - Fix the version number of Digest::SHA - Fix a missing semicolon in kohastructure.sql Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32952&action=edit [PASSED QA] Bug 11401 - QA followup 1) Be more careful when checking the NorwegianPatronDBEnable syspref. Before: if ( C4::Context->preference('NorwegianPatronDBEnable') == 1 ) { After: if ( C4::Context->preference('NorwegianPatronDBEnable') && C4::Context->preference('NorwegianPatronDBEnable') == 1 ) { This should avoid complaints if the syspref is not initialized. 2) Fix some empty =head2 POD sections 3) Fix some indentation in patrons.pref, to make xt/yaml_valid.t happy Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I couldn't find any regressions with adding, editing and deleting members. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32888|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32607|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 --- Comment #28 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 33528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33528&action=edit Bug 11401 - QA followup - Make the tests pass The configs in koha-conf.xml needed to be mocked. There was also a problem with how the NorwegianPatronDBEndpoint syspref was getting checked in the .pm. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Magnus and everyone involved in testing! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13303 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14350 -- You are receiving this mail because: You are watching all bug changes.