[Bug 36876] New: In Table settings words are split in two and some of them cannot be translated into Finnish
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 Bug ID: 36876 Summary: In Table settings words are split in two and some of them cannot be translated into Finnish Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: anneli.osterman@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org I'm translating the main into Finnish and there are new translations for Table settings. The two word headings have been for some reason split into two different strings. One of them can still be translated but for example word "Interlibrary loans" is one word in Finnish, "Kaukolainat", and is hard to split in two. You'd have to put the whole word into the first string and leave the other one empty. https://translate.koha-community.org/translate/koha/main/staff-prog/fi/?chec... %s %s %s %s %s Interlibrary https://translate.koha-community.org/translate/koha/main/staff-prog/fi/?chec... loans It comes from here https://github.com/Koha-Community/Koha/blob/main/koha-tmpl/intranet-tmpl/pro... [% WRAPPER accordion_item %] [% WRAPPER accordion_heading panel_id="illrequests" %] Interlibrary <span>loans</span> [% END %] Others that have been split too: [% WRAPPER accordion_item %] [% WRAPPER accordion_heading panel_id="coursereserves" %] Course <span>reserves</span> [% END %] In Finnish: Kurssivarannot [% WRAPPER accordion_item %] [% WRAPPER accordion_heading panel_id="pos" %] Point of <span>sale</span> [% END %] In Finnish: Myyntipiste [% WRAPPER accordion_item %] [% WRAPPER accordion_heading panel_id="erm" %] E-resource <span>management</span> [% END %] In Finnish: E-ainestojen hallinta Could these strings be unsplit? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority Severity|enhancement |normal --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- That's been some really good detective work, Anneli! I hope we can have a fix before the end of the week (similar issues for German). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|In Table settings words are |In table settings words are |split in two and some of |split in two and some of |them cannot be translated |them cannot be translated |into Finnish |properly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166820&action=edit Bug 36876: Correct <span>s around translatable strings in table settings This patch corrects the way translatable strings are handled in the table settings template. The switch to Bootstrap WRAPPERs for the accordion widget included several errors. To test, apply the patch and go to Administration -> Table settings. - Confirm that the sections expand and collapse correctly. - Test the translation process with a language, e.g. fr-FR: - In KTD, run: gulp po:update --lang fr-FR - Check fr-FR-staff-prog.po for the line referring to koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt:298 - It should show the whole string "Interlibrary loans" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major Depends on| |35883 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35883 [Bug 35883] Use template wrapper for accordions: Table settings administration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org Component|Templates |I18N/L10N CC| |f.demians@tamil.fr, | |jonathan.druart@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166820|0 |1 is obsolete| | --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 166839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166839&action=edit Bug 36876: Correct <span>s around translatable strings in table settings This patch corrects the way translatable strings are handled in the table settings template. The switch to Bootstrap WRAPPERs for the accordion widget included several errors. To test, apply the patch and go to Administration -> Table settings. - Confirm that the sections expand and collapse correctly. - Test the translation process with a language, e.g. fr-FR: - In KTD, run: gulp po:update --lang fr-FR - Check fr-FR-staff-prog.po for the line referring to koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt:298 - It should show the whole string "Interlibrary loans" Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166839|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 166880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166880&action=edit Bug 36876: Correct <span>s around translatable strings in table settings This patch corrects the way translatable strings are handled in the table settings template. The switch to Bootstrap WRAPPERs for the accordion widget included several errors. To test, apply the patch and go to Administration -> Table settings. - Confirm that the sections expand and collapse correctly. - Test the translation process with a language, e.g. fr-FR: - In KTD, run: gulp po:update --lang fr-FR - Check fr-FR-staff-prog.po for the line referring to koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt:298 - It should show the whole string "Interlibrary loans" Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Bug 35883 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 Bug 36876 depends on bug 35883, which changed state. Bug 35883 Summary: Use template wrapper for accordions: Table settings administration https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35883 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org