https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32485 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbrown@bywatersolutions.com --- Comment #1 from Sara Brown <sbrown@bywatersolutions.com> --- +1 This would be really helpful when the message is the same for all items of the type vs. having to manually add a materials specified note to each applicable item! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32485 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32485 --- Comment #3 from Sam Lau <samalau@gmail.com> --- Created attachment 170114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170114&action=edit Bug 32485: DB Updates Add new 'checkoutmsg' and 'checkoutmsgtype' columns to 'itemtypes' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32485 --- Comment #5 from Sam Lau <samalau@gmail.com> --- Created attachment 170116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170116&action=edit Bug 32485: Unit tests prove t/Koha/ItemType.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32485 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |roman.dolny@jezuici.pl --- Comment #6 from Roman Dolny <roman.dolny@jezuici.pl> --- Two notes after testing: 1. there is no "Checkout message" column in item types table (Administration->Item types), 2. probably checkout messages should be placed in messages section (id="messages") not in mainform (id="mainform"). QA script: WARN Koha/Schema/Result/Itemtype.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 77, now: 86) WARN admin/itemtypes.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 62, now: 66) WARN circ/circulation.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 285, now: 290) WARN t/Koha/ItemType.t WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 7) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32485 --- Comment #8 from Sam Lau <samalau@gmail.com> --- (In reply to Roman Dolny from comment #6)

1. there is no "Checkout message" column in item types table (Administration->Item types),

Fixed this.

2. probably checkout messages should be placed in messages section (id="messages") not in mainform (id="mainform").

Not exactly, that's included in messages.inc which is used in a lot of different places. However, I moved the dialog message/alert to the top of the screen, around where the messages div resides.

QA script: WARN These are all unrelated to my changes.

However, still not ready for testing... noticed that checkin_message is utilized in SIP, thus, checkout message should probably be there too, so still some work to be done here. -- You are receiving this mail because: You are watching all bug changes.