[Bug 34185] New: Code mises OpacItemLocation and OPACItemLocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34185 Bug ID: 34185 Summary: Code mises OpacItemLocation and OPACItemLocation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We have some OpacItemLocation and some OPACItemLocation in the code. Usually not a great idea. Would be nice to clean that up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Code mises OpacItemLocation |Code mixes OpacItemLocation |and OPACItemLocation |and OPACItemLocation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34185 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34185 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 170920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170920&action=edit Bug 34185: Capitalized OPAC in OpacItemLocation syspref To test: 1. In K-T-D git grep for “OpacItemLocation” 1. Notice that related XSLT / XSL scripts are not coming up. Only .pm, .pl and .sql scripts. 2. Git grep for “OPACItemLocation”. Note that XSLT/XSL files show up but not the .pm, .pl and .sql scripts. 3. Apply the patch. Updatedatabase. Restart_all 4. Git grep for “OPACItemLocation” 1. Notice that both the XSLT/XSL files in addition to the .sql, .pm and .pl scripts are now showing up. 5. Sign off and have a spectacular day :D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34185 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34185 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34185 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170920|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 170925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170925&action=edit Bug 34185: Capitalized OPAC in OpacItemLocation syspref To test: 1. In K-T-D git grep for “OpacItemLocation” 1. Notice that related XSLT / XSL scripts are not coming up. Only .pm, .pl and .sql scripts. 2. Git grep for “OPACItemLocation”. Note that XSLT/XSL files show up but not the .pm, .pl and .sql scripts. 3. Apply the patch. Updatedatabase. Restart_all 4. Git grep for “OPACItemLocation” 1. Notice that both the XSLT/XSL files in addition to the .sql, .pm and .pl scripts are now showing up. 5. Sign off and have a spectacular day :D Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Laura, I see that you have this step in your test plan: 3. Apply the patch. Updatedatabase. Restart_all But your patch doesn't include a database update. I think it might be nice to update the existing installations with the correct spelling, what do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA Keywords|Academy |additional_work_needed --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I need to get better about removing tested patches from my branch... could you please provide the database update as a follow-up? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Keywords|additional_work_needed | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #4)
I need to get better about removing tested patches from my branch... could you please provide the database update as a follow-up?
Dropping this. It can be resolved later, but I believe it does not actually cause issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34185 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org