[Bug 37177] New: "item" should be "record" in list page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 Bug ID: 37177 Summary: "item" should be "record" in list page Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: mathsabypro@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Currently a list can contain records, but not items. So the terminology used in virtualshelves/shelves.pl can be misleading : - in the table of lists, the "content" column contains "250 items" => it should be "250 records" - when we try to add records to a list (virtualshelves/shelves.pl?op=view&shelfnumber=1 ), there is a "Add items" button => it should be "Add records" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 --- Comment #1 from Mathieu Saby <mathsabypro@gmail.com> --- The same remarks applies to cart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170184&action=edit Bug 37177: "item" should be "record" in list page This patch rewords areas of the lists and cart templates so that the term "record" is preferred over "item" when referring to a bibliographic record. To test, apply the patch and go to Lists in the staff interface. - If necessary, create a new list. - From the list contents view, click "Add records" in the toolbar. - Submit some valid barcodes and biblionumbers - After adding biblionumbers you should see the message "The record ( [number] ) has been added to the list" - After adding barcodes you should see the message "The record for this item ( [barcode] ) has been added to the list" - Click "Add records" again - Submit some of the same barcodes and biblionumbers - You should see these messages: - "The record for this item ( [barcode] ) has not been added to the list. Please verify it is not already in the list." - "The record ( [number] ) has not been added to the list. Please verify it is not already in the list. - Check the checkbox for one or more titles on your list and click "Remove selected" - You should see the message, "The record has been removed from the list." - Perform a catalog search and from the results screen, select one or more results and add them to the cart. - Open the Cart and confirm that the controls at the top of the table of titles reads "Selected records: ..." Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roman.dolny@jezuici.pl --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- (In reply to Owen Leonard from comment #2)
Created attachment 170184 [details] [review] Bug 37177: "item" should be "record" in list page
This patch rewords areas of the lists and cart templates so that the term "record" is preferred over "item" when referring to a bibliographic record.
To test, apply the patch and go to Lists in the staff interface. ...
It works as described in test plan, but: 1. there is still "... items" in the table of lists (the "content" column) 2. when adding selected record(s) to the cart (search > results screen) there is a message "... item(s) added to your cart" or "No item was added to your cart" shown after clicking button "Add to cart" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170184|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170236&action=edit Bug 37177: "item" should be "record" in list page This patch rewords areas of the lists and cart templates so that the term "record" is preferred over "item" when referring to a bibliographic record. To test, apply the patch and go to Lists in the staff interface. - If necessary, create a new list. - From the list contents view, click "Add records" in the toolbar. - Submit some valid barcodes and biblionumbers - After adding biblionumbers you should see the message "The record ( [number] ) has been added to the list" - After adding barcodes you should see the message "The record for this item ( [barcode] ) has been added to the list" - Click "Add records" again - Submit some of the same barcodes and biblionumbers - You should see these messages: - "The record for this item ( [barcode] ) has not been added to the list. Please verify it is not already in the list." - "The record ( [number] ) has not been added to the list. Please verify it is not already in the list. - Check the checkbox for one or more titles on your list and click "Remove selected" - You should see the message, "The record has been removed from the list." - Perform a catalog search and from the results screen, select one or more results and add them to the cart. - Open the Cart and confirm that the controls at the top of the table of titles reads "Selected records: ..." Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170236|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170239&action=edit Bug 37177: "item" should be "record" in list page This patch rewords areas of the lists and cart templates so that the term "record" is preferred over "item" when referring to a bibliographic record. To test, apply the patch and go to Lists in the staff interface. - If necessary, create a new list. - From the list contents view, click "Add records" in the toolbar. - Submit some valid barcodes and biblionumbers - After adding biblionumbers you should see the message "The record ( [number] ) has been added to the list" - After adding barcodes you should see the message "The record for this item ( [barcode] ) has been added to the list" - Click "Add records" again - Submit some of the same barcodes and biblionumbers - You should see these messages: - "The record for this item ( [barcode] ) has not been added to the list. Please verify it is not already in the list." - "The record ( [number] ) has not been added to the list. Please verify it is not already in the list. - Check the checkbox for one or more titles on your list and click "Remove selected" - You should see the message, "The record has been removed from the list." - Perform a catalog search and from the results screen, select one or more results and add them to the cart. - Open the Cart and confirm that the controls at the top of the table of titles reads "Selected records: ..." Sponsored-by: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170239|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 170428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170428&action=edit Bug 37177: "item" should be "record" in list page This patch rewords areas of the lists and cart templates so that the term "record" is preferred over "item" when referring to a bibliographic record. To test, apply the patch and go to Lists in the staff interface. - If necessary, create a new list. - From the list contents view, click "Add records" in the toolbar. - Submit some valid barcodes and biblionumbers - After adding biblionumbers you should see the message "The record ( [number] ) has been added to the list" - After adding barcodes you should see the message "The record for this item ( [barcode] ) has been added to the list" - Click "Add records" again - Submit some of the same barcodes and biblionumbers - You should see these messages: - "The record for this item ( [barcode] ) has not been added to the list. Please verify it is not already in the list." - "The record ( [number] ) has not been added to the list. Please verify it is not already in the list. - Check the checkbox for one or more titles on your list and click "Remove selected" - You should see the message, "The record has been removed from the list." - Perform a catalog search and from the results screen, select one or more results and add them to the cart. - Open the Cart and confirm that the controls at the top of the table of titles reads "Selected records: ..." Sponsored-by: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Severity|minor |enhancement --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Passing QA, moving to enh. Please tell me if I am mistaken :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 --- Comment #8 from Mathieu Saby <mathsabypro@gmail.com> --- Thank you everybody -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Owen, can you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170428|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170901&action=edit Bug 37177: "item" should be "record" in list page This patch rewords areas of the lists and cart templates so that the term "record" is preferred over "item" when referring to a bibliographic record. To test, apply the patch and go to Lists in the staff interface. - If necessary, create a new list. - From the list contents view, click "Add records" in the toolbar. - Submit some valid barcodes and biblionumbers - After adding biblionumbers you should see the message "The record ( [number] ) has been added to the list" - After adding barcodes you should see the message "The record for this item ( [barcode] ) has been added to the list" - Click "Add records" again - Submit some of the same barcodes and biblionumbers - You should see these messages: - "The record for this item ( [barcode] ) has not been added to the list. Please verify it is not already in the list." - "The record ( [number] ) has not been added to the list. Please verify it is not already in the list. - Check the checkbox for one or more titles on your list and click "Remove selected" - You should see the message, "The record has been removed from the list." - Perform a catalog search and from the results screen, select one or more results and add them to the cart. - Open the Cart and confirm that the controls at the top of the table of titles reads "Selected records: ..." Sponsored-by: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch corrects some release notes| |areas in the lists and | |carts so that the term | |'record' is used instead of | |'item' when referring to a | |bibliographic record. Keywords|release-notes-needed | CC| |philip.orr@lmscloud.de --- Comment #12 from Philip Orr <philip.orr@lmscloud.de> --- Added release notes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37177 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org