[Bug 19300] New: Move C4::Reserves:: OPACItemHoldsAllowed to the code namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Bug ID: 19300 Summary: Move C4::Reserves::OPACItemHoldsAllowed to the code namespace Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 [Bug 17728] Move C4::Reserves code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67119&action=edit Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed - tests This patch proves that we will not introduce trivial regression. With the same tests, we will execute the existing code and the new code. Test plan: With only this patch applied, prove t/db_dependent/Koha/IssuingRules.t should return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67120&action=edit Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed This patchset move The OPACItemHoldsAllowed logic (issuingrules.opacitemholds) to a new class method of Koha::IssuingRules: get_opacitemholds_policy On the way, this patch will certainly fix the same problem as bug 19298 with onshelfholds. Test plan: Make sure the opacitemholds policy is correct when placing a hold at the OPAC or the staff interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67121&action=edit Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed - Remove the subroutine At this point the subroutine is not longer in use, we can remove it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19302 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302 [Bug 19302] Pass objects to IsAvailableForItemLevelRequest -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19297 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19297 [Bug 19297] Standardize "can place hold" calculations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67119|0 |1 is obsolete| | --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 67388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67388&action=edit Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed - tests This patch proves that we will not introduce trivial regression. With the same tests, we will execute the existing code and the new code. Test plan: With only this patch applied, prove t/db_dependent/Koha/IssuingRules.t should return green Followed test plan, patches worked as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67120|0 |1 is obsolete| | --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 67389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67389&action=edit Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed This patchset move The OPACItemHoldsAllowed logic (issuingrules.opacitemholds) to a new class method of Koha::IssuingRules: get_opacitemholds_policy On the way, this patch will certainly fix the same problem as bug 19298 with onshelfholds. Test plan: Make sure the opacitemholds policy is correct when placing a hold at the OPAC or the staff interface. Followed test plan which worked as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67121|0 |1 is obsolete| | --- Comment #6 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 67390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67390&action=edit Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed - Remove the subroutine At this point the subroutine is not longer in use, we can remove it Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19301 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301 [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the code namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_17_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_17_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move |Move |C4::Reserves::OPACItemHolds |C4::Reserves::OPACItemHolds |Allowed to the code |Allowed to the Koha |namespace |namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here now too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- require C4::Reserves; Did I really see that ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67388|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 70101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70101&action=edit Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed - tests This patch proves that we will not introduce trivial regression. With the same tests, we will execute the existing code and the new code. Test plan: With only this patch applied, prove t/db_dependent/Koha/IssuingRules.t should return green Followed test plan, patches worked as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67389|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 70102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70102&action=edit Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed This patchset move The OPACItemHoldsAllowed logic (issuingrules.opacitemholds) to a new class method of Koha::IssuingRules: get_opacitemholds_policy On the way, this patch will certainly fix the same problem as bug 19298 with onshelfholds. Test plan: Make sure the opacitemholds policy is correct when placing a hold at the OPAC or the staff interface. Followed test plan which worked as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67390|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 70103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70103&action=edit Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed - Remove the subroutine At this point the subroutine is not longer in use, we can remove it Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #8)
require C4::Reserves; Did I really see that ?
It is removed in the next patch. The goal was to prove that the same tests were passing with the current code and the new code :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |nick@bywatersolutions.com Status|Pushed to Master |RESOLVED --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org