[Bug 11760] New: In notices, code of road type is used instead of descritpion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11760 Bug ID: 11760 Summary: In notices, code of road type is used instead of descritpion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: sophie.meynieux@biblibre.com QA Contact: testopia@bugs.koha-community.org In notices, <<borrowers.streettype>> is replaced by road type code rather than description With this patch, description is retrieved This patch needs http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7372 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11760 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Depends on| |7372 Assignee|koha-bugs@lists.koha-commun |sophie.meynieux@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11760 --- Comment #1 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 25254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25254&action=edit MT11760 : In notices, code of road type is used instead of description Test plan : - Define a notice containing <<borrowers.streettype>> - Trigger an event that generate this notice Without patch <<borrowers.streettype>> is replaced by ROADTYPE authorised value code. With the patch it is resplaced by its description This patch needs bug 7372 to be applied -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11760 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11760 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25254|0 |1 is obsolete| | --- Comment #2 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 25259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25259&action=edit MT11760 : In notices, code of road type is used instead of description Test plan : - Define a notice containing <<borrowers.streettype>> - Trigger an event that generate this notice Without patch <<borrowers.streettype>> is replaced by ROADTYPE authorised value code. With the patch it is resplaced by its description This patch needs bug 7372 to be applied -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11760 --- Comment #3 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- On Jonathan's advice, I change the patch to be more restrictive on <<borrowers.streettype>> substitution. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11760 --- Comment #4 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 25302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25302&action=edit Bug 11760 : In notices, code of road type is used instead of description Test plan : - Define a notice containing <<borrowers.streettype>> - Trigger an event that generate this notice Without patch <<borrowers.streettype>> is replaced by ROADTYPE authorised value code. With the patch it is resplaced by its description This patch needs bug 7372 to be applied -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11760 --- Comment #5 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Typo in bug naming -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11760 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25259|0 |1 is obsolete| | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11760 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11760 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25302|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25735&action=edit Bug 11760 : In notices, code of road type is used instead of description Test plan : - Define a notice containing <<borrowers.streettype>> - Trigger an event that generate this notice Without patch <<borrowers.streettype>> is replaced by ROADTYPE authorised value code. With the patch it is resplaced by its description This patch needs bug 7372 to be applied Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25735|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26202&action=edit [PASSED QA] Bug 11760 : In notices, code of road type is used instead of description Test plan : - Define a notice containing <<borrowers.streettype>> - Trigger an event that generate this notice Without patch <<borrowers.streettype>> is replaced by ROADTYPE authorised value code. With the patch it is resplaced by its description This patch needs bug 7372 to be applied Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This works as described, passes tests and QA script. Note: it seems it's not possible currently to use B_streettype from the interface, but it might be worth adding it as a follow up for later use. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11760 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Sophie! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11760 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org