[Bug 11094] New: Bootstrap theme: typo loaction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094 Bug ID: 11094 Summary: Bootstrap theme: typo loaction Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: bgkriegel@gmail.com QA Contact: testopia@bugs.koha-community.org Small typo on opac-user.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 22166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22166&action=edit Bug 11094 - Bootstrap theme: typo loaction This patch fixes a typo on opac-user.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094 William <wcarlin@washoecounty.us> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |wcarlin@washoecounty.us --- Comment #2 from William <wcarlin@washoecounty.us> --- Please add a detailed commit message with a test plan. we are new patch testers and this would help us out. Thank you. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094 --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to William from comment #2)
Please add a detailed commit message with a test plan. we are new patch testers and this would help us out. Thank you.
You are right :) I'll try to find the exact situation in which this typo surfaces (found it doing translation) and then I'll resubmit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |liz@catalyst.net.nz --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- To test: This text is explicitly, as far as I can tell, for screen readers. Therefore, the way to test this is to inspect the source of the generated page and make sure that the text in the <span class="tdlabel"> for Pick up location shows the correct spelling of location. It's not a commit message, but I hope this test plan helps you test. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22166|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25106&action=edit [SIGNED-OFF] Bug 11094 - Bootstrap theme: typo loaction This patch fixes a typo on opac-user.tt To test you must have existing holds on your account. Log into the OPAC and view the holds tab on the "your summary" page (opac-user.pl). Resize the browser window until the table switches from a regular table layout to a vertical column. Only when the view is narrow enough does the affected label appear: Pick up location: [library name] Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25106|0 |1 is obsolete| | --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25120&action=edit Bug 11094 - Bootstrap theme: typo loaction This patch fixes a typo on opac-user.tt To test you must have existing holds on your account. Log into the OPAC and view the holds tab on the "your summary" page (opac-user.pl). Resize the browser window until the table switches from a regular table layout to a vertical column. Only when the view is narrow enough does the affected label appear: Pick up location: [library name] Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org