[Bug 20180] New: Remove GROUP BY clause in manage-marc-import.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Bug ID: 20180 Summary: Remove GROUP BY clause in manage-marc-import.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: julian.maurice@biblibre.com QA Contact: julian.maurice@biblibre.com Blocks: 17258 This bug is a continuation of bug 20144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71472&action=edit Bug 20180: [sql_modes] Remove GROUP BY clause in manage-marc-import.pl Fix for: 'koha_kohadev.me.frameworktext' isn't in GROUP BY t/db_dependent/www/search_utf8.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- The GROUP BY is needed here, otherwise you have the same MARC framework displayed multiple times in the dropdown list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71472|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71625&action=edit Bug 20180: [sql_modes] Remove GROUP BY clause in manage-marc-import.pl Replaced with a distinct. Fix for: 'koha_kohadev.me.frameworktext' isn't in GROUP BY t/db_dependent/www/search_utf8.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 71625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71625 Bug 20180: [sql_modes] Remove GROUP BY clause in manage-marc-import.pl Review of attachment 71625: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20180&attachment=71625) ----------------------------------------------------------------- ::: tools/manage-marc-import.pl @@ +62,4 @@
our $sessionID = $cookies{'CGISESSID'}->value; our $dbh = C4::Context->dbh;
+my $frameworks = Koha::BiblioFrameworks->search({ tagfield => { 'not' => undef } }, { join => 'marc_tag_structure', distinct => 'frameworkcode', order_by => ['frameworktext'] });
Ah! You need the join to confirm there are actually fields to be used for importing. Otherwise, you do lots of work to import nothing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71625|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73130&action=edit Bug 20180: [sql_modes] Remove GROUP BY clause in manage-marc-import.pl Replaced with a distinct. Fix for: 'koha_kohadev.me.frameworktext' isn't in GROUP BY t/db_dependent/www/search_utf8.t NOTE: I added a [% frameworks.count %] into the template file, and compared master and a branch with this applied when managing a staged marc import. Values were identical. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 [Bug 20521] dev installations should run with problematic SQL modes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73130|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 73860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73860&action=edit Bug 20180: [sql_modes] Remove GROUP BY clause in manage-marc-import.pl Replaced with a distinct. Fix for: 'koha_kohadev.me.frameworktext' isn't in GROUP BY t/db_dependent/www/search_utf8.t NOTE: I added a [% frameworks.count %] into the template file, and compared master and a branch with this applied when managing a staged marc import. Values were identical. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org