[Bug 8986] New: Batch patron modification template corrections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 Priority: P5 - low Change sponsored?: --- Bug ID: 8986 Assignee: oleonard@myacpl.org Summary: Batch patron modification template corrections Severity: normal Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Templates Product: Koha The batch patron modification template has lots of minor errors which need to be corrected: incorrect case, incorrect terminology, copy and paste errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8980 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13116&action=edit Bug 8986 - Batch patron modification template corrections Many minor template changes: - Correcting title and headings - Adding translation to string in JavaScript - Tweaking table sorter - Wrapping card number in link to patron detail page - Adding standard styles to "clear" links (see patron attributes) - Terminiology corrections (borrower-> patron, cardnumber -> card number) - Capitalization corrections - Make labels clickable -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Note to testers: Depends on the patch for Bug 8980. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13116|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Comment on attachment 13116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13116 Bug 8986 - Batch patron modification template corrections Whoops--something in my patch has created a bug in cloning patron attributes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13175&action=edit Bug 8986 [Revised] Batch patron modification template corrections Many minor template changes: - Correcting title and headings - Adding translation to string in JavaScript - Tweaking table sorter - Wrapping card number in link to patron detail page - Adding standard styles to "clear" links (see patron attributes) - Terminiology corrections (borrower-> patron, cardnumber -> card number) - Capitalization corrections - Improve display of extended attributes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_12 --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- String changes. Will hold for post-3.10.0. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia@bywatersolutions.com --- Comment #6 from Melia Meggs <melia@bywatersolutions.com> --- This looks much prettier! Things are properly aligned and spelled and capitalized correctly. Card number link to patron details page works. Table sorter works. I made two batch patron modifications, and everything worked as expected. I think this is an improvement, so I am adding my sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13175|0 |1 is obsolete| | --- Comment #7 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 13320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13320&action=edit [Signed off] Bug 8986 [Revised] Batch patron modification template corrections Many minor template changes: - Correcting title and headings - Adding translation to string in JavaScript - Tweaking table sorter - Wrapping card number in link to patron detail page - Adding standard styles to "clear" links (see patron attributes) - Terminiology corrections (borrower-> patron, cardnumber -> card number) - Capitalization corrections - Improve display of extended attributes Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13531&action=edit Bug 8986: Followup FIX a JS error if there is no valid card number -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |jonathan.druart@biblibre.co | |m --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: Thanks Owen for this patch! I proposed a followup: if no card number is valid, a javascript error is raised. The patch hides the table and some javascript functions if the table is empty. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13531|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13533&action=edit Bug 8986: Followup FIX a JS error if there is no valid card number Signed-off-by: Owen Leonard <oleonard@myacpl.org> I can't reproduce the JS error but the template changes are correct with regard to how the page should handle errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch fixes some minors template errors in tools/modborrowers.tt Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- *** Bug 8960 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 Bug 8986 depends on bug 8980, which changed state. Bug 8980 Summary: Untranslatable strings in modborrowers.pl http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8980 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #13 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz Version|3.12 |3.10 --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8986 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11245 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org