[Bug 10617] New: Init script cleanup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617 Bug ID: 10617 Summary: Init script cleanup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz The debian/koha-common.init file needs some cleanup. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 19811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19811&action=edit Bug 10617 - koha-common tnit script cleanup Removed unused stuff, added a new config file /etc/default/koha-common to control the init script behaviour. Currently is only a stub. The config file could be put on /etc/sysconfig on RedHat and friends. The init script should work them too. To test: - Apply the patch on master, build your own packages and install. - The init script should continue to work as expected. (it can be tested replacing the /etc/init.d/koha-common file with debian/koha-common.init on a packages install). - The absence of the /etc/default/koha-common file should not prevent the init script from working. Regards To+ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19811|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 19851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19851&action=edit Bug 10617 - koha-common init script cleanup Removed unused stuff, added a new config file /etc/default/koha-common to control the init script behaviour. Currently is only a stub. The config file could be put on /etc/sysconfig on RedHat and friends. The init script should work them too. Added a TODO comment regarding the 'status' switch. To test: - Apply the patch on master, build your own packages and install. - The init script should continue to work as expected. (it can be tested replacing the /etc/init.d/koha-common file with debian/koha-common.init on a packages install). - The absence of the /etc/default/koha-common file should not prevent the init script from working. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10624 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617 --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> --- I don't think we need to have PERL5LIB defined in the config for this. It shouldn't break anything though. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19851|0 |1 is obsolete| | --- Comment #4 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 21218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21218&action=edit Bug 10617 - koha-common init script cleanup Removed unused stuff, added a new config file /etc/default/koha-common to control the init script behaviour. Currently is only a stub. The config file could be put on /etc/sysconfig on RedHat and friends. The init script should work them too. Added a TODO comment regarding the 'status' switch. To test: - Apply the patch on master, build your own packages and install. - The init script should continue to work as expected. (it can be tested replacing the /etc/init.d/koha-common file with debian/koha-common.init on a packages install). - The absence of the /etc/default/koha-common file should not prevent the init script from working. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Robin Sheat <robin@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Tomás! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.7. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org