[Bug 19706] New: Item search: Unsupported format html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 Bug ID: 19706 Summary: Item search: Unsupported format html Change sponsored?: --- Product: Koha Version: 17.05 Hardware: PC OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: elias.dehler@thulb.uni-jena.de QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl After upgrading to 17.05.06.000 Item search no longer works, as long as screen is selected. CSV and Barcodes file working as intended. When screen is the selected output you get the following software error: Unsupported format html at /usr/share/koha/intranet/cgi-bin/catalogue/itemsearch.pl line 41. Steps to reproduce: 1. upgrade to 17.05.06.000 2. in the intra: search -> item search 3. leave everything as it is and click search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 Elias <elias.dehler@thulb.uni-jena.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not recreate, the format must be "json", unless you have javascript disabled. Can you confirm you did not disable javascript? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- OS|Linux |All Version|17.05 |master Hardware|PC |All Severity|critical |major Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |nick@bywatersolutions.com Priority|P1 - high |P3 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- This appears to be an issue if there are no CCODE values defined. The column limiting code is malformed and javascript error breaks functionality. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 69729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69729&action=edit Bug 19706 - Fix bad json formed when there are no CCODE values To test: 1 - Delete all ccode values in your system 2 - Load the item search page 3 - View the console and note a js error 4 - Try to perform an item search to screen 5 - Internal server error ("unsupported format 'html'" in logs) 6 - Apply patch 7 - Reload page 8 - Note js error is gone 9 - Perform search to screen, success! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69729|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69745&action=edit Bug 19706: Fix bad json formed when there are no CCODE values To test: 1 - Delete all ccode values in your system 2 - Load the item search page 3 - View the console and note a js error 4 - Try to perform an item search to screen 5 - Internal server error ("unsupported format 'html'" in logs) 6 - Apply patch 7 - Reload page 8 - Note js error is gone 9 - Perform search to screen, success! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 69745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69745 Bug 19706: Fix bad json formed when there are no CCODE values Review of attachment 69745: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19706&attachment=69745) ----------------------------------------------------------------- Sorry, does not work, if you have defined some values in CCODE category, the select is not visible either ::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt @@ +363,4 @@
{ 'type': 'text' }, { 'type': 'text' }, { 'type': 'text' }, + [% IF ccode.size %]
should be ccodes.size (plural) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 69800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69800&action=edit Bug 19706: (followup) - correct variable name 'ccodes' not 'ccode' To test: 1 - Have some values in CCODE authorised values 2 - Ensure collection drop down on item search displays correctly 3 - Ensure item search returns results ot screen with no js errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69745|0 |1 is obsolete| | --- Comment #7 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 69831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69831&action=edit Bug 19706: Fix bad json formed when there are no CCODE values To test: 1 - Delete all ccode values in your system 2 - Load the item search page 3 - View the console and note a js error 4 - Try to perform an item search to screen 5 - Internal server error ("unsupported format 'html'" in logs) 6 - Apply patch 7 - Reload page 8 - Note js error is gone 9 - Perform search to screen, success! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69800|0 |1 is obsolete| | --- Comment #8 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 69832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69832&action=edit Bug 19706: (followup) - correct variable name 'ccodes' not 'ccode' To test: 1 - Have some values in CCODE authorised values 2 - Ensure collection drop down on item search displays correctly 3 - Ensure item search returns results ot screen with no js errors Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69831|0 |1 is obsolete| | Attachment #69832|0 |1 is obsolete| | --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69835&action=edit Bug 19706: Fix bad json formed when there are no CCODE values To test: 1 - Delete all ccode values in your system 2 - Load the item search page 3 - View the console and note a js error 4 - Try to perform an item search to screen 5 - Internal server error ("unsupported format 'html'" in logs) 6 - Apply patch 7 - Reload page 8 - Note js error is gone 9 - Perform search to screen, success! To test there is no regression: 1 - Have some values in CCODE authorised values 2 - Ensure collection drop down on item search displays correctly 3 - Ensure item search returns results ot screen with no js errors Signed-off-by Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 --- Comment #10 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69836&action=edit Bug 19706: (QA follow-up) Hide the collection code selector if no value is defined (for consistency) Test plan: 0) Go to item search 1) Do have some authorized values in CCODE category -> selector of collection is visible 2) Don't have any authorized value in CCODE category -> selector of collection is not visible Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- I squashed the two patches to simplify history and added follow-up to make the item search form behave consistant - if there is no ccode value, the selector for collection is not visible on item search form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18047 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org