[Bug 41237] New: OPAC created requests ignore library selection, always default to patron's library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Bug ID: 41237 Summary: OPAC created requests ignore library selection, always default to patron's library Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com, pedro.amorim@openfifth.co.uk, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s.graham4@herts.ac.uk Depends on| |35151 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- I believe this regression was introduced by bug 35151, by setting the $params->{branchcode} to the patron's branchcode, overwriting the form selection. The intent of that code was so that the patron's branchcode would then be used as a search parameter for the respective's library ILLModuleCopyrightClearance additional contents, but caused this unintended side effect. To reproduce: 1) Enable ILLModule 2) Logged in as koha:koha, create an OPAC request, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 3) Pick any library not Centerville (the default library of the 'koha' user) 4) Notice the created request's library is CPL (Centerville). It ignored the library selection from the form. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35151 [Bug 35151] Convert ILLModuleCopyrightClearance system preference to additional contents -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189491&action=edit Bug 41237: Update fetch of patron's branchcode to search additional_contents by -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189492&action=edit Bug 41237: Add tests Test plan, k-t-d: 1) Apply tests patch, run: prove t/db_dependent/Koha/ILL/Requests.t 2) Notice it fails. Apply the second patch. Repeat. Notice it passes. Test failure explanation (before fix patch): # Failed test 'Cardnumber not supplied and couldnt find additional_contents for all libraries. Dont show copyrightclearance' # at t/db_dependent/Koha/ILL/Requests.t line 1067. # got: 'copyrightclearance' # expected: 'commit' Its searching the copyrightclearance additional_contents for the provided branchcode param (illrq->patron->branchcode) (and finding one) when it shouldn't. That parameter is only to be utilized for the newly created ILL request's library. The branchcode filter of the additional_contents must the be logged in user's cardnumber, not params->{branchcode}. If no logged in user exists and this stage is reached (ILLOpacUnauthenticatedRequest), then only 'All libraries' ILLModuleCopyrightClearance are to be fetched, as expected. Human test plan, before applying patches: 1) Enable ILLModule 2) Logged in as koha:koha, create an OPAC request, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 3) Pick any library not Centerville (the default library of the 'koha' user) 4) Notice the created request's library is CPL (Centerville). It ignored the library selection from the form. 5) Apply patches. Repeat. Notice the request's library is now the one that was selected on the form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |martin.renvoize@openfifth.c | |o.uk, oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189491|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189493&action=edit Bug 41237: Update fetch of patron's branchcode to search additional_contents by Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189492|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189494&action=edit Bug 41237: Add tests Test plan, k-t-d: 1) Apply tests patch, run: prove t/db_dependent/Koha/ILL/Requests.t 2) Notice it fails. Apply the second patch. Repeat. Notice it passes. Test failure explanation (before fix patch): # Failed test 'Cardnumber not supplied and couldnt find additional_contents for all libraries. Dont show copyrightclearance' # at t/db_dependent/Koha/ILL/Requests.t line 1067. # got: 'copyrightclearance' # expected: 'commit' Its searching the copyrightclearance additional_contents for the provided branchcode param (illrq->patron->branchcode) (and finding one) when it shouldn't. That parameter is only to be utilized for the newly created ILL request's library. The branchcode filter of the additional_contents must the be logged in user's cardnumber, not params->{branchcode}. If no logged in user exists and this stage is reached (ILLOpacUnauthenticatedRequest), then only 'All libraries' ILLModuleCopyrightClearance are to be fetched, as expected. Human test plan, before applying patches: 1) Enable ILLModule 2) Logged in as koha:koha, create an OPAC request, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 3) Pick any library not Centerville (the default library of the 'koha' user) 4) Notice the created request's library is CPL (Centerville). It ignored the library selection from the form. 5) Apply patches. Repeat. Notice the request's library is now the one that was selected on the form. Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 --- Comment #6 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189514&action=edit [24.11.x] Bug 41237: Update fetch of patron's branchcode to search additional_contents by Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Somehow this change is confusing. Shouldnt we just check if we had a value in $params->{branchcode} instead of looking up a patron while we could simply pass him from the script. If there was no value in $params->{branchcode}, you should not look for undef. So - library_id => $params->{branchcode}, This should be something like + $params->{branchcode} ? ( library_id => $params->{branchcode} ) : (), Am I missing something? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #8 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Marcel de Rooy from comment #7)
Somehow this change is confusing. Shouldnt we just check if we had a value in $params->{branchcode} instead of looking up a patron while we could simply pass him from the script.
If there was no value in $params->{branchcode}, you should not look for undef. So - library_id => $params->{branchcode}, This should be something like + $params->{branchcode} ? ( library_id => $params->{branchcode} ) : (),
Am I missing something?
Thanks for looking Marcel. I don't believe so as the correct ILLModuleCopyrightClearance AdditionalContents should be retrieved based on the patron's library, not the library selected from the form itself. What I think should happen (and is happening with this patchset): 1) Patron from library A visits the ILL request form to create a new request at: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 2) Patron is presented the ILLModuleCopyrightClearance created for their library (if any) 3) If 2 is empty, patron is presented ILLModuleCopyrightClearance created for 'All libraries' (if any) [this is where search for undef is working as intended] 4) If no ILLModuleCopyrightClearance retrieved from 2 or 3, skip it entirely and show form instead. 5) Patron is presented the form, they pick destination library B. Library B is correctly set to that ILL request's library. This is my interpretation of the issue, apologies in advance if I misunderstood your comment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- OLD If you had $patron, pass branchcode and cardnumber [WITHOUT using it btw] to backend_create. In that sub always look for AddCont on library_id => $params->{branchcode} so patron branch OR undefined (all libs). NEW Pass cardnumber but do NO LONGER pass branchcode. ONLY look for AddCont with library_id if you got patron->branchcode via cardnumber. So you never look at library_id undefined (all libs); instead you accept copyright clearance from any branch when there is no patron. QA COMMENT It seems odd to look up cardnumber in create_backend if you can pass $patron from the caller. Although I am not familiar with this workflow, the algorithm does not feel good. Yeah I could be mistaken too :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 --- Comment #10 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 190990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190990&action=edit Bug 41237: (QA follow-up): Utilize available logged in user object Instead of re-fetching the patron object. This also adjusts tests: prove t/db_dependent/Koha/ILL/Requests.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189514|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #11 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Marcel de Rooy from comment #9)
OLD If you had $patron, pass branchcode and cardnumber [WITHOUT using it btw] to backend_create.
backend_create does not use it directly, but delegates it to the specific backend being utilized: my $args = { request => $self, other => $params, }; my $result = $self->_backend->create($args); The backend itself will then make use of it. Take a look at Koha/ILL/Backend/Standard::create for example, which then calls add_request that then does use it to effectively insert the request in the database.
In that sub always look for AddCont on library_id => $params->{branchcode} so patron branch OR undefined (all libs).
This is correct, and highlights the problem exactly. It worked as intended for that purpose, but had the side-effect of overwriting the existing $params->{branchcode} which is the branchcode that is selected on the form and may or may not be the logged in patron's branchcode.
NEW Pass cardnumber but do NO LONGER pass branchcode.
branchcode is still passed, as was before. It's in $params->{branchcode}, but now is the one submitted in the form by the user, not being overwritten.
ONLY look for AddCont with library_id if you got patron->branchcode via cardnumber. So you never look at library_id undefined (all libs); instead you accept copyright clearance from any branch when there is no patron.
I understand that the code reads as such, but the way AdditionalContents->search_for_display works is that it sets the search on library_id = undef if the parameter is omited. I believe this behavior was introduced in bug 29332. Additionally, this potential regression would be caught by the tests written in this patchset, one way to prove it is by reverting the change from bug 29332 and running t/db_dependent/Koha/ILL/Requests.t (with patches applied - QA followup). It'll cause the tests to fail.
QA COMMENT It seems odd to look up cardnumber in create_backend if you can pass $patron from the caller.
Agreed, follow-up patch submitted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hi! Still on my list. Coming back soon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189493|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 191691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191691&action=edit Bug 41237: Update fetch of patron's branchcode to search additional_contents by Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189494|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 191692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191692&action=edit Bug 41237: Add tests Test plan, k-t-d: 1) Apply tests patch, run: prove t/db_dependent/Koha/ILL/Requests.t 2) Notice it fails. Apply the second patch. Repeat. Notice it passes. Test failure explanation (before fix patch): # Failed test 'Cardnumber not supplied and couldnt find additional_contents for all libraries. Dont show copyrightclearance' # at t/db_dependent/Koha/ILL/Requests.t line 1067. # got: 'copyrightclearance' # expected: 'commit' Its searching the copyrightclearance additional_contents for the provided branchcode param (illrq->patron->branchcode) (and finding one) when it shouldn't. That parameter is only to be utilized for the newly created ILL request's library. The branchcode filter of the additional_contents must the be logged in user's cardnumber, not params->{branchcode}. If no logged in user exists and this stage is reached (ILLOpacUnauthenticatedRequest), then only 'All libraries' ILLModuleCopyrightClearance are to be fetched, as expected. Human test plan, before applying patches: 1) Enable ILLModule 2) Logged in as koha:koha, create an OPAC request, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 3) Pick any library not Centerville (the default library of the 'koha' user) 4) Notice the created request's library is CPL (Centerville). It ignored the library selection from the form. 5) Apply patches. Repeat. Notice the request's library is now the one that was selected on the form. Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190990|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 191693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191693&action=edit Bug 41237: (QA follow-up): Utilize available logged in user object Instead of re-fetching the patron object. This also adjusts tests: prove t/db_dependent/Koha/ILL/Requests.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |lucas@bywatersolutions.com --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- please add release notes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a bug on the release notes| |OPAC create ILL request | |form which was always | |setting the library to the | |patron's library, ignoring | |the library selection made | |on the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 --- Comment #18 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_11_candidate | CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.02 |26.05.00,25.11.02,25.05.09 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 --- Comment #19 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 --- Comment #20 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Correction: This was pushed to 25.05.x based on 25.05.08 (not 25.05.07 as previously noted). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.02,25.05.09 |26.05.00,25.11.02,25.05.09, released in| |24.11.12 --- Comment #21 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.12 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.02,25.05.09, |26.05.00,25.11.02,25.05.09, released in|24.11.12 |24.11.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 --- Comment #22 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.14 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #23 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Depends on bug not in 22.11.x Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #24 from Aude Charillon <aude.charillon@openfifth.co.uk> --- No need for any updates to the Koha Manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org