https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Somehow this change is confusing. Shouldnt we just check if we had a value in $params->{branchcode} instead of looking up a patron while we could simply pass him from the script. If there was no value in $params->{branchcode}, you should not look for undef. So - library_id => $params->{branchcode}, This should be something like + $params->{branchcode} ? ( library_id => $params->{branchcode} ) : (), Am I missing something? -- You are receiving this mail because: You are watching all bug changes.