[Bug 7288] New: Invoice improvements - issn seach field and checkbox invoices.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Bug #: 7288 Summary: Invoice improvements - issn seach field and checkbox invoices.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: claire.hernandez@biblibre.com QAContact: ian.walls@bywatersolutions.com adds ISSN to ISBN/EAN search field and a checkbox "show only subscriptions" in invoices.pl page so librarian can retrieve subscriptions invoices. (BibLibre MT6534) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7163 Depends on| |6533 Change sponsored?|--- |Sponsored AssignedTo|henridamien@koha-fr.org |claire.hernandez@biblibre.c | |om -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Depends on| |5339 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Bug 7288 depends on bug 5339, which changed state. Bug 5339 Summary: Parcel closing in acq http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|claire.hernandez@biblibre.c |jonathan.druart@biblibre.co |om |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5343 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|6533 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13246&action=edit Bug 7288: Allow to display only subscriptions in the invoices table This patch adds a checkbox "Show only subscriptions" in the invoices table. If this checkbox is checked, a filter is added on the table in order to show only subscription invoices -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Invoice improvements - issn |Invoice improvements - Show |seach field and checkbox |only subscriptions |invoices.pl | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- The ISSN search field is already in master. This patch depends on Bug 5343 (DB field aqorders.subscriptionid). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gmcharlt@gmail.com --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Patch does not apply. Please rebase and resubmit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13246|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18537&action=edit Bug 7288: Allow to display only subscriptions in the invoices table This patch adds a checkbox "Show only subscriptions" in the invoices table. If this checkbox is checked, a filter is added on the table in order to show only subscription invoices -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2012-09-24 last check this| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2012-09-24 00:00:00 |2013-09-24 last check this| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi@cineca.it --- Comment #5 from Paola Rossi <paola.rossi@cineca.it> --- The patch doesn't apply cleanly against master. There is a merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt. So I don't sign off the match, and I pass it to "failed QA". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18537|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21996&action=edit Bug 7288: Allow to display only subscriptions in the invoices table This patch adds a checkbox "Show only subscriptions" in the invoices table. If this checkbox is checked, a filter is added on the table in order to show only subscription invoices -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 --- Comment #7 from Paola Rossi <paola.rossi@cineca.it> --- The applying (against master 031) of the patch is OK. I've created some invoices for subscriptions' orders and some invoices not. When the checkbox "Show only subscriptions" is not checked, the patch works well and all the invoices are shown in the invoices table. On the contrary, when the checkbox "Show only subscriptions" is checked, no invoice is shown in the invoices table. Is it OK? This is the part of the patch about selecting only subscription' invoices: resultst.fnFilter( "[0-9]+", 0, true ) Can I create the situation with "[0-9+]" and see the list of the subscriptions' invoices shown? Thanks. When I see an invoice (from column "Invoice no." of the invoices table) and the invoice is not a subscription' one, I see "Invoice details" with a following table full of dates ("Summary" "Publisher" etc). When I see an invoice (from column "Invoice no." of the invoices table) and the invoice is a subscription' one, I see "Invoice details" followed by "No orders yet". On the contrary the order is present in bd: it is listed by Orders-search' results table of Acquisitions, and is linked to the subscripted serial. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22048&action=edit Bug 7288: fix typo th/td -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #7) Paola, I cannot reproduce your problem but I found a typo in the patch. Could your retest please? The regex should match the subscription id in the first column of the table. Datatables uses it for filtering on subscriptions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Paola Rossi <paola.rossi@cineca.it> --- Rebasing invoices.tt is neeeded. Against master 3.13.00.032: Applying: Bug 7288: Allow to display only subscriptions in the invoices table Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt Auto-merging C4/Acquisition.pm Failed to merge in the changes. Patch failed at 0001 Bug 7288: Allow to display only subscriptions in the invoices table So I pass the patch to failed QA status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21996|0 |1 is obsolete| | Attachment #22048|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22473&action=edit Bug 7288: Allow to display only subscriptions in the invoices table -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22473|0 |1 is obsolete| | --- Comment #12 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 22516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22516&action=edit Invoice improvements - Show only subscriptions The subscription's invoice is linked to a subscription by adding an order from an already existent subscription. I sign off the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22516|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23815&action=edit [PASSED QA] Bug 7288: Allow to display only subscriptions in the invoices table This patch adds a checkbox "Show only subscriptions" in the invoices table. If this checkbox is checked, a filter is added on the table in order to show only subscription invoices Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> To test: - Test in a database with multiple existing invoices - Create an order from a subscription, close basket, receive - Test that the result table of the invoice search shows the new checkbox and that it works correctly Passes all tests and QA script. Also passes t/db_dependent/Acquisition.t and t/db_dependent/Acquisition/*. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- Comment on attachment 23815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23815 [PASSED QA] Bug 7288: Allow to display only subscriptions in the invoices table Review of attachment 23815: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7288&attachment=23815) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ +2504,4 @@
my $dbh = C4::Context->dbh; my $query = qq{ SELECT aqinvoices.*, aqbooksellers.name AS suppliername, + aqorders.subscriptionid,
This does not handle the case where a single invoice has more than one order with a subscription very well. In particular, only one subscription would (arbitrarily) be displayed. If the goal is to be able to link to all subscriptions on a given invoice, it's not sufficient to display just one. If the goal is more simply to just be able to filter the invoice search for invoices that have one or more subscriptions, then it would be better calculate a Boolean flag. Either way, as the patch stands now it is likely to cause confusion for libraries that have invoices that cover multiple subscriptions -- which is very, very common in the US, at least. Failing QA. When you resubmit, I would also appreciate if you wrote a unit test for the change in the core routine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26065&action=edit Bug 7288: Set a boolean if the invoice if linked to subscriptions If an invoice is linked to subscription, we need to set a boolean to true in order to filter them in the interface. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Galen Charlton from comment #14)
Failing QA. When you resubmit, I would also appreciate if you wrote a unit test for the change in the core routine.
It is quite difficult to provide good unit tests here. To test if an invoice is linked to subscription, we should create a subscription (so a budget, a frequency, etc.). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli@cineca.it --- Comment #17 from Zeno Tajoli <z.tajoli@cineca.it> --- Sorry Galen, do we need to write an extra unit test or the code is OK to be pushed in master ? Zeno Tajoli -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a follow-up that adds a direct unit test. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |fridolyn.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #19 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- I choose to not apply to 3.14.x so I set as resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org