[Bug 10859] New: Alert if a patron already has an issue for the same biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Bug ID: 10859 Summary: Alert if a patron already has an issue for the same biblio Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com This feature will a an alert if a patron already has an issue for the same biblio. The librarian can force the checkout anyway. It doesn't alert the librarian if the biblio is a subscription. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20954&action=edit Bug 10859: Alert if a borrower already has an issue for the same biblio The librarian can force the checkout anyway. It doesn't alert the librarian if the biblio is a subscription Test plan: 1. Create a biblio with at least 2 items 2. Checkout the first item for a borrower 3. Set syspref AllowMultipleIssuesOnABiblio to OFF. 4. Try to checkout the second item with the same borrower. A message should appear telling you that this borrower already borrowed an item from this biblio. If you have the permission 'force_checkout' You should also see two buttons to confirm (or not) the checkout 5. Click on 'No'. The checkout is not done 6. Repeat step 4 and click 'Yes', the checkout is done. 7. Return the second item. 8. Set syspref AllowMultipleIssuesOnABiblio to ON 9. Try to checkout the second item with the same borrower. This time the checkout is done without warnings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch Depends on| |10863 Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org --- Comment #2 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 10859: Alert if a borrower already has an issue for the same biblio Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10859: Alert if a borrower already has an issue for the same biblio The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to I'm just a bot from comment #2) Depend on bug 10863 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2013-09-29 last check this| | --- Comment #4 from I'm just a bot <gitbot@bugs.koha-community.org> --- This bug depends on 10863 which is in status Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot|2013-09-29 00:00:00 |2013-10-27 last check this| | --- Comment #5 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 10859: Alert if a borrower already has an issue for the same biblio Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10859: Alert if a borrower already has an issue for the same biblio The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- I rebased bug 10863, this one applies cleanly now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11201 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron@veron.ch --- Comment #7 from Marc Véron <veron@veron.ch> --- Would like to sign off, but does not apply. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20954|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25362&action=edit Bug 10859: Alert if a borrower already has an issue for the same biblio The librarian can force the checkout anyway. It doesn't alert the librarian if the biblio is a subscription Test plan: 1. Create a biblio with at least 2 items 2. Checkout the first item for a borrower 3. Set syspref AllowMultipleIssuesOnABiblio to OFF. 4. Try to checkout the second item with the same borrower. A message should appear telling you that this borrower already borrowed an item from this biblio. If you have the permission 'force_checkout' You should also see two buttons to confirm (or not) the checkout 5. Click on 'No'. The checkout is not done 6. Repeat step 4 and click 'Yes', the checkout is done. 7. Return the second item. 8. Set syspref AllowMultipleIssuesOnABiblio to ON 9. Try to checkout the second item with the same borrower. This time the checkout is done without warnings. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 --- Comment #9 from Marc Véron <veron@veron.ch> --- Created attachment 25366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25366&action=edit [Signed-off] Bug 10859: Alert if a borrower already has an issue for the same biblio The librarian can force the checkout anyway. It doesn't alert the librarian if the biblio is a subscription Test plan: 1. Create a biblio with at least 2 items 2. Checkout the first item for a borrower 3. Set syspref AllowMultipleIssuesOnABiblio to OFF. 4. Try to checkout the second item with the same borrower. A message should appear telling you that this borrower already borrowed an item from this biblio. If you have the permission 'force_checkout' You should also see two buttons to confirm (or not) the checkout 5. Click on 'No'. The checkout is not done 6. Repeat step 4 and click 'Yes', the checkout is done. 7. Return the second item. 8. Set syspref AllowMultipleIssuesOnABiblio to ON 9. Try to checkout the second item with the same borrower. This time the checkout is done without warnings. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25362|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 25366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25366 [Signed-off] Bug 10859: Alert if a borrower already has an issue for the same biblio Review of attachment 25366: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10859&attachment=25366) ----------------------------------------------------------------- Hi Julian, some notes from me - could you take a look please? ::: C4/Circulation.pm @@ +1051,5 @@
+ my $is_a_subscription = C4::Serials::CountSubscriptionFromBiblionumber($biblionumber); + unless ($is_a_subscription) { + my $issues = GetIssues( { + borrowernumber => $borrower->{borrowernumber}, + biblionumber => $biblionumber,
I like that it excludes items that belong to serials. Could we add this to the system preference description for documentation? ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref @@ +341,5 @@
+ - pref: AllowMultipleIssuesOnABiblio + choices: + yes: Allow + no: "Don't allow" + - patrons to check out multiple items from the same biblio.
Not a native speaker, but maybe: Allow/Don't allow patrons to check out multiple items from the same record, except for records with subscriptions. ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ +271,5 @@
[% END %] + +[% IF BIBLIO_ALREADY_ISSUED %] + <li> + Borrower has already an issue on another item from this biblio.
I think we prefer 'patron', 'check out' and 'record' in the interface, so maybe we could say: Patron has already checked out another item from this record. ::: t/db_dependent/Circulation/GetIssues.t @@ +97,5 @@
+ DelBranch($branchcode); + } +}; + +done_testing;
The tests are failing for me :( prove t/db_dependent/Circulation/GetIssues.t t/db_dependent/Circulation/GetIssues.t .. Undefined subroutine &main::GetIssues called at t/db_dependent/Circulation/GetIssues.t line 61. t/db_dependent/Circulation/GetIssues.t .. Dubious, test returned 255 (wstat 65280, 0xff00) No subtests run I also notice that you don't use the 'new rollback transactions trick'. I think if you added this to your tests, you could also avoid having to cleanup as the database in the ind. It will just go back to the state it was in before the tests were run. I think you can find an example in Reserves.t and also some other test files. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|julian.maurice@biblibre.com |jonathan.druart@biblibre.co | |m --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah, now I realize the bug is assigned to Julian, but the patch is from Jonathan... or I think it is. Changing the assignee for now, please change back if wrong. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26263&action=edit Bug 10859: wording -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26264&action=edit Bug 10859: GetIssues.t - Execute unit tests in a transaction -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26267&action=edit [PASSED QA] Bug 10859: Alert if a borrower already has an issue for the same biblio The librarian can force the checkout anyway. It doesn't alert the librarian if the biblio is a subscription Test plan: 1. Create a biblio with at least 2 items 2. Checkout the first item for a borrower 3. Set syspref AllowMultipleIssuesOnABiblio to OFF. 4. Try to checkout the second item with the same borrower. A message should appear telling you that this borrower already borrowed an item from this biblio. If you have the permission 'force_checkout' You should also see two buttons to confirm (or not) the checkout 5. Click on 'No'. The checkout is not done 6. Repeat step 4 and click 'Yes', the checkout is done. 7. Return the second item. 8. Set syspref AllowMultipleIssuesOnABiblio to ON 9. Try to checkout the second item with the same borrower. This time the checkout is done without warnings. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass, works well. Tested: * Permission to override * check out a second item from a record with subscriptions works * check out a second item from a 'normal' record is warned about, but can be done * No permission to override * subscription item: can be checked out * normal item: can't be checked out * Feature turned off * Check out never warns/blocks -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26268&action=edit [PASSED QA] Bug 10859: wording Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26269&action=edit [PASSED QA] Bug 10859: GetIssues.t - Execute unit tests in a transaction Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26270&action=edit Bug 10859: QA follow up: Fixing order in sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26264|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25366|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26263|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a follow-up that clarifies the logic in the case where the item to be checked out is already on loan to the patron. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |fridolyn.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #19 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- I choose to not apply to 3.14.x so I set as resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org