[Bug 32986] New: Add ability to generate custom slips for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Bug ID: 32986 Summary: Add ability to generate custom slips for patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Some libraries would like to be able to provide custom information to a patron, while still using traditional slips - we should be able to add custom slips for printing form a patron's account -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 146750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146750&action=edit Bug 32986: Add patron_slip module to letters and allow printing on members account This patch adds a new module to letters 'patron_slip' / Patrons toolbar (slip) This also combines some of the slip printing JS to make things more direct To test: 1 - Apply patch 2 - Confirm you can print slip, summary, quickslip, and checkin slip when viewing a patron's account 3 - Enable DisplayClearScreenButton syspref, and test that it works with both values 4 - Go to Tools->Notices and slips 5 - Define a new notice in the 'Patron toolbar (slip)' module 6 - Enter content like below in the 'Print' transport: Patron has [% borrower.holds.count %] holds List of holds: [% FOREACH hold IN borrower.holds %] =============================== Reserve id: [% hold.reserve_id %] Title [% hold.biblio.title %] [% END %] 7 - Go to patron scree 8 - Note new option under 'Print' 9 - Print the new slip and confirm it works (try with and without placing holds for patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |andrewfh@dubcolib.org --- Comment #2 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- I cleared a merge error to get this to apply. I'm not sure if the issues I ran into were due to me not clearing the error properly or if they're inherent to the patch. In my testing, with the patch applied, the checkin slip always gives an error of "no template defined" and the clear screen and print buttons aren't in the right place after enabling DisplayClearScreenButton. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146750|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148267&action=edit Bug 32986: Add patron_slip module to letters and allow printing on members account This patch adds a new module to letters 'patron_slip' / Patrons toolbar (slip) This also combines some of the slip printing JS to make things more direct To test: 1 - Apply patch 2 - Confirm you can print slip, summary, quickslip, and checkin slip when viewing a patron's account 3 - Enable DisplayClearScreenButton syspref, and test that it works with both values 4 - Go to Tools->Notices and slips 5 - Define a new notice in the 'Patron toolbar (slip)' module 6 - Enter content like below in the 'Print' transport: Patron has [% borrower.holds.count %] holds List of holds: [% FOREACH hold IN borrower.holds %] =============================== Reserve id: [% hold.reserve_id %] Title [% hold.biblio.title %] [% END %] 7 - Go to patron scree 8 - Note new option under 'Print' 9 - Print the new slip and confirm it works (try with and without placing holds for patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Andrew Fuerste-Henry from comment #2)
I cleared a merge error to get this to apply. I'm not sure if the issues I ran into were due to me not clearing the error properly or if they're inherent to the patch. In my testing, with the patch applied, the checkin slip always gives an error of "no template defined" and the clear screen and print buttons aren't in the right place after enabling DisplayClearScreenButton.
Thanks for clearing the merge error! These things are both still true. The Checkin slip always says "No template defined" and the printer icon for DisplayClearScreenButton has jumped to the left side of the checkout box. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148361&action=edit Bug 32986: (follow-up) Restore styling for print button To test: Apply yarn build COnfirm display of printer icon is restored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148267|0 |1 is obsolete| | Attachment #148361|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148374&action=edit Bug 32986: Add patron_slip module to letters and allow printing on members account This patch adds a new module to letters 'patron_slip' / Patrons toolbar (slip) This also combines some of the slip printing JS to make things more direct To test: 1 - Apply patch 2 - restart_all 3 - yarn build 4 - Confirm you can print slip, summary, quickslip, and checkin slip when viewing a patron's account 5 - Enable DisplayClearScreenButton syspref, and test that it works with both values 6 - Go to Tools->Notices and slips 7 - Define a new notice in the 'Patron toolbar (slip)' module 8 - Enter content like below in the 'Print' transport: Patron has [% borrower.holds.count %] holds List of holds: [% FOREACH hold IN borrower.holds %] =============================== Reserve id: [% hold.reserve_id %] Title [% hold.biblio.title %] [% END %] 9 - Go to patron scree 10 - Note new option under 'Print' 11 - Print the new slip and confirm it works (try with and without placing holds for patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148374|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 148376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148376&action=edit Bug 32986: Add patron_slip module to letters and allow printing on members account This patch adds a new module to letters 'patron_slip' / Patrons toolbar (slip) This also combines some of the slip printing JS to make things more direct To test: 1 - Apply patch 2 - restart_all 3 - yarn build 4 - Confirm you can print slip, summary, quickslip, and checkin slip when viewing a patron's account 5 - Enable DisplayClearScreenButton syspref, and test that it works with both values 6 - Go to Tools->Notices and slips 7 - Define a new notice in the 'Patron toolbar (slip)' module 8 - Enter content like below in the 'Print' transport: Patron has [% borrower.holds.count %] holds List of holds: [% FOREACH hold IN borrower.holds %] =============================== Reserve id: [% hold.reserve_id %] Title [% hold.biblio.title %] [% END %] 9 - Go to patron scree 10 - Note new option under 'Print' 11 - Print the new slip and confirm it works (try with and without placing holds for patron Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Starting here: 1) QA test tools: Ohoh! FAIL Koha/Template/Plugin/Notices.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss FAIL koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc FAIL filters missing_filter at line 36 ( <li><a class="printslip" data-code="[% notice.code %]" href="#">Print [% notice.name %] slip</a></li>) missing_filter at line 36 ( <li><a class="printslip" data-code="[% notice.code %]" href="#">Print [% notice.name %] slip</a></li>) FAIL forbidden patterns forbidden pattern: tab char (line 35) forbidden pattern: tab char (line 37) OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt FAIL forbidden patterns forbidden pattern: tab char (line 236) OK koha-tmpl/intranet-tmpl/prog/js/members-menu.js FAIL members/printslip.pl FAIL forbidden patterns forbidden pattern: tab char (line 101) forbidden pattern: tab char (line 102) forbidden pattern: tab char (line 103) forbidden pattern: tab char (line 104) forbidden pattern: tab char (line 105) forbidden pattern: tab char (line 106) Not finished with testing yet, but follow-ups welcome :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148376|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149506&action=edit Bug 32986: Add patron_slip module to letters and allow printing on members account This patch adds a new module to letters 'patron_slip' / Patrons toolbar (slip) This also combines some of the slip printing JS to make things more direct To test: 1 - Apply patch 2 - restart_all 3 - yarn build 4 - Confirm you can print slip, summary, quickslip, and checkin slip when viewing a patron's account 5 - Enable DisplayClearScreenButton syspref, and test that it works with both values 6 - Go to Tools->Notices and slips 7 - Define a new notice in the 'Patron toolbar (slip)' module 8 - Enter content like below in the 'Print' transport: Patron has [% borrower.holds.count %] holds List of holds: [% FOREACH hold IN borrower.holds %] =============================== Reserve id: [% hold.reserve_id %] Title [% hold.biblio.title %] [% END %] 9 - Go to patron scree 10 - Note new option under 'Print' 11 - Print the new slip and confirm it works (try with and without placing holds for patron Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149507&action=edit Bug 32986: (QA follow-up) Fix QA script complaints: tabs and TT filters * Perltidied the section with tabs in printslip.pl * Fixed indentation and tabs in letter.tt * Added missing TT filters to members-toolbar.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still not finished here, but I have fixed the QA script complaints :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Not sure whats going on, but clicking these Print buttons or options does actually do totally nothing.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #12)
Not sure whats going on, but clicking these Print buttons or options does actually do totally nothing..
All working for me, ensure you hard refresh the browser so that the JS reloads - I saw your issue before I did that -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Applying: Bug 32986: (QA follow-up) Fix QA script complaints: tabs and TT filters error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149506|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 153479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153479&action=edit Bug 32986: Add patron_slip module to letters and allow printing on members account This patch adds a new module to letters 'patron_slip' / Patrons toolbar (slip) This also combines some of the slip printing JS to make things more direct To test: 1 - Apply patch 2 - restart_all 3 - yarn build 4 - Confirm you can print slip, summary, quickslip, and checkin slip when viewing a patron's account 5 - Enable DisplayClearScreenButton syspref, and test that it works with both values 6 - Go to Tools->Notices and slips 7 - Define a new notice in the 'Patron toolbar (slip)' module 8 - Enter content like below in the 'Print' transport: Patron has [% borrower.holds.count %] holds List of holds: [% FOREACH hold IN borrower.holds %] =============================== Reserve id: [% hold.reserve_id %] Title [% hold.biblio.title %] [% END %] 9 - Go to patron scree 10 - Note new option under 'Print' 11 - Print the new slip and confirm it works (try with and without placing holds for patron Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149507|0 |1 is obsolete| | --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 153480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153480&action=edit Bug 32986: (QA follow-up) Fix QA script complaints: tabs and TT filters * Perltidied the section with tabs in printslip.pl * Fixed indentation and tabs in letter.tt * Added missing TT filters to members-toolbar.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 153481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153481&action=edit Bug 32986: (follow-up) Tidy conditional in letter.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 153482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153482&action=edit Bug 32986: (follow-up) POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Signed Off |Failed QA --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- 1. 25 use C4::Koha; 26 use C4::Context; in Koha/Template/Plugin/Notices.pm, there are not needed. 2. - [% CASE 'members' %]<span>Patrons</span> + [% CASE 'members' %]<span>Patrons</span> + [% CASE 'patron_slip' %]<span>Patrons toolbar (slip)</span> 3. You removed printx_window but we still have: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: return printx_window( '[% CircAutoPrintQuickSlip | html %]' ); 4. Not blocker - changes in tools/letter.pl were not needed. I can follow-up later this week but cannot right now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christofer.zorn@ajaxlibrary | |.ca --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 23041 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 21920 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156800&action=edit Bug 32986: (follow-up) Fix CircAutoPrintQuickSlip and remove unecessary module usage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #19)
1. 25 use C4::Koha; 26 use C4::Context;
in Koha/Template/Plugin/Notices.pm, there are not needed.
Fixed
2. - [% CASE 'members' %]<span>Patrons</span> + [% CASE 'members' %]<span>Patrons</span> + [% CASE 'patron_slip' %]<span>Patrons toolbar (slip)</span>
Already tidied in the patchset
3. You removed printx_window but we still have:
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: return printx_window( '[% CircAutoPrintQuickSlip | html %]' );
Fixed
4. Not blocker - changes in tools/letter.pl were not needed.
I add a condition in the first patch - tidied the whole block for consistency
I can follow-up later this week but cannot right now.
Thanks for looking! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153479|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158399&action=edit Bug 32986: Add patron_slip module to letters and allow printing on members account This patch adds a new module to letters 'patron_slip' / Patrons toolbar (slip) This also combines some of the slip printing JS to make things more direct To test: 1 - Apply patch 2 - restart_all 3 - yarn build 4 - Confirm you can print slip, summary, quickslip, and checkin slip when viewing a patron's account 5 - Enable DisplayClearScreenButton syspref, and test that it works with both values 6 - Go to Tools->Notices and slips 7 - Define a new notice in the 'Patron toolbar (slip)' module 8 - Enter content like below in the 'Print' transport: Patron has [% borrower.holds.count %] holds List of holds: [% FOREACH hold IN borrower.holds %] =============================== Reserve id: [% hold.reserve_id %] Title [% hold.biblio.title %] [% END %] 9 - Go to patron scree 10 - Note new option under 'Print' 11 - Print the new slip and confirm it works (try with and without placing holds for patron Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153480|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158400&action=edit Bug 32986: (QA follow-up) Fix QA script complaints: tabs and TT filters * Perltidied the section with tabs in printslip.pl * Fixed indentation and tabs in letter.tt * Added missing TT filters to members-toolbar.inc Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153481|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158401&action=edit Bug 32986: (follow-up) Tidy conditional in letter.pl Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153482|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158402&action=edit Bug 32986: (follow-up) POD Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156800|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158403&action=edit Bug 32986: (follow-up) Fix CircAutoPrintQuickSlip and remove unecessary module usage Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158404&action=edit Bug 32986: (QA follow-up) Rename notices module This renames the notices and slips module from Patrons toolbar (slip) to Patrons (custom slip) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158405&action=edit Bug 32986: (QA follow-up) Remove 'slip' from print dialog This makes it more flexible and the slip can be added to the notice name easily. For example: In German the slip would usually be part of the word, not separate: Gebührenquittung (slip = quittung) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this would make a great addition and is low risk, but: we need some unit tests for the new module. I am setting the keyword and adding my sign-off lines - please hurry. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158523&action=edit Bug 32986: (follow-up) Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #34 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff interface |Notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This feature makes it release notes| |possible to create custom | |slips that will appear in | |the 'Print' menu in the | |patron's user account in | |staff. For this purpose a | |new module was added to the | |pull down in the notices | |and slips tool: 'Patrons | |(custom slip)'. Keywords|rel_23_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/803 Status|Needs documenting |RESOLVED --- Comment #35 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- This is a very cool feature! Thanks everyone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27720 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36717 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36717 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36717 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36717 [Bug 36717] Merge "Patrons (custom slip)" and "Patrons (custom message)" in Notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36887 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36887 [Bug 36887] Migrate "Authorized Values (BOR_NOTES)" into "Patrons (custom message)" in Notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|36887 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36887 [Bug 36887] Migrate "Authorized Values (BOR_NOTES)" into "Patrons (custom message)" in Notices -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org