[Bug 21480] New: misc/translator/translate does not work with perl 5.26
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21480 Bug ID: 21480 Summary: misc/translator/translate does not work with perl 5.26 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs@lists.koha-community.org Reporter: olli-antti.kivilahti@helsinki.fi QA Contact: testopia@bugs.koha-community.org Perl 5.26 (or earlier) introduced a security feature, where implicitly including the program directory as a Perl library directory no longer happens (perl -I. ). This causes translate to fail because it cannot find the *.pm -files in it's own directory. This patch adds the familiar mantra use lib $FindBin::Bin; to the relevant scripts. To test: 1. Install Ubuntu18.04 or something else with Perl 5.26 2. Install Koha (we use the dev-install) 3. cd $KOHA_PATH/misc/trnaslator/ 4. perl translate create fi-FI 5. Observe problems with missing modules. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21480 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti@helsinki.fi> --- Tested with: 1. cd $KOHA_PATH/misc/translator/ 2. perl translate create fi-FI 3. perl translate update fi-FI 4. perl translate install fi-FI -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21480 --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti@helsinki.fi> --- Created attachment 79860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79860&action=edit 0001-Bug-21480-misc-translator-translate-does-not-work-wi.patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21480 Olli-Antti Kivilahti <olli-antti.kivilahti@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21480 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79860|0 |1 is obsolete| | --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 79861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79861&action=edit Bug 21480: misc/translator/translate does not work with perl 5.26 Perl 5.26 (or earlier) introduced a security feature, where implicitly including the program directory as a Perl library directory no longer happens (perl -I. ). This causes translate to fail because it cannot find the *.pm -files in it's own directory. This patch adds the familiar mantra use lib $FindBin::Bin; to the relevant scripts. To test: 1. Install Ubuntu18.04 or something else with Perl 5.26 2. Install Koha (we use the dev-install) 3. cd $KOHA_PATH/misc/translator/ 4. perl translate create fi-FI 5. Observe problems with missing modules. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21480 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice@biblibre.com --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Problem confirmed on Debian 9/Perl 5.24 The patch fixes the issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21480 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |olli-antti.kivilahti@helsin |ity.org |ki.fi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21480 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21480 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79861|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79901&action=edit Bug 21480: misc/translator/translate does not work with perl 5.26 Perl 5.26 (or earlier) introduced a security feature, where implicitly including the program directory as a Perl library directory no longer happens (perl -I. ). This causes translate to fail because it cannot find the *.pm -files in it's own directory. This patch adds the familiar mantra use lib $FindBin::Bin; to the relevant scripts. To test: 1. Install Ubuntu18.04 or something else with Perl 5.26 2. Install Koha (we use the dev-install) 3. cd $KOHA_PATH/misc/translator/ 4. perl translate create fi-FI 5. Observe problems with missing modules. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Cannot recreate the issue right now but the changes make sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21480 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Odd QA script failures here, not caused by this patch, ignoring but mentioning FAIL misc/translator/text-extract2.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Name "main::INPUT" used only once: possible typo FAIL misc/translator/tmpl_process3.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid main::mkdir_recursive() called too early to check prototype -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21480 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21480 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21480 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21480 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org