[Bug 41645] New: Make self-checkout use responsive CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 Bug ID: 41645 Summary: Make self-checkout use responsive CSS Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org Bug 20168 added the the directive '@import "responsive";' to the bottom of ./koha-tmpl/opac-tmpl/bootstrap/css/src/sco.scss, so we've had media queries and responsive CSS in the sco.css file for about 5 years now, but... they don't actually work. And it's because this one line of HTML is missing from koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt: <meta name="viewport" content="width=device-width, initial-scale=1"> Once that line is added, the CSS media queries start to work. Of course, there's a bit more that needs to be done on top of that. The input for the barcode is too narrow and misplaced, the Checkouts datatable runs off the page. But those are manageable problems. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- I had a librarian come to me wanting this to work on a phone, but it made me recall that I was sure that someone said at Kohacon25 in Wellington that they wanted the self checkout to be responsive so that roving librarians could use it on tablets... so this would be good for them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 191540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191540&action=edit Bug 41645: Make self-checkout use responsive CSS This change makes the responsive CSS work with self-checkout. This changes also includes a few minor HTML changes to make the display look good both on large and small screens. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 2. Log in as the koha user 3. Check out barcodes 39999000004571 and 39999000001310 4. In an incognito window, add holds and charges for the koha user 5. Go back to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl and log in as the koha user 6. Using your F12 dev tools, look at the interface with different widths 7. Note that the datatables have a responsive design which looks good on a mobile view 8. Note that the page stays contained to the small screen size and you don't have to scroll horizontally to see all the content -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41647 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41144 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191540|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 191544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191544&action=edit Bug 41645: Make self-checkout use responsive CSS This change makes the responsive CSS work with self-checkout. This changes also includes a few minor HTML changes to make the display look good both on large and small screens. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 2. Log in as the koha user 3. Check out barcodes 39999000004571 and 39999000001310 4. In an incognito window, add holds and charges for the koha user 5. Go back to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl and log in as the koha user 6. Using your F12 dev tools, look at the interface with different widths 7. Note that the datatables have a responsive design which looks good on a mobile view 8. Note that the page stays contained to the small screen size and you don't have to scroll horizontally to see all the content Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Have signed-off, but I didn't notice any horizontal scrolling required before the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com CC| |baptiste.wojtkowski@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191544|0 |1 is obsolete| | --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 193766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193766&action=edit Bug 41645: Make self-checkout use responsive CSS This change makes the responsive CSS work with self-checkout. This changes also includes a few minor HTML changes to make the display look good both on large and small screens. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 2. Log in as the koha user 3. Check out barcodes 39999000004571 and 39999000001310 4. In an incognito window, add holds and charges for the koha user 5. Go back to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl and log in as the koha user 6. Using your F12 dev tools, look at the interface with different widths 7. Note that the datatables have a responsive design which looks good on a mobile view 8. Note that the page stays contained to the small screen size and you don't have to scroll horizontally to see all the content Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This change fixes the self release notes| |check-out (SCO) so that it | |works with responsive CSS, | |which makes it more mobile | |friendly. This is | |especially useful when | |providing SCO on a tablet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Many thanks! It's fairly easy to backport by hand as well. I just did it for 24.11 locally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41645 --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org