[Bug 40006] New: Upgrading install.pl shows code vs HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 Bug ID: 40006 Summary: Upgrading install.pl shows code vs HTML Change sponsored?: --- Product: Koha Version: 25.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: ssammons@npelem.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 182806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182806&action=edit Screen segment of Chrome browser showing code vs HTML output When upgrading from version 23 (sorry I did it by accident, so I didn't not the subversion) after entering the credentials from the .xml file and proceeding to update the database, install.pl shows code above the HTML code, and I believe this breaks the HTML structure, viewing the page source it looked the same as the page, less in Chrome it puts line numbers on the left. Here is what appears about the HTML tags. 0E0 Status: 200 OK Set-Cookie: CGISESSID=af07240f027e658abfa81c3155df289f; path=/; HttpOnly; SameSite=Lax Date: Tue, 27 May 2025 19:03:47 GMT Cache-control: no-cache Content-script-type: text/javascript Content-style-type: text/css Pragma: no-cache X-frame-options: SAMEORIGIN Content-Type: text/html; charset=UTF-8 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Looks ok for me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 --- Comment #2 from Shane Sammons <ssammons@npelem.com> --- Created attachment 182814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182814&action=edit Revised screen showing its the browser NOT source code This is what I saw in the browser, it is code, not rendered HTML -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 --- Comment #3 from Shane Sammons <ssammons@npelem.com> --- Created attachment 182815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182815&action=edit Images of Chrome's View Source Here it is rendered the exact same way with view source as the HTML page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Hmm that's interesting. That suggests that two sets of HTTP headers were generated... with a 0E0 in between them it seems... It sounds like you have an atypical installation if you're getting to this screen. If you're not able to run the database update, you could just rollback the code anyway. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- I have seen this 0E0 happening in the output of our test suite https://jenkins.koha-community.org/job/Koha_Main/3317/consoleFull twice: 00:49:06 koha_1 | Upgrade to 21.05.00.000 [22:48:57]: Koha 21.05.00 release 00:49:06 koha_1 | 0E0 00:49:06 koha_1 | Upgrade to 21.06.00.000 [22:48:57]: Increase DBRev for 21.06 00:49:12 koha_1 | Upgrade to 25.06.00.006 [22:49:06]: Bug 37883 - Add system preference FilterSearchResultsByLoggedInBranch 00:49:12 koha_1 | Added new system preference 'FilterSearchResultsByLoggedInBranch' 00:49:12 koha_1 | Running [koha-mysql kohadev -e 'UPDATE systempreferences SET value="21.1100000" WHERE variable="version"']... 00:49:12 koha_1 | Running [sudo koha-shell kohadev -p -c 'perl /kohadevbox/koha/installer/data/mysql/updatedatabase.pl']... 00:49:12 koha_1 | Use of uninitialized value $biblio_adds_authorities in string eq at /kohadevbox/koha/installer/data/mysql/db_revs/220600047.pl line 12. 00:49:12 koha_1 | Use of uninitialized value $pref in string eq at /kohadevbox/koha/installer/data/mysql/db_revs/231200005.pl line 89. 00:49:12 koha_1 | 0E0 00:49:12 koha_1 | Upgrade to 21.12.00.000 [22:49:07]: Increase DBRev for 21.12 May come from (to confirm): installer/data/mysql/updatedatabase.pl 29463 unless ( $ENV{HTTP_HOST} ) { # Is that correct? 29464 my $files = get_db_entries; 29465 my $report = update( $files, { force => $force } ); 29466 29467 my $error_code = 0; 29468 for my $s ( @{ $report->{success} } ) { 29469 say Encode::encode_utf8( join "\n", @{ $s->{output} } ); 29470 } 29471 for my $e ( @{ $report->{error} } ) { 29472 say Encode::encode_utf8( join "\n", @{ $e->{output} } ); 29473 $error_code = 1; 29474 } 29475 29476 my $atomic_update_files = get_atomic_updates; 29477 $report = run_atomic_updates($atomic_update_files); 29478 for my $s ( @{ $report->{success} } ) { 29479 say Encode::encode_utf8( join "\n", @{ $s->{output} } ); 29480 } 29481 for my $e ( @{ $report->{error} } ) { 29482 say Encode::encode_utf8( join "\n", @{ $e->{output} } ); 29483 $error_code = 1; 29484 } 29485 exit $error_code; 29486 } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184587&action=edit Bug 40006: Remove dbh->do return value from updatedatabase output There are 2 occurrences of "0E0" in the test suite output. We should remove them. Test plan: root@kohadevbox:koha$ perl /kohadevbox/misc4dev/run_tests.pl --run-all-tests And confirm that the 0E0 does no longer appear You can abort when the update DB process is done -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|25.05 |unspecified Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184587|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 189483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189483&action=edit Bug 40006: Remove dbh->do return value from updatedatabase output There are 2 occurrences of "0E0" in the test suite output. We should remove them. Test plan: root@kohadevbox:koha$ perl /kohadevbox/misc4dev/run_tests.pl --run-all-tests And confirm that the 0E0 does no longer appear You can abort when the update DB process is done Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189483|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 190194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190194&action=edit Bug 40006: Remove dbh->do return value from updatedatabase output There are 2 occurrences of "0E0" in the test suite output. We should remove them. Test plan: root@kohadevbox:koha$ perl /kohadevbox/misc4dev/run_tests.pl --run-all-tests And confirm that the 0E0 does no longer appear You can abort when the update DB process is done Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38436 Text to go in the| |This fixes a database release notes| |update (for bug 38436 in | |24.11.00) that caused code | |to show in the browser | |instead of HTML output when | |running an upgrade. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara@openfifth.co.uk --- Comment #10 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 --- Comment #11 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38436 CC| |fridolin.somers@biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 [Bug 38436] Adjust code for column visibility (after DataTables upgrade) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #13 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org