[Bug 9063] New: When ordering from staged file '# Bibs' is empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Priority: P5 - low Change sponsored?: --- Bug ID: 9063 Assignee: koha-bugs@lists.koha-community.org Summary: When ordering from staged file '# Bibs' is empty Severity: normal Classification: Unclassified OS: All Reporter: katrin.fischer@bsz-bw.de Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha Created attachment 13409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13409&action=edit screenshot When ordering from a staged file in acquisitions, the column '# Bibs' in the table is empty for my staged file with 17 records. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7180 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is still an issue on current master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this problem is caused by renaming the database column from num_biblios to num_records when authority importing/matching was introduced. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 27132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27132&action=edit Bug 9063: When ordering from staged file '# Bibs' is empty Bug 2060 renames columns num_biblios with num_records in the import_batches table. The addorderiso2709 files had not been fixed. Test plan: Add an order from a staged file to a basket and verify the "# Bibs" columns is correctly filled. Before the patch, the column was empty. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Depends on| |7180 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Patch created on top of bug 7180. Feel free to provide a patch based on master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7180 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7180 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 27264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27264&action=edit [SIGNED-OFF] Bug 9063: When ordering from staged file '# Bibs' is empty Bug 2060 renames columns num_biblios with num_records in the import_batches table. The addorderiso2709 files had not been fixed. Test plan: Add an order from a staged file to a basket and verify the "# Bibs" columns is correctly filled. Before the patch, the column was empty. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27132|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27264|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27326&action=edit [PASSED QA] Bug 9063: When ordering from staged file '# Bibs' is empty Bug 2060 renames columns num_biblios with num_records in the import_batches table. The addorderiso2709 files had not been fixed. Test plan: Add an order from a staged file to a basket and verify the "# Bibs" columns is correctly filled. Before the patch, the column was empty. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- This patch does not apply. Since the dependency on 7180 is only textual, if Jonathan wants to rebase this one and put it back to passed QA after doing so, that's fine with me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- I happened to fix this bug already via one of my follow-ups for bug 7180. Sorry for forgetting about this one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 27957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27957&action=edit Bug 9063: When ordering from staged file '# Bibs' is empty Bug 2060 renames columns num_biblios with num_records in the import_batches table. The addorderiso2709 files had not been fixed. Test plan: Add an order from a staged file to a basket and verify the "# Bibs" columns is correctly filled. Before the patch, the column was empty. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Galen Charlton from comment #8)
I happened to fix this bug already via one of my follow-ups for bug 7180. Sorry for forgetting about this one.
Maybe this patch is still useful since it changes the variable name in the tt file too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org