[Bug 12185] New: Remove extra "f" from parcel.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185 Bug ID: 12185 Summary: Remove extra "f" from parcel.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: magnus@enger.priv.no Reporter: magnus@enger.priv.no QA Contact: testopia@bugs.koha-community.org Pasi Kallinen spotted this rather obvious typo in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt: [% IF ( loop_order.order_internalnote ) %] f<p class="ordernote"><strong>Internal note: </strong>[% loop_order.order_internalnote|html %] [<a href="/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=[% loop_order.ordernumber %]&referrer=/cgi-bin/koha/acqui/parcel.pl%3Finvoiceid=[% invoiceid %]&type=internal">Change internal note</a>]</p> [% ELSE %] The "f" before the "<p" should not be there. Patch coming in a sec. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185 --- Comment #1 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 27943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27943&action=edit Bug 12185 - Remove extra "f" from parcel.tt There is a typoed "f" outside of the HTML on line 279 of koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt This patch removes that extra "f". To test: It should be sufficient to look at line 279 before and after the patch has been applied. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27943|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27943|1 |0 is obsolete| | CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27943|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 27967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27967&action=edit Bug 12185 - Remove extra "f" from parcel.tt There is a typoed "f" outside of the HTML on line 279 of koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt This patch removes that extra "f". To test: It should be sufficient to look at line 279 before and after the patch has been applied. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- I added the signoff manually. It seems something went wrong on signing off from the sandbox. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- [OFF] the cronjob crashed: Warning: commit message does not conform to UTF-8. You may want to amend it after fixing the message, or set the config variable i18n.commitencoding to the encoding your project uses. Failed to attach patch to bug 12185, status=200 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27967|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 27968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27968&action=edit Bug 12185 - Remove extra "f" from parcel.tt There is a typoed "f" outside of the HTML on line 279 of koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt This patch removes that extra "f". To test: It should be sufficient to look at line 279 before and after the patch has been applied. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Magnus! (I know it's a string change, but since it's a tiny one, I'm pushing it now). -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org