[Bug 27749] New: Phase out jquery.cookie.js: Search to hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 Bug ID: 27749 Summary: Phase out jquery.cookie.js: Search to hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 23944 The "Search to hold" process uses a cookie to remember which patron the hold will be placed for. This process should use the newer cookie library, js-cookie. This patch will correct two similar instances: - In members-menu.js (search to hold for a patron) - In clubs.tt (search to hold for a club) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27750 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27750 [Bug 27750] Remove jquery.cookie.js plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117172&action=edit Bug 27749: Phase out jquery.cookie.js: Search to hold This patch modifies the "search to hold" process for patrons and clubs so that the newer jquery-cookie plugin is used instead of jquery.cookie. To test, apply the patch and locate a patron in the staff interface. - From the patron checkout or details page, click "Search to hold" in the toolbar." - Perform a catalog search which will return results. - On the search results page you should see a "Place hold for..." link with the correct patron information under each result. - In the toolbar above the search results you should see a "Place hold" button with a dropdown menu which also references the patron you selected. - Test that each option works to place a hold for your patron. - Test that the "Forget..." menu option works to remove "place hold for" options. - Test that your "Place hold for" option is also remembered on the bibliographic detail page. To test the changes to Patron Clubs: - If necessary, create a patron club: https://koha-community.org/manual/20.11/en/html/tools.html?highlight=club#pa... - Add one or more patrons to the club: https://koha-community.org/manual/20.11/en/html/tools.html?highlight=club#en... - From the patron clubs page, choose "Search to hold" from the club's "Actions" menu. - Perform the same tests above. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117172|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 117281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117281&action=edit Bug 27749: Phase out jquery.cookie.js: Search to hold This patch modifies the "search to hold" process for patrons and clubs so that the newer jquery-cookie plugin is used instead of jquery.cookie. To test, apply the patch and locate a patron in the staff interface. - From the patron checkout or details page, click "Search to hold" in the toolbar." - Perform a catalog search which will return results. - On the search results page you should see a "Place hold for..." link with the correct patron information under each result. - In the toolbar above the search results you should see a "Place hold" button with a dropdown menu which also references the patron you selected. - Test that each option works to place a hold for your patron. - Test that the "Forget..." menu option works to remove "place hold for" options. - Test that your "Place hold for" option is also remembered on the bibliographic detail page. To test the changes to Patron Clubs: - If necessary, create a patron club: https://koha-community.org/manual/20.11/en/html/tools.html?highlight=club#pa... - Add one or more patrons to the club: https://koha-community.org/manual/20.11/en/html/tools.html?highlight=club#en... - From the patron clubs page, choose "Search to hold" from the club's "Actions" menu. - Perform the same tests above. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Note that for the patron clubs, their is no 'Place to hold' options on the record detail screen - this was also the case in 20.11.x. Everything else works as per the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this might not work if you do a patron first and then a club, without "forgetting" in between. I am still stuck with the patron... But I can't verify, as I am also missing the "Forget" link in the pull down on the staff detail page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Failed QA |Signed Off --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #4)
I think this might not work if you do a patron first and then a club, without "forgetting" in between. I am still stuck with the patron... But I can't verify, as I am also missing the "Forget" link in the pull down on the staff detail page.
Can you detail what's wrong here, I am not sure I am following you. I do see the forget link and the test plan works as expected. Setting back to NQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #5)
(In reply to Katrin Fischer from comment #4)
I think this might not work if you do a patron first and then a club, without "forgetting" in between. I am still stuck with the patron... But I can't verify, as I am also missing the "Forget" link in the pull down on the staff detail page.
Can you detail what's wrong here, I am not sure I am following you. I do see the forget link and the test plan works as expected.
Setting back to NQA.
I didn't have any forget link visible. Where do you see it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- https://snipboard.io/3Iey1d.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28043 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28043 [Bug 28043] Some patron clubs operations don't work from later pages of results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28085 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #7)
It looks like we have the Forget on the result page, but not on the detail page. I filed bug 28085 for this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117281|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119164&action=edit Bug 27749: Phase out jquery.cookie.js: Search to hold This patch modifies the "search to hold" process for patrons and clubs so that the newer jquery-cookie plugin is used instead of jquery.cookie. To test, apply the patch and locate a patron in the staff interface. - From the patron checkout or details page, click "Search to hold" in the toolbar." - Perform a catalog search which will return results. - On the search results page you should see a "Place hold for..." link with the correct patron information under each result. - In the toolbar above the search results you should see a "Place hold" button with a dropdown menu which also references the patron you selected. - Test that each option works to place a hold for your patron. - Test that the "Forget..." menu option works to remove "place hold for" options. - Test that your "Place hold for" option is also remembered on the bibliographic detail page. To test the changes to Patron Clubs: - If necessary, create a patron club: https://koha-community.org/manual/20.11/en/html/tools.html?highlight=club#pa... - Add one or more patrons to the club: https://koha-community.org/manual/20.11/en/html/tools.html?highlight=club#en... - From the patron clubs page, choose "Search to hold" from the club's "Actions" menu. - Perform the same tests above. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch modifies the release notes| |"search to hold" process | |for patrons and clubs so | |that the newer | |jquery-cookie plugin is | |used instead of | |jquery.cookie. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749 Bug 27749 depends on bug 28043, which changed state. Bug 28043 Summary: Some patron clubs operations don't work from later pages of results https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28043 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org