[Bug 9106] New: Filtering list of uncertain price list by owner empties order information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9106 Bug ID: 9106 Summary: Filtering list of uncertain price list by owner empties order information Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/uncertainprice.pl OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org On the list of uncertain prices there is an option to show orders by "me" or "Everyone." Submitting this form appears to do nothing because the form action clears quantity and pricing information from the orders. When the page refreshes there are no results because the "uncertain" flag has been cleared along with other order info from *all* orders which have uncertain prices. In the template, the filter form includes the op=validate field which is the parameter that tells the script to perform the ModOrder operation. Removing that form field should correct the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9106 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9106 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9106 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13530&action=edit Bug 9106 - Filtering list of uncertain price list by owner empties order information The form which filters the list of orders with uncertain prices includes a parameter which tells the script to modify the orders, resulting in order information being lost. This patch removes the unnecessary form field. To test you must have orders with uncertain prices, preferably from more than one user. Go to the uncertain prices page. Before applying this patch, submitting the "orders from" form would cause the page to refresh with no results. This is because the script cleared the orders of price, quantity, etc. information. After applying this patch the uncertain prices list should refresh and show the correct results, either your orders ("me") or all ("Everyone"). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9106 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13530|0 |1 is obsolete| | --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13598&action=edit Bug 9106 - Filtering list of uncertain price list by owner empties order information The form which filters the list of orders with uncertain prices includes a parameter which tells the script to modify the orders, resulting in order information being lost. This patch removes the unnecessary form field. To test you must have orders with uncertain prices, preferably from more than one user. Go to the uncertain prices page. Before applying this patch, submitting the "orders from" form would cause the page to refresh with no results. This is because the script cleared the orders of price, quantity, etc. information. After applying this patch the uncertain prices list should refresh and show the correct results, either your orders ("me") or all ("Everyone"). Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9106 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- patch tested, fixes the nasty problem QA comment: just remove one line in the template, passed QA SO & QA in one go -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9106 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9106 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9106 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz Patch complexity|--- |Trivial patch --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x, will be in 3.10.1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9106 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.8 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org