[Bug 8614] New: Icon for scores on OPAC detail page broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8614 Priority: P5 - low Change sponsored?: --- Bug ID: 8614 Assignee: oleonard@myacpl.org Summary: Icon for scores on OPAC detail page broken Severity: enhancement Classification: Unclassified OS: All Reporter: katrin.fischer@bsz-bw.de Hardware: All Status: NEW Version: master Component: OPAC Product: Koha Created attachment 11520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11520&action=edit screenshot The icon for scores on the OPAC detail page is not displaying correctly, instead following text is shown: Type: materialTypeLabelScore In other cases the score icon shows up on the result list, but on the detail page the article icon or the book is shown. It seems that different conditions are used to determine which icon to display on both pages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8614 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8614 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I can't reproduce this bug in current master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8614 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.8 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, I retested, I see it in 3.6.3 and 3.8.x - not on master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8614 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8614 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13453&action=edit Bug 8614 [3.8.x] Icon for scores on OPAC detail page broken At some point some famfamfam icons were moved out of the theme director into the lib directory in opac-tmpl. When this was done the path to the directory was changed accordingly in most cases. However, not all famfamfam icons were moved, and some image paths were not corrected. This patch completes the move of the famfamfam icon set to opac-tmpl/lib and corrects the path to the icons on the OPAC XSL detail page and the OPAC holds page. To test, view those pages and confirm that the images work. View records with a variety of material types. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8614 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris@bigballofwax.co.nz Patch complexity|--- |Trivial patch --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- I tried applying this on 3.8.x Using index info to reconstruct a base tree... error: patch failed: koha-tmpl/opac-tmpl/prog/famfamfam/mini/readme.txt:1 error: koha-tmpl/opac-tmpl/prog/famfamfam/mini/readme.txt: patch does not apply error: patch failed: koha-tmpl/opac-tmpl/prog/famfamfam/readme.txt:1 error: koha-tmpl/opac-tmpl/prog/famfamfam/readme.txt: patch does not apply Did you hand edit your patch? It does not apply to blobs recorded in its index. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8614 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8614 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13453|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13784&action=edit Bug 8614 [3.8.x] Icon for scores on OPAC detail page broken At some point some famfamfam icons were moved out of the theme director into the lib directory in opac-tmpl. When this was done the path to the directory was changed accordingly in most cases. However, not all famfamfam icons were moved, and some image paths were not corrected. This patch completes the move of the famfamfam icon set to opac-tmpl/lib and corrects the path to the icons on the OPAC XSL detail page and the OPAC holds page. To test, view those pages and confirm that the images work. View records with a variety of material types. Edit: Rebased on origin/3.8.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8614 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8614 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8614 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, thank you Owen -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org