https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20420 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Correction: Google Indic Transliteration is not affected, Twitter is. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20420 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 72927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72927&action=edit Bug 20420 - Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources This patch removes [% KOHA_VERSION %] from the <script> tag for some third-party JavaScript sources. [% KOHA_VERSION %] should only be used for Koha's JS resources. To test, apply the patch and enable the SocialNetworks and NovelistSelect* preferences. In the OPAC, view the detail page for a bibliographic record. In the right-hand sidebar you should see social network icons for Google+ and Twitter. Clicking either of them should trigger a sharing popup window. If you have Novelist credentials and can enable the feature for the OPAC you should see Novelist content in the place specified in your preferences. If you don't have Novelist credentials, put some random text in the NovelistSelectProfile system preference. Looking at the detail page in the OPAC, view source. You should see a link to Novelist JS around line 1020 of the source. Clicking the link should show JavaScript. This confirms that the path is correct, thus the bug has been fixed. Note: The QA tool will complain that [% KOHA_VERSION %] is missing. This is a false positive. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20420 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72927|0 |1 is obsolete| | --- Comment #3 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 72964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72964&action=edit Bug 20420 - Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources This patch removes [% KOHA_VERSION %] from the <script> tag for some third-party JavaScript sources. [% KOHA_VERSION %] should only be used for Koha's JS resources. To test, apply the patch and enable the SocialNetworks and NovelistSelect* preferences. In the OPAC, view the detail page for a bibliographic record. In the right-hand sidebar you should see social network icons for Google+ and Twitter. Clicking either of them should trigger a sharing popup window. If you have Novelist credentials and can enable the feature for the OPAC you should see Novelist content in the place specified in your preferences. If you don't have Novelist credentials, put some random text in the NovelistSelectProfile system preference. Looking at the detail page in the OPAC, view source. You should see a link to Novelist JS around line 1020 of the source. Clicking the link should show JavaScript. This confirms that the path is correct, thus the bug has been fixed. Note: The QA tool will complain that [% KOHA_VERSION %] is missing. This is a false positive. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20420 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20420 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.