[Bug 20299] New: Is Koha installer suggesting Koha is shit?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 Bug ID: 20299 Summary: Is Koha installer suggesting Koha is shit? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 18336 Bug 18336 displays: + print "Upgrade to $DBversion done (Bug 18336: Convert DB tables to utf8mb4 💩)\n"; It could be wrongly interpreted by new Koha users, we should change this emoji Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 [Bug 18336] Add support for Unicode supplementary characters -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please suggest something else :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au, | |liz@catalyst.net.nz, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- https://emojipedia.org/wrapped-present/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #2)
+1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- https://emojipedia.org/smiling-face-with-smiling-eyes/ Just for you know, an alternative. 😊 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 --- Comment #5 from Liz Rea <liz@catalyst.net.nz> --- (I don't care either way, but yes we should get rid of the poo.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- 💯 👩💻👨💻 🆕🆓 🚩 🏁 ✔ ▶ 🔑 💲💲💲 💰 📚 📖 📀 💿 💾 🔋 🔊 🔥 Ok I really could just go forever here https://unicode.org/emoji/charts/full-emoji-list.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Owen Leonard from comment #2)
I am for this as "koha" means "gift" ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 Bug 20299 depends on bug 18336, which changed state. Bug 18336 Summary: Add support for Unicode supplementary characters https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 73176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73176&action=edit Bug 20299 - Is Koha installer suggesting Koha is shit? This patch updates the database update script replacing the "pile of poo" emoji with the "wrapped gift" emoji. To test, apply the patch and go to Administration -> System preferences -> Local use. Set the "Version" preference back to trigger a database update. Go through the database update process and confirm that the "Convert DB tables to utf8mb4" upgrade message includes a gift emoji. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Is Koha installer |Koha is a gift |suggesting Koha is shit? | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73176|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 73179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73179&action=edit Bug 20299 - Koha is a gift This patch updates the database update script replacing the "pile of poo" emoji with the "wrapped gift" emoji. To test, apply the patch and go to Administration -> System preferences -> Local use. Set the "Version" preference back to trigger a database update. Go through the database update process and confirm that the "Convert DB tables to utf8mb4" upgrade message includes a gift emoji. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73179|0 |1 is obsolete| | --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Created attachment 73224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73224&action=edit Bug 20299 - Koha is a gift This patch updates the database update script replacing the "pile of poo" emoji with the "wrapped gift" emoji. To test, apply the patch and go to Administration -> System preferences -> Local use. Set the "Version" preference back to trigger a database update. Go through the database update process and confirm that the "Convert DB tables to utf8mb4" upgrade message includes a gift emoji. Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #11 from Mason James <mtj@kohaaloha.com> --- (In reply to Owen Leonard from comment #9)
Created attachment 73179 [details] [review] Bug 20299 - Koha is a gift
This patch updates the database update script replacing the "pile of poo" emoji with the "wrapped gift" emoji.
..looks good to me 👍 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73224|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73225&action=edit Bug 20299 - Koha is a gift This patch updates the database update script replacing the "pile of poo" emoji with the "wrapped gift" emoji. To test, apply the patch and go to Administration -> System preferences -> Local use. Set the "Version" preference back to trigger a database update. Go through the database update process and confirm that the "Convert DB tables to utf8mb4" upgrade message includes a gift emoji. Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Owen! Plz remember : not - in subject :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73226&action=edit Bug 20299: Koha is a gift This patch updates the database update script replacing the "pile of poo" emoji with the "wrapped gift" emoji. To test, apply the patch and go to Administration -> System preferences -> Local use. Set the "Version" preference back to trigger a database update. Go through the database update process and confirm that the "Convert DB tables to utf8mb4" upgrade message includes a gift emoji. Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73225|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |nick@bywatersolutions.com Status|Pushed to Master |RESOLVED --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Awesoem work all, depends on patches which are not in stable, not backporting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org