[Bug 16291] New: koha-remove --purge should also delete /etc/koha/sites/instance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291 Bug ID: 16291 Summary: koha-remove --purge should also delete /etc/koha/sites/instance Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: mtj@kohaaloha.com QA Contact: testopia@bugs.koha-community.org It would be useful if 'koha-remove --purge' also deleted a /etc/koha/sites/instance dir -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9754 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754 [Bug 9754] koha-remove optionally includes var/lib and var/spool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|koha-remove --purge should |koha-remove --purge should |also delete |also delete |/etc/koha/sites/instance |'/etc/koha/sites/$instance' | |dir -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13902 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9754 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- *** Bug 13902 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |mirko@abunchofthings.net Component|Tools |Packaging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291 --- Comment #2 from Robin Sheat <robin@kallisti.net.nz> --- Created attachment 189899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189899&action=edit Bug 16291: remove /etc/koha/sites/$name on koha-remove --purge-all A purge leaves behind some traces in /etc/koha/sites/$name, which can cause problems because the directory isn't deleted. This deletes the whole shebang when purge is requested. Test plan: 1. With the packages installed, make an instance. 2. Make a file in there, e.g. `# cat hello > /etc/koha/sites/$name/foo.txt` 3. Delete the instance with `koha-remove $name --purge-all` 4. Verify that `/etc/koha/sites/$name no longer exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291 Robin Sheat <robin@kallisti.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |robin@kallisti.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 190041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190041&action=edit Bug 16291: Remove /etc/koha/sites/$name on koha-remove --purge-all A purge leaves behind some traces in /etc/koha/sites/$name, which can cause problems because the directory isn't deleted. This deletes the whole shebang when purge is requested. Test plan: 1. With the packages installed, make an instance. 2. Make a file in there, e.g. `# cat hello > /etc/koha/sites/$name/foo.txt` 3. Delete the instance with `koha-remove $name --purge-all` 4. Verify that `/etc/koha/sites/$name no longer exists Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #189899|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the koha-remove release notes| |--purge package command so | |that the instance name's | |directory is completely | |removed, even if it has | |additional files in it. | |Previously, the instance's | |directory wasn't removed if | |there were other files in | |it, which could cause | |problems when creating a | |new instance with the same | |name. Assignee|gmcharlt@gmail.com |robin@kallisti.net.nz --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Create an instance: sudo koha-create --create-db testkoha 2. Create a file: sudo vi /etc/koha/sites/testkoha/foo.txt 3. Change permissions: sudo chown root:testkoha-koha /etc/koha/sites/testkoha/foo.txt 4. Remove: sudo koha-remove testkoha --purge-all 5. I shut down KTD and restarted it with the patch applied, but I'm not sure if that was necessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Does this conflict with a few lines earlier: # Maybe a user has left something in the config directory they want to keep? We won't delete it here, nor throw an error if the have. [ -d "/etc/koha/sites/$name" ] && \ rmdir --ignore-fail-on-non-empty "/etc/koha/sites/$name" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org