[Bug 40457] New: Wherever possible we should lookup using borrowernumber instead of userid/cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40457 Bug ID: 40457 Summary: Wherever possible we should lookup using borrowernumber instead of userid/cardnumber Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org As we note on bug 40275, there are times where we lookup the patron using cardnumber or userid when we really should be using borrowernumber where possible. Not all Koha users will have a cardnumber plus we have on-going issues around uniqueness of cardnumber and userid whereas borrowernumber is an internal persistent and unique identifier. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40457 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40275 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40457 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34018, 39535 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34018 [Bug 34018] Patron image upload silently fails without cardnumber https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39535 [Bug 39535] Patron search in patron lists does not work for patrons without cardnumber -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40457 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13542, 40456 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13542 [Bug 13542] Subscription is the only table to store userid instead of borrowernumber https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40456 [Bug 40456] Make check_cookie_auth() use borrowernumber instead of userid/id -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40457 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- After applying 40275 I notice there's still a lot of times where we lookup borrowers using cardnumber. grep -R --exclude-dir="node_modules" --exclude-dir="t" --exclude-dir=".git" -- "->find.*cardnumber" | wc -l This returns 27 occurrences. Some of these will be legitimate but we've got lots of weird ones like reserve/request.pl where we use the cardnumber in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt instead of the borrowernumber koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt is an interesting one. There we use circulation.pl?findborrower with a cardnumber... and that is probably OK because the data at hand is the cardnumber. -- Anyway, this will take some investigating and teasing apart overall. Best to do in other dependence reports I think. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40457 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40464 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40464 [Bug 40464] Many parts of C4::Auth::checkauth() re-lookup the patron using userid/cardnumber unnecessarily -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40457 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|40464 | Depends on| |40464 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40464 [Bug 40464] Many parts of C4::Auth::checkauth() re-lookup the patron using userid/cardnumber unnecessarily -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org