[Bug 35108] New: ILL - "Manage request" page is too loaded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Bug ID: 35108 Summary: ILL - "Manage request" page is too loaded Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com CC: pedro.amorim@ptfs-europe.com Depends on: 35107 A simple ILL request that has a lot of fields empty is still presented with a very long "Manage request" page. We could do with lighten the page a bit. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 [Bug 35107] ILL - Type disclaimer value and date should be visible under "Request details" in the manage request page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 157458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157458&action=edit Bug 35108: Hide optionally empty fields label entries, these are: orderid, biblio_id, batch already was the case, type, type_disclaimer_value, type_disclaimer_date, cost, price_paid, notesstaff, notesopac Test plan, k-t-d: 1) Install FreeForm and BLDSS backends, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-p...) 2) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'. 6) Notice how there is a lot of unnecessary empty field entries 7) Apply patch, restart plack (koha-plack --restart kohadev) 8) Refresh the page, notice all the empty fields entries are no longer displayed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 157463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157463&action=edit Bug 35108: Move request id to page header Redundant information, can be moved to header for more visibility and less horizontal length -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157458|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 157464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157464&action=edit Bug 35108: Hide optionally empty fields label entries, these are: orderid, biblio_id, batch already was the case, type, type_disclaimer_value, type_disclaimer_date, cost, price_paid, notesstaff, notesopac Test plan, k-t-d: 1) Install FreeForm and BLDSS backends, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-p...) 2) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'. 6) Notice how there is a lot of unnecessary empty field entries 7) Apply patch, restart plack (koha-plack --restart kohadev) 8) Refresh the page, notice all the empty fields entries are no longer displayed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m CC| |katrin.fischer@bsz-bw.de, | |magnus@libriotech.no, | |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157463|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159657&action=edit Bug 35108: Move request id to page header Redundant information, can be moved to header for more visibility and less horizontal length -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157464|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159658&action=edit Bug 35108: Hide optionally empty fields label entries, these are: orderid, biblio_id, batch already was the case, type, type_disclaimer_value, type_disclaimer_date, cost, price_paid, notesstaff, notesopac Test plan, k-t-d: 1) Install FreeForm and BLDSS backends, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-p...) 2) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'. 6) Notice how there is a lot of unnecessary empty field entries 7) Apply patch, restart plack (koha-plack --restart kohadev) 8) Refresh the page, notice all the empty fields entries are no longer displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159657|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 159688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159688&action=edit Bug 35108: Move request id to page header Redundant information, can be moved to header for more visibility and less horizontal length Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159658|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 159689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159689&action=edit Bug 35108: Hide optionally empty fields label entries, these are: orderid, biblio_id, batch already was the case, type, type_disclaimer_value, type_disclaimer_date, cost, price_paid, notesstaff, notesopac Test plan, k-t-d: 1) Install FreeForm and BLDSS backends, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-p...) 2) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'. 6) Notice how there is a lot of unnecessary empty field entries 7) Apply patch, restart plack (koha-plack --restart kohadev) 8) Refresh the page, notice all the empty fields entries are no longer displayed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement hides release notes| |option fields that are | |empty when displaying ILL | |requests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159688|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159752&action=edit Bug 35108: Move request id to page header Redundant information, can be moved to header for more visibility and less horizontal length Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159753&action=edit Bug 35108: Hide empty fields on ILL manage request page Optionally empty fields are: orderid, biblio_id, batch, type, type_disclaimer_value, type_disclaimer_date, cost, price_paid, notesstaff, notesopac. Test plan, k-t-d: 1) Install FreeForm and BLDSS backends, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-p...) 2) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'. 6) Notice how there is a lot of unnecessary empty field entries 7) Apply patch, restart plack (koha-plack --restart kohadev) 8) Refresh the page, notice all the empty fields entries are no longer displayed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159689|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Simple trivial patch to improve display.. Passing QA, but the dependency still needs an QA stamp from someone else. I'll pass then mark as blocked whilst we wait for the dependency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Pedro, should be an easy rebase, but I want to keep moving right now - can you please take care of it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159752|0 |1 is obsolete| | --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165136&action=edit Bug 35108: Move request id to page header Redundant information, can be moved to header for more visibility and less horizontal length Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159753|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165137&action=edit Bug 35108: Hide empty fields on ILL manage request page Optionally empty fields are: orderid, biblio_id, batch, type, type_disclaimer_value, type_disclaimer_date, cost, price_paid, notesstaff, notesopac. Test plan, k-t-d: 1) Install FreeForm and BLDSS backends, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-p...) 2) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'. 6) Notice how there is a lot of unnecessary empty field entries 7) Apply patch, restart plack (koha-plack --restart kohadev) 8) Refresh the page, notice all the empty fields entries are no longer displayed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This resolve at least a part of my Bug 36401 - Yay! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org