[Bug 15905] New: Remove use of makepayment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Bug ID: 15905 Summary: Remove use of makepayment Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com Depends on| |15896 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 [Bug 15896] Use Koha::Account::pay internally for makepayment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15906 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15906 [Bug 15906] Remove use of makepayment in paycollect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15907 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 [Bug 15907] Remove use of makepayment in opac/opac-account-pay-paypal-return.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 [Bug 15894] Unify all account fine payment functions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 48350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48350&action=edit Bug 15905 - Update unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 48351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48351&action=edit Bug 15905 - Remove use of makepayment Test Plan: 1) Apply these patches 2) prove t/db_dependent/Accounts.t 3) 'git grep makepayment' should return no results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia@hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- fatal: sha1 information is lacking or useless (t/db_dependent/Accounts.t). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Aleisha Amohia from comment #3)
fatal: sha1 information is lacking or useless (t/db_dependent/Accounts.t).
Confirmed. 15895 (3 way merge okay), 15896, 15906, and 15907 all apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to M. Tompsett from comment #4)
(In reply to Aleisha Amohia from comment #3)
fatal: sha1 information is lacking or useless (t/db_dependent/Accounts.t).
Confirmed. 15895 (3 way merge okay), 15896, 15906, and 15907 all apply.
It's possible I've missed a dependency. Please check out this dependency graph: https://bugs.koha-community.org/bugzilla3/showdependencygraph.cgi?id=15894 Ideally, if we could get signoffs on the patches from top to bottom everything should work itself out. Just for posterity, the order in which I wrote the patches is as follows: 15895 15896 15897 15898 15900 15901 15902 15903 15899 15906 15907 15905 15908 15909 I could simplify the dependency graph my making simply a straight line, but that would prevent any parallel testing that could be occurring. From a practical standpoint, if you test the patches in this order everything should apply cleanly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- I've pushed out a github branch with this entire patch set applied for ease of testing: https://github.com/bywatersolutions/bywater-koha-devel/tree/bug_15894_-_Unif... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15896 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 [Bug 15896] Use Koha::Account::pay internally for makepayment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48350|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52136&action=edit Bug 15905 - Update unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52136|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52150&action=edit Bug 15905 - Update unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48351|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52151&action=edit Bug 15905 - Remove use of makepayment Test Plan: 1) Apply these patches 2) prove t/db_dependent/Accounts.t 3) 'git grep makepayment' should return no results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Bug 15905 depends on bug 15906, which changed state. Bug 15906 Summary: [ONLY PUSH TOGETHER WITH 15896] Remove use of makepayment in paycollect.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15906 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52150|0 |1 is obsolete| | Attachment #52151|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 58821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58821&action=edit Bug 15905 - Update unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 58822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58822&action=edit Bug 15905 - Remove use of makepayment Test Plan: 1) Apply these patches 2) prove t/db_dependent/Accounts.t 3) 'git grep makepayment' should return no results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58821|0 |1 is obsolete| | --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 58831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58831&action=edit Bug 15905 - Update unit tests Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58822|0 |1 is obsolete| | --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 58832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58832&action=edit Bug 15905 - Remove use of makepayment Test Plan: 1) Apply these patches 2) prove t/db_dependent/Accounts.t 3) 'git grep makepayment' should return no results Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- Bug 15907 hasn't been pushed yet, so had to apply first before testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58831|0 |1 is obsolete| | Attachment #58832|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58841&action=edit Bug 15905 - Update unit tests Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58842&action=edit Bug 15905 - Remove use of makepayment Test Plan: 1) Apply these patches 2) prove t/db_dependent/Accounts.t 3) 'git grep makepayment' should return no results Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58843&action=edit Bug 15905: Remove one last occurrence of makepayment in comment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Bug 15905 depends on bug 15907, which changed state. Bug 15907 Summary: Remove use of makepayment in opac/opac-account-pay-paypal-return.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org