[Bug 15907] New: Remove use of makepayment in opac/opac-account-pay-paypal-return.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Bug ID: 15907 Summary: Remove use of makepayment in opac/opac-account-pay-paypal-return.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com Blocks| |15905 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 [Bug 15905] Remove use of makepayment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 48348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48348&action=edit Bug 15907 - Remove use of makepayment in opac/opac-account-pay-paypal-return.pl Test Plan: 1) Apply this patch 2) Make a payment via PayPal in sandbox mode 3) Note the payment succeeds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15896 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 [Bug 15896] Use Koha::Account::pay internally for makepayment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48348|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52149&action=edit Bug 15907 - Remove use of makepayment in opac/opac-account-pay-paypal-return.pl Test Plan: 1) Apply this patch 2) Make a payment via PayPal in sandbox mode 3) Note the payment succeeds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Kyle, I think there is amount missing in calling Koha::Account->pay I tried via paypal sandbox and the pay accountline was added, but with amount of 0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Could you please look at this? It should be trivial to fix it (I hope), but better done by you, as I can then test and sign-off and not have to wait to another tester... Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52149|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57194&action=edit Bug 15907 - Remove use of makepayment in opac/opac-account-pay-paypal-return.pl Test Plan: 1) Apply this patch 2) Make a payment via PayPal in sandbox mode 3) Note the payment succeeds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Josef Moravec from comment #4)
Could you please look at this? It should be trivial to fix it (I hope), but better done by you, as I can then test and sign-off and not have to wait to another tester... Thanks!
Good catch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15896 |15897 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- I didn't noticed before, but as you are passing account lines to pay sub as list, it looks this is based on bug 15897, which does need rebase (so this will probably too) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 [Bug 15896] Use Koha::Account::pay internally for makepayment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 [Bug 15897] Use Koha::Account::pay internally for recordpayment_selectaccts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Needs Signoff |Failed QA --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please adjust this parameter: + lines => [$line], And check the comment on bug 15986 on the paypal script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Sorry 15896 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #8)
Please adjust this parameter:
+ lines => [$line],
And check the comment on bug 15986 on the paypal script.
Not sure what you mean by this. Koha::Account::Pay accepts a 'lines' parameter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Kyle M Hall from comment #10)
(In reply to Marcel de Rooy from comment #8)
Please adjust this parameter:
+ lines => [$line],
And check the comment on bug 15986 on the paypal script.
Not sure what you mean by this. Koha::Account::Pay accepts a 'lines' parameter.
Could you please double-check? I cannot find it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Marcel de Rooy from comment #11)
(In reply to Kyle M Hall from comment #10)
(In reply to Marcel de Rooy from comment #8)
Please adjust this parameter:
+ lines => [$line],
And check the comment on bug 15986 on the paypal script.
Not sure what you mean by this. Koha::Account::Pay accepts a 'lines' parameter.
Could you please double-check? I cannot find it.
It was added by bug 15897 I think -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Josef Moravec from comment #12)
(In reply to Marcel de Rooy from comment #11)
(In reply to Kyle M Hall from comment #10)
(In reply to Marcel de Rooy from comment #8)
Please adjust this parameter:
+ lines => [$line],
And check the comment on bug 15986 on the paypal script.
Not sure what you mean by this. Koha::Account::Pay accepts a 'lines' parameter.
Could you please double-check? I cannot find it.
It was added by bug 15897 I think
OK That's clear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Kyle, I could be wrong, but, shouldn't it be better (just for being on the safe side) to make the array of account lines objects and then call the Koha::Account->pay just once on top of it? Because this way you call pay method with whole amount on each of the accountline... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Josef Moravec from comment #14)
Kyle, I could be wrong, but, shouldn't it be better (just for being on the safe side) to make the array of account lines objects and then call the Koha::Account->pay just once on top of it? Because this way you call pay method with whole amount on each of the accountline...
I see what you mean. Yes, what I did here seems a bit silly, I'll put up a followup asap! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 58816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58816&action=edit Bug 15907 [QA Followup] - Simplify code and call pay() only once -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57194|0 |1 is obsolete| | --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58829&action=edit [SIGNED-OFF] Bug 15907 - Remove use of makepayment in opac/opac-account-pay-paypal-return.pl Test Plan: 1) Apply this patch 2) Make a payment via PayPal in sandbox mode 3) Note the payment succeeds Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58816|0 |1 is obsolete| | --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58830&action=edit [SIGNED-OFF] Bug 15907 [QA Followup] - Simplify code and call pay() only once Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58829|0 |1 is obsolete| | Attachment #58830|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58840&action=edit Bug 15907 - Remove use of makepayment in opac/opac-account-pay-paypal-return.pl Test Plan: 1) Apply this patch 2) Make a payment via PayPal in sandbox mode 3) Note the payment succeeds Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Bug 15907 [QA Followup] - Simplify code and call pay() only once Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have squashed the 2 patches. I did not test the paypal payment but the code looks good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Bug 15907 depends on bug 15897, which changed state. Bug 15897 Summary: Use Koha::Account::pay internally for recordpayment_selectaccts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org