[Bug 9685] New: Allow sort baskets by number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Bug ID: 9685 Summary: Allow sort baskets by number Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.somers@biblibre.com In acqui/booksellers.pl, first column of baskets tables is "name (#number)". This allows to sort by name but not by numnber. I propose to split into 2 columns number and name to allow sorting on number. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 15588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15588&action=edit Proposed patch See commit message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15588|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15684&action=edit [SIGNED-OFF] Bug 9685: Allow sort baskets by number In acqui/booksellers.pl, first column of baskets tables is "name (#number)". This allows to sort by name but not by numnber. This patch splits acutal first column into 2 columns number and name to allow sorting on number. Test plan: Look at page and use sorting on name and n° columns. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: The patch submitted by Owen does not apply (fatal: cannot convert from UTF-8utf-8 to UTF-8). Furthermore before this patch, the table is sorted on the basket name by default, after by basketno. We have to keep the same order. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15684|0 |1 is obsolete| | --- Comment #4 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 15766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15766&action=edit Proposed patch (revised) Added default sort on basket name. Please re-signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Marc Sabin <marc.sabin@sciencespo-grenoble.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15766|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 15926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15926&action=edit Add robots txt file to deny all bots Signed-off-by: Marc Sabin <marc.sabin@sciencespo-grenoble.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #6)
Created attachment 15926 [details] [review] Add robots txt file to deny all bots
Signed-off-by: Marc Sabin <marc.sabin@sciencespo-grenoble.fr>
Looks like a mistake... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15926|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 15926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15926 Add robots txt file to deny all bots not the good report. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15766|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Switch back to Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Marc Sabin <marc.sabin@sciencespo-grenoble.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15766|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 15979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15979&action=edit Bug 9685: Allow sort baskets by number In acqui/booksellers.pl, first column of baskets tables is "name (#number)". This allows to sort by name but not by numnber. This patch splits acutal first column into 2 columns number and name to allow sorting on number. Sets default sort on name like existing. Test plan: Look at page and use sorting on name and n° columns. Signed-off-by: Marc Sabin <marc.sabin@sciencespo-grenoble.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16029&action=edit But 9791: Remove single pixel on datatable tables Test plan: Check on the 5 pages that pixels are disappears after applying this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16029|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 16029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16029 But 9791: Remove single pixel on datatable tables Not the good report either... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15979|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17055&action=edit [PASSED QA] Bug 9685: Allow sort baskets by number In acqui/booksellers.pl, first column of baskets tables is "name (#number)". This allows to sort by name but not by numnber. This patch splits acutal first column into 2 columns number and name to allow sorting on number. Sets default sort on name like existing. Test plan: Look at page and use sorting on name and number columns. Signed-off-by: Marc Sabin <marc.sabin@sciencespo-grenoble.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Nice change for better usability. Sorting of both columns works nicely. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org