http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9882 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9882 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia@bywatersolutions.com --- Comment #2 from Melia Meggs <melia@bywatersolutions.com> --- Hey Owen, I am testing this patch, and it seems to mostly work. Everything in batch item deletion looks great, but I ran into some problems in batch item modification. In batch item modification: - Checking and unchecking all work fine - Hide/show works fine - On tablesorting, I have a few questions: 1. I'm not sure all of the columns are sorting correctly. When I sort by Title, it seems to go A to Z from top to bottom mostly. But when I sort by Current Location or Permanent Location, it seems to go from Z to A from top to bottom. I don't have info in every column to test (my item types are all the same, for example), but at initial glance I think the tablesorting isn't quite right. 2. I thought that clicking the little arrow again would reverse the sorting, but that doesn't seem to work on any of the columns. Thanks, Melia -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9882 --- Comment #4 from Melia Meggs <melia@bywatersolutions.com> --- Hhmm, clearing the cache didn't fix it. I tried in both Firefox and Chrome, but something's still not right for me. However, I have been having other weird browser problems this week, so it is probably just me and not the patch. I might have to let someone else test this one to be sure. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9882 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Melia Meggs <melia@bywatersolutions.com> --- Never mind, I got it. :) All is working now. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9882 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16702|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17065&action=edit [PASSED QA] Bug 9882 - Use DataTables on batch modifications pages The batch modification pages (edit and delete) use the old tablesorter plugin. They should use DataTables instead. This patch makes the following changes: - Remove tablesorter plugin from batchMod.tt where it was unused. - Replace tablesorter assets with DataTables assets on batch edit and batch delete pages. - Replace tablesorter code with DataTables code in batchMod.js, which provides table sorting functionality for both batch templates. - Move position of batchMod.js script inclusion so that DataTables assets are loaded first. - Remove inline table sorting code from batch edit page since it is provided by batchMod.js To test, load barcodes on both the batch edit and batch delete pages. Test JavaScript-based functionality on each results page: - Check/Uncheck all - Hide/show columns - Table sorting on a variety of different kinds of data columns Batch operations should complete normally. There should be no JavaScript error on the batch operation "landing page" (batchMod.tt). Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Checked both patches, no problems found. -- You are receiving this mail because: You are watching all bug changes.