[Bug 12222] New: members-update.tt has a giant hash variable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12222 Bug ID: 12222 Summary: members-update.tt has a giant hash variable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr members-update.tt has a giant hash variable that contains the borrowers database table fields, and their clear-text counterparts. This shows up in the po-files as one giant msgid, which is really ugly and unwieldy: msgid "" "%s %s [%% SET field_display_names = { surname => \"Surname\" firstname => " "\"First name\" title => \"Title\" othernames => \"Other names\" initials => " "\"Initials\" streetnumber => \"Street number\" streettype => \"Street type\" " "address => \"Address\" address2 => \"Address 2\" city => \"City\" state => " etc. for 20 more lines. This should probably be split into a separate tt include, and changed so only the translatable strings are picked up for translation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12222 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30678&action=edit Bug 12222: members-update.tt has a giant hash variable This patch changes that giant hash by a TT block to find apropriate strings To test: 1) Apply the patch 2) On opac log as some user and request some modifications on personal data 3) On staff, reload main, will see a notice that a patron has requested modification, clic on the link 4) All modified data must show with apropriate legends for each db column, check for regressions 5) Update translation files for your preferred language, xx-YY Check for new strings, e.g. egrep "Alternate address" misc/translator/po/xx-YY* You must find old and new instances (old with #~ , in particular the hash one) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12222 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel@gmail.com Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | Severity|enhancement |minor --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Changed Importance from enhancement to minor, from the perspective of translation this is a bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12222 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12222 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30678|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30682&action=edit Bug 12222: members-update.tt has a giant hash variable This patch changes that giant hash by a TT block to find apropriate strings To test: 1) Apply the patch 2) On opac log as some user and request some modifications on personal data 3) On staff, reload main, will see a notice that a patron has requested modification, clic on the link 4) All modified data must show with apropriate legends for each db column, check for regressions 5) Update translation files for your preferred language, xx-YY Check for new strings, e.g. egrep "Alternate address" misc/translator/po/xx-YY* You must find old and new instances (old with #~ , in particular the hash one) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Works as advertised, strings are now translatable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12222 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have problems testing this. When I try to send an update request, I have an error message: DBIx::Class::Row::new(): No such column 'B_email' on Koha::Schema::Result::BorrowerModification at /home/katrin/kohaclone/Koha/Borrower/Modifications.pm line 63 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12222 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should add... also happens on master for me, but can't check this works at the moment. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12222 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12623 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12222 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12222 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30682|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31074&action=edit Bug 12222: members-update.tt has a giant hash variable This patch changes that giant hash by a TT block to find apropriate strings To test: 1) Apply the patch 2) On opac log as some user and request some modifications on personal data 3) On staff, reload main, will see a notice that a patron has requested modification, clic on the link 4) All modified data must show with apropriate legends for each db column, check for regressions 5) Update translation files for your preferred language, xx-YY Check for new strings, e.g. egrep "Alternate address" misc/translator/po/xx-YY* You must find old and new instances (old with #~ , in particular the hash one) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Works as advertised, strings are now translatable. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12222 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Works great with patch on bug 12623. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12222 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Bernardo! I'd prefer to have the field names read from columns.def instead, please take a look at C4::Templates::GetColumnDefs. Important improvement anyway. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org