[Bug 20245] New: Wrong language code for Slovak
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 Bug ID: 20245 Summary: Wrong language code for Slovak Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: pe.havel@gmail.com QA Contact: testopia@bugs.koha-community.org CC: josef.moravec@gmail.com Wrong language code in mandatory/subtag_registry.sql for Slovak. Value 'slk' → 'slo' in table language_rfc4646_to_iso639, key 'sk'. OLD: INSERT INTO language_rfc4646_to_iso639(rfc4646_subtag,iso639_2_code) VALUES ( 'sk','slk'); NEW: INSERT INTO language_rfc4646_to_iso639(rfc4646_subtag,iso639_2_code) VALUES ( 'sk','slo'); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 Petr Havel <pe.havel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pe.havel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hola Petr, Can you provide a patch please? https://wiki.koha-community.org/wiki/Submitting_A_Patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Version|16.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 --- Comment #2 from Petr Havel <pe.havel@gmail.com> --- (In reply to Jonathan Druart from comment #1)
Hola Petr, Can you provide a patch please?
Sorry, I can't make patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 --- Comment #3 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 72542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72542&action=edit Bug 20245: Wrong language code for Slovak This patch only updates iso639_2_code value for Slovak language Test plan: 1) Obtain a biblio record having 'slo' value in its language code (marc field 041a) 2) Try to find it through Advanced search + more options with language set to Slovak 3) Nothing is found 4) Apply this patch 5) Repeat steps 1 and 2 6) Record is found now -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |rbit@rbit.cz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- I just ran through all the codes we have in the installer/data/mysql/en/mandatory/subtag_registry.sql Looking at https://www.loc.gov/standards/iso639-2/php/code_list.php I noticed that the following use either Bibliographic or Terminology codes. This patch turns slk to slo (T)->(B). So the question I have is: should not all the codes be Bibliographic? cze - B ger - B gre - B eus - T per - B fre - B arm - B ice - B geo - B mri - T may - B dut - B pbr - is ISO 639-3 code, not 639-2 code! prs - is ISO 639-3 code, not 639-2 code! rum - B slk - T -- see bug 20245 sqi - T chi - B -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Mark, can you explain the difference? Anyway, I think this should go on a separate bug if this one is ok to go in. I've usually checked: http://www.loc.gov/marc/languages/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@joensuu.fi --- Comment #6 from paxed <pasi.kallinen@joensuu.fi> --- If these codes are going to be used to match the language codes in field 041 or 008/35-37, then these need to be the bibliographic type. See also: https://en.wikipedia.org/wiki/ISO_639-2#B_and_T_codes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20364 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Based on reading from links given, I found this particular excerpt useful: "RELATIONSHIP TO ISO 639-2 ISO 639-2 (Codes for the representation of names of languages-- Part 2: alpha-3 code) was based on the MARC Code List for Languages and published in 1998. In the 22 cases where the ISO 639-2 list has two alternative codes, the bibliographic code is the same as the MARC code." (http://www.loc.gov/marc/languages/introduction.pdf) As such, I'm leaning towards they should all be Bibliographic. So, I'm going to sign this off. However, we should fix the others too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72542|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73360&action=edit Bug 20245: Wrong language code for Slovak This patch updates iso639_2_code value for Slovak language Test plan: 1) Obtain a biblio record having 'slo' value in its language code (marc field 041a) 2) Try to find it through Advanced search + more options with language set to Slovak 3) Nothing is found 4) Apply this patch 5) Repeat steps 1 and 2 6) Record is found now Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20482 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73360|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 73754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73754&action=edit Bug 20245: Wrong language code for Slovak This patch updates iso639_2_code value for Slovak language Test plan: 1) Obtain a biblio record having 'slo' value in its language code (marc field 041a) 2) Try to find it through Advanced search + more options with language set to Slovak 3) Nothing is found 4) Apply this patch 5) Repeat steps 1 and 2 6) Record is found now Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #7)
As such, I'm leaning towards they should all be Bibliographic. So, I'm going to sign this off. However, we should fix the others too.
Where? When? Who? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #10)
(In reply to M. Tompsett from comment #7)
As such, I'm leaning towards they should all be Bibliographic. So, I'm going to sign this off. However, we should fix the others too.
Where? When? Who?
See comment #4 for the list that needs fixing. See bug 20482 for the rest of them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sorry, I missed the "See also" field. Thanks Mark. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's not clear to me if I should push this one without bug 20482 (why fix one when all should be fixed?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org