[Bug 42222] New: Use of uninitialized string in string eq in Auth.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42222 Bug ID: 42222 Summary: Use of uninitialized string in string eq in Auth.pm Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: ephetteplace@cca.edu QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org I noticed in the error logs "Use of uninitialized value in string eq at /kohadevbox/koha/C4/Auth.pm line 198". This occurs when you're 1) already authenticated and 2) doing any POST request, on both the public and staff sides. It's because `$in->{query}->param('login_op')` is undef when the user isn't logging in. Patch coming shortly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42222 --- Comment #1 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 196591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196591&action=edit Bug 42222: Use of uninitialized string in string eq in Auth.pm Testing: - Follow plack intranet and/or opac error logs, tail -f /var/log/koha/kohadev/plack-*-error.log - Login using web browser - Do a POST request on either intranet or OPAC, for instance: - Staff: Reports > create a new SQL report "select 'hello'" - Public: search, select a book, add to a list - 'uninitialized string' error appears in respective logs - Apply patch - restart_all - Do another POST request - No further errors should appear in the logs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42222 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42222 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42222 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |ephetteplace@cca.edu |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42222 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42222 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196591|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42222 --- Comment #2 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 196592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196592&action=edit Bug 42222: Use of uninitialized string in string eq in Auth.pm Testing: - Follow plack intranet and/or opac error logs, tail -f /var/log/koha/kohadev/plack-*-error.log - Login using web browser - Do a POST request on either intranet or OPAC, for instance: - Staff: Reports > create a new SQL report "select 'hello'" - Public: search, select a book, add to a list - 'uninitialized string' error appears in respective logs - Apply patch - restart_all - Do another POST request - No further errors should appear in the logs Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42222 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196592|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42222 --- Comment #3 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 197102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197102&action=edit Bug 42222: Use of uninitialized string in string eq in Auth.pm Testing: - Follow plack intranet and/or opac error logs, tail -f /var/log/koha/kohadev/plack-*-error.log - Login using web browser - Do a POST request on either intranet or OPAC, for instance: - Staff: Reports > create a new SQL report "select 'hello'" - Public: search, select a book, add to a list - 'uninitialized string' error appears in respective logs - Apply patch - restart_all - Do another POST request - No further errors should appear in the logs Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42222 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Status|Signed Off |Passed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42222 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42222 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42222 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42222 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42222 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org