[Bug 42176] New: Form to create an authorized value is submitted when cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42176 Bug ID: 42176 Summary: Form to create an authorized value is submitted when cancelled Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: kevin.carnes@ub.lu.se QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When editing an item and entering an authorized value that does not exist, it is possible to create a new authorized value, but if you click Cancel it still submits the form. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42176 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kevin.carnes@ub.lu.se |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42176 --- Comment #1 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 196157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196157&action=edit Bug 42176: Can cancel add authorized value The cancel add authorized value button has no type, so it will submit the form. This patch makes it a button so it does not submit the form. Test plan: 1. Ensure that the CreateAVFromCataloguing preference is enabled. 2. Edit an item. 3. Enter an authorized value that does not exist (e.g. shelving location). 4. Select it to be able to create it. 5. Click the Cancel button to not create a new authorized value. 6. Observe that the form was sent or that a new authorized value was created. 7. Delete the new authorized value. 8. Apply the patch. 9. Repeat steps 2-5. 10. Observe that the form was not sent or that a new authorized value was not created. 11. Sign off. Sponsored-by: Lund University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42176 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42176 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42176 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Status|Needs Signoff |Signed Off Comma delimited| |Lund University Library list of Sponsors| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42176 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196157|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42176 --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 196179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196179&action=edit Bug 42176: Can cancel add authorized value The cancel add authorized value button has no type, so it will submit the form. This patch makes it a button so it does not submit the form. Test plan: 1. Ensure that the CreateAVFromCataloguing preference is enabled. 2. Edit an item. 3. Enter an authorized value that does not exist (e.g. shelving location). 4. Select it to be able to create it. 5. Click the Cancel button to not create a new authorized value. 6. Observe that the form was sent or that a new authorized value was created. 7. Delete the new authorized value. 8. Apply the patch. 9. Repeat steps 2-5. 10. Observe that the form was not sent or that a new authorized value was not created. 11. Sign off. Sponsored-by: Lund University Library Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42176 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42176 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196179|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42176 --- Comment #3 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 199063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199063&action=edit Bug 42176: Can cancel add authorized value The cancel add authorized value button has no type, so it will submit the form. This patch makes it a button so it does not submit the form. Test plan: 1. Ensure that the CreateAVFromCataloguing preference is enabled. 2. Edit an item. 3. Enter an authorized value that does not exist (e.g. shelving location). 4. Select it to be able to create it. 5. Click the Cancel button to not create a new authorized value. 6. Observe that the form was sent or that a new authorized value was created. 7. Delete the new authorized value. 8. Apply the patch. 9. Repeat steps 2-5. 10. Observe that the form was not sent or that a new authorized value was not created. 11. Sign off. Sponsored-by: Lund University Library Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42176 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42176 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42176 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42176 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42176 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42176 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org