[Bug 11265] New: Problems with locale saving/editing on serial subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 Bug ID: 11265 Summary: Problems with locale saving/editing on serial subscriptions Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com While writing the patch for 11264 I tried a few things with the new locale setting. There are 2 notable problems: 1) When you explicitly pick a locale it is save to the database correctly, but when you edit the subscription later, the pull down is shown empty. 2) It didn't detect my system locale correctly. I am not sure if I am missing an additional thing in the code? After applying 11264 and picking de-DE explicitly the season names show in German. But if I don't pick the locale, the season names are in English. I can't test this with French right now, maybe someone else can? That's the result of running locale on my system: LANG=de_DE.UTF-8 LANGUAGE=de_DE:en LC_CTYPE="de_DE.UTF-8" LC_NUMERIC="de_DE.UTF-8" LC_TIME="de_DE.UTF-8" LC_COLLATE="de_DE.UTF-8" LC_MONETARY="de_DE.UTF-8" LC_MESSAGES="de_DE.UTF-8" LC_PAPER="de_DE.UTF-8" LC_NAME="de_DE.UTF-8" LC_ADDRESS="de_DE.UTF-8" LC_TELEPHONE="de_DE.UTF-8" LC_MEASUREMENT="de_DE.UTF-8" LC_IDENTIFICATION="de_DE.UTF-8" LC_ALL= -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7688 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23023&action=edit Bug 11265: the locale value is not selected on editing a subscription Test plan: 0/ you have to have some locales defined, run dpkg-reconfigure locales to configure locales 1/ edit a subscription (or add a new one) and select a locale 2/ save 3/ edit again and verify the locale value is selected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #0)
While writing the patch for 11264 I tried a few things with the new locale setting. There are 2 notable problems:
1) When you explicitly pick a locale it is save to the database correctly, but when you edit the subscription later, the pull down is shown empty.
Should be fix by the patch.
2) It didn't detect my system locale correctly. I am not sure if I am missing an additional thing in the code?
In fact Apache does not export the system locales. A workaround would be to export the needed value in the Apache conf: SetEnv LC_TIME 'LANG.utf8' (with LANG is fr_FR or de_DE, etc.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Depending on the server locale is a bit worrying to me. Is it possible to investigate other ways here? Like having a system preference list or an authorized value? When Apache doesn't support locales, then this can never have worked. Maybe we should remove the hint from the template in that case. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23023|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23026&action=edit Bug 11265: the locale value is not selected on editing a subscription Test plan: 0/ you have to have some locales defined, run dpkg-reconfigure locales to configure locales 1/ edit a subscription (or add a new one) and select a locale 2/ save 3/ edit again and verify the locale value is selected 4/ do the same on editing a numbering pattern (serials/subscription-numberpatterns.pl?op=modify&id=XX) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #3)
Depending on the server locale is a bit worrying to me. Is it possible to investigate other ways here? Like having a system preference list or an authorized value?
When Apache doesn't support locales, then this can never have worked. Maybe we should remove the hint from the template in that case.
I will propose another way on another bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23026|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23029&action=edit Bug 11265: the locale value is not selected on editing a subscription Test plan: 0/ you have to have some locales defined, run dpkg-reconfigure locales to configure locales 1/ edit a subscription (or add a new one) and select a locale 2/ save 3/ edit again and verify the locale value is selected 4/ do the same on editing a numbering pattern (serials/subscription-numberpatterns.pl?op=modify&id=XX) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23029|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23031&action=edit Bug 11265: the locale value is not selected on editing a subscription Test plan: 0/ you have to have some locales defined, run dpkg-reconfigure locales to configure locales 1/ edit a subscription (or add a new one) and select a locale 2/ save 3/ edit again and verify the locale value is selected -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- The 4th step in the test plan was wrong. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11263 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23031|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 23125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23125&action=edit [SIGNED-OFF] Bug 11265: the locale value is not selected on editing a subscription Test plan: 0/ you have to have some locales defined, run dpkg-reconfigure locales to configure locales 1/ edit a subscription (or add a new one) and select a locale 2/ save 3/ edit again and verify the locale value is selected Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No koha-qa errors. Tested creating a suscription, selecting locale (have many) and saving. When editing suscription: 1) Without patch locale value is not showed on page, empty value 2) With patch correct value is displayed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23125|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23126&action=edit [PASSED QA] Bug 11265: the locale value is not selected on editing a subscription Test plan: 0/ you have to have some locales defined, run dpkg-reconfigure locales to configure locales 1/ edit a subscription (or add a new one) and select a locale 2/ save 3/ edit again and verify the locale value is selected Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No koha-qa errors. Tested creating a suscription, selecting locale (have many) and saving. When editing suscription: 1) Without patch locale value is not showed on page, empty value 2) With patch correct value is displayed Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Template change only. Works as expected - saved locale is now shown on editing the subscription and will not be deleted upon saving. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #12 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- This patch has been pushed to 3.14.x, will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 Bug 11265 depends on bug 7688, which changed state. Bug 7688 Summary: Change subscriptions numbering pattern and frequencies http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org