[Bug 5349] New: Moving an order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Summary: Moving an order Change sponsored?: Sponsored Product: Koha Version: rel_3_4 Platform: All URL: http://wiki.koha-community.org/wiki/Move_order_acq_RFC OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: paul.poulain@biblibre.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Deadline: 2011-05-01 We will add a feature to let the librarian being able to move an order from a basket to another basket, for the same supplier or another. This feature will be useful for orders that can't be done by a given supplier. Note that from a technical point of view, the move will be a « copy / cancel » : the initial order will still be here, but commented as cancelled -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5358 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7163 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-05 10:54:21 UTC --- If you want to participate to the upstreaming: * assign the bug to yourself * retrieve the patch(es) on git.biblibre.com * the branch name can be found using git branch -a|grep NNNN Usually, it should be biblibre/customer/ft/MTNNNN For example: remotes/origin/stetienne/ft/MT6522 This patch is in branch number 5854 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om AssignedTo|henridamien@koha-fr.org |claire.hernandez@biblibre.c | |om -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |julian.maurice@biblibre.com Assignee|claire.hernandez@biblibre.c |julian.maurice@biblibre.com |om | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 8961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8961&action=edit Order line transfers On basket.pl and parcel.pl there is a 'Transfer' link which allow you to transfer order lines from a basket to another. The link lead to a new page which allow you to search for a bookseller, then display this bookseller's baskets. Then you can pickup a basket and the transfer will be done. This add a message in new column aqorders.internalnotes which is displayed in basket.pl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8961|0 |1 is obsolete| | --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 8962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8962&action=edit Order line transfers On basket.pl and parcel.pl there is a 'Transfer' link which allow you to transfer order lines from a basket to another. The link lead to a new page which allow you to search for a bookseller, then display this bookseller's baskets. Then you can pickup a basket and the transfer will be done. This add a message in new column aqorders.internalnotes which is displayed in basket.pl -- Two files were missing from the patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- *** Bug 5361 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |koha@univ-lyon3.fr --- Comment #5 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Tested on a sandbox : Applying: Bug 5349: Order line transfers Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Acquisition.pm Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Failed to merge in the changes. Patch failed at 0001 Bug 5349: Order line transfers When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 5349 - Moving an order Order line transfers Apply? [yn] Patch left in /tmp/Order-line-transfers-1v2GJM.patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8962|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 9909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9909&action=edit Order line transfers Rebased on current master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9909|0 |1 is obsolete| | --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 10032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10032&action=edit [SIGNED-OFF] Bug 5349: Order line transfers On basket.pl and parcel.pl there is a 'Transfer' link which allow you to transfer order lines from a basket to another. The link lead to a new page which allow you to search for a bookseller, then display this bookseller's baskets. Then you can pickup a basket and the transfer will be done. This add a message in new column aqorders.internalnotes which is displayed in basket.pl Signed-off-by: Marc Veron <veron@veron.ch> Note: Tested with different Vendors and Baskets, works as expected. Small glitch in ergonomy: The page where you can choose the new bookseller could better be a pop up like in Patrons->Guarantor information->Set to patron. Otherwise users could mistake and use the Vendors search at the top of the page (is active by default). If they do so they loose track of the transfer process. This could be fixed in a follow up - will sign off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 10190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10190&action=edit Follow-up: run transferorder.pl in a popup (In reply to comment #7)
Small glitch in ergonomy: The page where you can choose the new bookseller could better be a pop up like in Patrons->Guarantor information->Set to patron. Otherwise users could mistake and use the Vendors search at the top of the page (is active by default). If they do so they loose track of the transfer process.
I leave the bug status to "Signed off" so QA team can see it. (Note for QA team: only the first patch is signed off) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |koha.sekjal@gmail.com --- Comment #9 from Ian Walls <koha.sekjal@gmail.com> --- First patch no longer applies... probably a conflict in updatedatabase -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10032|0 |1 is obsolete| | --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 10375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10375&action=edit [SIGNED-OFF] Bug 5349: Order line transfers Rebased on master, conflicts only on updatedatabase, signoff kept. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10190|0 |1 is obsolete| | --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 10376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10376&action=edit Follow-up: run transferorder.pl in a popup Rebased on master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #12 from Marc Véron <veron@veron.ch> --- Created attachment 10441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10441&action=edit Screenshots of processing a transfer, resulting in an empty window After a click on "Transfer", I would expect a pop up like in like in Patrons->Guarantor information->Set to> patron However, transferorder.pl opens in the same browser window. If I follow the steps, I get an empty page as a final result. The PDF file shows screenshots of the steps I did. Marc -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- 1/ Did you apply the follow-up patch? 2/ Do you have any extensions or custom settings that could lead to popup window opening in current tab? (I know Firefox extension Tab Mix Plus can do this) 3/ Javascript enabled? If answers are 1/ yes 2/ no 3/ yes, please change status to failed qa and I will take a look at it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #14 from Marc Véron <veron@veron.ch> --- Sorry, I get the following error: Applying: Bug 5349: Order line transfers /usr/share/kohaclone/.git/rebase-apply/patch:109: new blank line at EOF. + error: patch failed: installer/data/mysql/updatedatabase.pl:5369 error: installer/data/mysql/updatedatabase.pl: patch does not apply Patch failed at 0001 Bug 5349: Order line transfers I tried to resolve it, maybe it did not work out correctly leading to behaviour described in comment #12 Marc -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10375|0 |1 is obsolete| | --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 10462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10462&action=edit [SIGNED-OFF] Bug 5349: Order line transfers Rebased on master, conflicts on updatedatabase. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10376|0 |1 is obsolete| | --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 10463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10463&action=edit Follow-up: run transferorder.pl in a popup Rebased on master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- Tested right now, the transferorder.pl page is opened in a popup and doesn't end on a blank screen. Please attach any relevant logs if you reproduce the problem. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #18 from Marc Véron <veron@veron.ch> --- Both patches applied. I get the same result as the screenshots show in the PDF attachment: http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10441 At the end of koha-error_log I get a couple of following lines: (...)[Mon Jun 25 16:20:59 2012] transferorder.pl: Use of uninitialized value in pattern match (m//) at /usr/share/kohaclone/C4/SQLHelper.pm line 407. Additional info: I tried with Firefox, Firefox with all plugins disabled and with Chrome. Could it be a database issue (corrupted data in order tables)? I'm afraid I have no time to puzzle this out right now, that's why I propose that somebody else does a test as well. Marc -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #19 from Marc Véron <veron@veron.ch> --- I spent some time to find out what happens. It seems that the popup functionality is implemented with the JavaScript function transfer_order_popup() in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt but it is *not* implemented in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt (this is the place where I tested, see the first page in my screenshots http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10441 ) Marc -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from Julian Maurice <julian.maurice@biblibre.com> --- Ok, I mark it as 'failed QA' and will resubmit a patch soon ;) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10463|0 |1 is obsolete| | --- Comment #21 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 10636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10636&action=edit Follow-up: run transferorder.pl in a popup Implement popup in basket.tt too. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #22 from Marc Véron <veron@veron.ch> --- Wanted to sign off after my vacancies, first patch does not apply, sorry. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10462|0 |1 is obsolete| | --- Comment #23 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 11117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11117&action=edit [SIGNED-OFF] Bug 5349: Order line transfers Rebased on master Conflicts on updatedatabase.pl and kohastructure.sql -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10636|0 |1 is obsolete| | --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 11118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11118&action=edit Follow-up: run transferorder.pl in a popup Rebased on master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #25 from Marc Véron <veron@veron.ch> --- Both patches applied, and the items can be moved between baskets as expected. I'm not sure if the following in booksellers.pl is in the scope of this bug: When I move an item, the basket where the item was removed from still shows the old count of "Items expected". E.g. you have 3 items, you move one item to an other basket, I would expect "Items expected" now to be 2, but it is still 3. Marc -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #26 from Julian Maurice <julian.maurice@biblibre.com> --- This issue is not related to this bug. I've created another bug for it: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8575 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11118|0 |1 is obsolete| | --- Comment #27 from Marc Véron <veron@veron.ch> --- Created attachment 11385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11385&action=edit [SIGNED-OFF] Bug 5349 follow-up: run transferorder.pl in a popup -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #28 from Marc Véron <veron@veron.ch> --- Created attachment 11386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11386&action=edit [SIGNED-OFF] Bug 5349 follow-up: run transferorder.pl in a popup -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11385|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #29 from Marc Véron <veron@veron.ch> --- Hmm, that was my first multi-patch sign-off, hope it is OK. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Version|rel_3_4 |master QA Contact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #30 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Question: return unless $ordernumber or $basketno; Should this not be an AND ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #31 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to comment #30)
QA Question: return unless $ordernumber or $basketno;
Should this not be an AND ?
Yes, this should be AND! I will submit a follow-up -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11117|0 |1 is obsolete| | --- Comment #32 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 12236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12236&action=edit [SIGNED-OFF] Bug 5349: Order line transfers Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11386|0 |1 is obsolete| | --- Comment #33 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 12237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12237&action=edit [SIGNED-OFF] Bug 5349 follow-up: run transferorder.pl in a popup Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #34 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 12238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12238&action=edit Bug 5349: Fix a logical test in TransferOrder -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #35 from Marc Véron <veron@veron.ch> --- First patch does not apply. Applying: Bug 5349: Order line transfers /usr/share/kohaclone/.git/rebase-apply/patch:109: new blank line at EOF. + error: patch failed: installer/data/mysql/updatedatabase.pl:5781 error: installer/data/mysql/updatedatabase.pl: patch does not apply error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt:241 error: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt: patch does not apply Patch failed at 0001 Bug 5349: Order line transfers -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12236|0 |1 is obsolete| | --- Comment #36 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 12420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12420&action=edit [SIGNED-OFF] Bug 5349: Order line transfers On basket.pl and parcel.pl there is a 'Transfer' link which allow you to transfer order lines from a basket to another. The link lead to a new page which allow you to search for a bookseller, then display this bookseller's baskets. Then you can pickup a basket and the transfer will be done. This add a message in new column aqorders.internalnotes which is displayed in basket.pl Signed-off-by: Marc Veron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12237|0 |1 is obsolete| | --- Comment #37 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 12421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12421&action=edit [SIGNED-OFF] Bug 5349 follow-up: run transferorder.pl in a popup Signed-off-by: Marc Veron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12238|0 |1 is obsolete| | --- Comment #38 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 12422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12422&action=edit Bug 5349: Fix a logical test in TransferOrder -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #39 from Julian Maurice <julian.maurice@biblibre.com> --- All patches rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #40 from Mirko Tietgen <mirko@abunchofthings.net> --- Does not apply, sorry :( Applying: Bug 5349: Order line transfers /home/pi/koha/.git/rebase-apply/patch:109: new blank line at EOF. + error: patch failed: installer/data/mysql/updatedatabase.pl:5966 error: installer/data/mysql/updatedatabase.pl: patch does not apply Patch failed at 0001 Bug 5349: Order line transfers -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12420|0 |1 is obsolete| | --- Comment #41 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 12462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12462&action=edit [SIGNED-OFF] Bug 5349: Order line transfers Rebased on master. (conflicts on updatedatabase.pl) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12421|0 |1 is obsolete| | --- Comment #42 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 12463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12463&action=edit Bug 5349 follow-up: run transferorder.pl in a popup Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12422|0 |1 is obsolete| | --- Comment #43 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 12464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12464&action=edit Bug 5349: Fix a logical test in TransferOrder Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12463|Bug 5349 follow-up: run |[SIGNED-OFF] Bug 5349 description|transferorder.pl in a popup |follow-up: run | |transferorder.pl in a popup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Marijana Glavica <mglavica@ffzg.hr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mglavica@ffzg.hr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #44 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Tested on sandbox 3. Works as expected : 1 line created and transfered in an other basket. Tested with the same vendor, and 2 different vendors. But I agree with Marc veron : "Small glitch in ergonomy: The page where you can choose the new bookseller could better be a pop up like in Patrons->Guarantor information->Set to patron. Otherwise users could mistake and use the Vendors search at the top of the page (is active by default). If they do so they loose track of the transfer process." And I add an other "glitch" : I think it could be good to indicate the name (or number?) of the Baskets, and not only of the Vendors.But this could be the fixed in a follow up. The note in cancelled order line and new orderline created in an other basket are just mentioning vendors : "Transfered from L'ARTMADA on 2013-01-05" and "Cancelled and transfered to CDMAIL PRO on 2013-01-05" => So I sign off M. Saby Rennes 2 university -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12462|0 |1 is obsolete| | --- Comment #45 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 14441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14441&action=edit [SIGNED-OFF] Bug 5349: Order line transfers -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12463|0 |1 is obsolete| | --- Comment #46 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 14442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14442&action=edit [SIGNED-OFF] Bug 5349 follow-up: run transferorder.pl in a popup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12464|0 |1 is obsolete| | --- Comment #47 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 14443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14443&action=edit [SIGNED-OFF] : Fix a logical test in TransferOrder -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #48 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Oh sorry I did not read well all the history. I signed-off the 3 patchs, but I suppose "Bug 5349 follow-up: run transferorder.pl in a popup" is NOT working as it should, because I did not see any pop-up during the transfer process... So I put the bug to "need signoff" again M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #49 from Julian Maurice <julian.maurice@biblibre.com> --- I just tried to apply the 3 patches and make a transfer. And it runs in a popup. Maybe you configured your web browser to open popups in a new tab instead of a new window ? Can someone else try ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #50 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #49)
I just tried to apply the 3 patches and make a transfer. And it runs in a popup. Maybe you configured your web browser to open popups in a new tab instead of a new window ?
I get the popup too, but it's a full-sized window (opened in a new tab in my case). The page looks like it's designed to be a smaller, standalone popup, so I think more improvements can be made which will help confusion. - Set a size on the window so that it doesn't potentially open as a new tab: window.open(url,'TransferOrder','width=500,height=300,toolbar=false,scrollbars=yes'); - Alter the markup of transferorder.tt using a popup page like guarantor_search.tt as an example. The grid must be altered to accommodate a smaller window (adjust as necessary): <style type="text/css"> #custom-doc { width:44.46em;*width:43.39em;min-width:578px; margin:auto; text-align:left; } </style> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #51 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Hi. It opened in a new tab in my case too. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #52 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #51)
Hi. It opened in a new tab in my case too. M. Saby
Mathieu, I don't understand why you set this bug to "in discussion". I think it's more a "failed QA" for now, because Owen is asking for a suggestion to improve the patch, than "in discussion", where we have at least 2 options that must be discussed & decided. am I right ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #53 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- You are true, I wanted to set it to failed QA... M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #54 from Julian Maurice <julian.maurice@biblibre.com> --- Hi Owen and Mathieu, I agreed this popup page could be improved, but I don't think this should prevent the patch to pass QA. I reset the status to Signed Off and will provide a follow-up with Owen's suggestions as soon as possible. Feel free to reset to Failed QA if you really think this patch must not pass as it is. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #55 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Hello By changing the status I just wanted to say I did not want to sign off (QA is not my job...), but after the explanations of Julian, I agree we can sign it off, as cosmetic changes can be make afterwards. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian, I have problems applying the patches, even with git am -iu3 - can you please rebase to current master and switch back to signed-off? Thx! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14441|0 |1 is obsolete| | --- Comment #57 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 16499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16499&action=edit Bug 5349: Order line transfers On basket.pl and parcel.pl there is a 'Transfer' link which allow you to transfer order lines from a basket to another. The link lead to a new page which allow you to search for a bookseller, then display this bookseller's baskets. Then you can pickup a basket and the transfer will be done. This add a message in new column aqorders.internalnotes which is displayed in basket.pl Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14442|0 |1 is obsolete| | --- Comment #58 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 16500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16500&action=edit Bug 5349 follow-up: run transferorder.pl in a popup Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14443|0 |1 is obsolete| | --- Comment #59 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 16501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16501&action=edit Bug 5349: Fix a logical test in TransferOrder -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #60 from Julian Maurice <julian.maurice@biblibre.com> --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #61 from Jonathan Druart <jonathan.druart@biblibre.com> --- Julian, Could you add a unit test for the new subroutine (C4::Acquisition::TransferOrder) please ? Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16499|0 |1 is obsolete| | --- Comment #62 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 18931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18931&action=edit [SIGNED-OFF] Bug 5349: Order line transfers Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16500|0 |1 is obsolete| | --- Comment #63 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 18933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18933&action=edit [SIGNED-OFF] Bug 5349 follow-up: run transferorder.pl in a popup Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16501|0 |1 is obsolete| | --- Comment #64 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 18934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18934&action=edit [SIGNED-OFF] Bug 5349: Fix a logical test in TransferOrder Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #65 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 18935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18935&action=edit Bug 5349: Add unit tests for TransferOrder -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian, It looks to me like the design of internalnotes is not a good idea: + $order->{'internalnotes'} = "Transfered from $booksellerfromname on $today"; + $sth->execute("Cancelled and transfered to $booksellertoname on $today", $ordernumber); This won't ever be translatable. We should never store composed English strings in the database. Also I think that for a column named internalnotes I would expect a different use. Like a internal note that a librarian can set and edit. Other solutions I can think of are to store the transferdate and the original vendor in separate columns and compose the message in the templates. Or it might be worth having a column for a cancellation reason that is filled via an authorized value list. This way we could also give other reasons, like out of print, etc. But the date and vendor would still have to be stored somewhere else if you want to keep that information. Maybe action_log? Maybe a quick discussion about this could help to find the best solution. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #67 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 19332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19332&action=edit Bug 5349: Use DB transaction/rollback in unit tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #68 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 19333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19333&action=edit Bug 5349: Create a table for order line transfers This allow to keep transfers informations without having untranslatable strings in database. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #69 from Julian Maurice <julian.maurice@biblibre.com> --- Hi Katrin, I chose another solution: a separate table for order transfers. I hope this will make everyone happy :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19333|0 |1 is obsolete| | --- Comment #70 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 19336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19336&action=edit Bug 5349: Create a table for order line transfers This allow to keep transfers informations without having untranslatable strings in database. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #71 from Julian Maurice <julian.maurice@biblibre.com> --- Fix some typos and useless use of date plugin in last patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Silvia Simonetti <s.simonetti@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s.simonetti@cineca.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #72 from David Cook <dcook@prosentient.com.au> --- Hey Julian, Could you rebase this patch? (see my error message below) I'm really keen to see this get into Koha (and hopefully 3.8.x), so I'm willing to test this as much as necessary :). GIT ERROR MESSAGE: Applying: Bug 5349: Order line transfers Using index info to reconstruct a base tree... <stdin>:256: new blank line at EOF. + warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Acquisition.pm CONFLICT (content): Merge conflict in C4/Acquisition.pm Failed to merge in the changes. Patch failed at 0001 Bug 5349: Order line transfers -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18931|0 |1 is obsolete| | --- Comment #73 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 19917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19917&action=edit [SIGNED-OFF] Bug 5349: Order line transfers -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18933|0 |1 is obsolete| | --- Comment #74 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 19918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19918&action=edit [SIGNED-OFF] Bug 5349 follow-up: run transferorder.pl in a popup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18934|0 |1 is obsolete| | --- Comment #75 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 19919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19919&action=edit [SIGNED-OFF] Bug 5349: Fix a logical test in TransferOrder -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18935|0 |1 is obsolete| | --- Comment #76 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 19920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19920&action=edit Bug 5349: Add unit tests for TransferOrder -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19332|0 |1 is obsolete| | --- Comment #77 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 19921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19921&action=edit Bug 5349: Use DB transaction/rollback in unit tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19336|0 |1 is obsolete| | --- Comment #78 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 19922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19922&action=edit Bug 5349: Create a table for order line transfers -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #79 from Julian Maurice <julian.maurice@biblibre.com> --- All patches rebased on master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #80 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Kohateam <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #81 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Tested on a sandbox. For me, everything is working as expected. I can't see if the translation is ok. I'm not bothered by the fact of pop-up is a full-sized window in a new tab... This patch will be really useful for the librarians who manage commands. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10441|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19917|0 |1 is obsolete| | Attachment #19918|0 |1 is obsolete| | Attachment #19919|0 |1 is obsolete| | Attachment #19920|0 |1 is obsolete| | Attachment #19921|0 |1 is obsolete| | Attachment #19922|0 |1 is obsolete| | --- Comment #82 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20476&action=edit Bug 5349: Order line transfers On basket.pl and parcel.pl there is a 'Transfer' link which allow you to transfer order lines from a basket to another. The link lead to a new page which allow you to search for a bookseller, then display this bookseller's baskets. Then you can pickup a basket and the transfer will be done. This add a message in new column aqorders.internalnotes which is displayed in basket.pl Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: sonia <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #83 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20477&action=edit Bug 5349 follow-up: run transferorder.pl in a popup Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: sonia <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #84 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20478&action=edit Bug 5349: Fix a logical test in TransferOrder Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: sonia <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #85 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20479&action=edit Bug 5349: Add unit tests for TransferOrder Signed-off-by: sonia <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #86 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20480&action=edit Bug 5349: Use DB transaction/rollback in unit tests Signed-off-by: sonia <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #87 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20481&action=edit Bug 5349: Create a table for order line transfers This allow to keep transfers informations without having untranslatable strings in database. Signed-off-by: sonia <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #88 from Jonathan Druart <jonathan.druart@biblibre.com> --- Note: The sandbox fails to signoff these patchs. Error from the WWW::Bugzilla package: WWW::Mechanize find_all_links gave us a bogus URL at ./cron/sandbox_signoff.cron line 78. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20476|0 |1 is obsolete| | --- Comment #89 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20691&action=edit Bug 5349: Order line transfers On basket.pl and parcel.pl there is a 'Transfer' link which allow you to transfer order lines from a basket to another. The link lead to a new page which allow you to search for a bookseller, then display this bookseller's baskets. Then you can pickup a basket and the transfer will be done. This add a message in new column aqorders.internalnotes which is displayed in basket.pl Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: sonia <koha@univ-lyon3.fr> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20477|0 |1 is obsolete| | --- Comment #90 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20692&action=edit Bug 5349 follow-up: run transferorder.pl in a popup Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: sonia <koha@univ-lyon3.fr> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20478|0 |1 is obsolete| | --- Comment #91 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20693&action=edit Bug 5349: Fix a logical test in TransferOrder Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: sonia <koha@univ-lyon3.fr> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20479|0 |1 is obsolete| | --- Comment #92 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20694&action=edit Bug 5349: Add unit tests for TransferOrder Signed-off-by: sonia <koha@univ-lyon3.fr> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signing off on this because a following patch fixes the test to use transactions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20480|0 |1 is obsolete| | --- Comment #93 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20695&action=edit Bug 5349: Use DB transaction/rollback in unit tests Signed-off-by: sonia <koha@univ-lyon3.fr> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20481|0 |1 is obsolete| | --- Comment #94 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20696&action=edit Bug 5349: Create a table for order line transfers This allow to keep transfers informations without having untranslatable strings in database. Signed-off-by: sonia <koha@univ-lyon3.fr> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #95 from Chris Cormack <chris@bigballofwax.co.nz> --- It is important to note, do not run the database update until all patches are applied, or you will end up with the db in a messy state -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #96 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a following that implements some of Owen's suggestions regarding the popup form. Thanks, Julian! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org