https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33177 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 147994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147994&action=edit Bug 33177: Use include file for subfield constraints in both authority and bibliographic frameworks This patch creates a new include file, subfields-structure-form.inc, which can be used by both auth_subfields_structure.tt and marc_subfields_structure.tt. Conditional logic in the template handles the small differences between the two systems. To test, apply the patch and restart Koha services. - Go to Administration -> MARC bibliograhpic framework - In the "Actions" menu for one of your frameworks, choose "MARC structure." - In the "Actions" menu for one of the tags, choose "Edit subfields" - Test the subfield constraints entry form by making multiple changes and confirming that the changes are saved correctly. - Try making multiple changes under multiple tabs. - Try creating a new subfield under the "New" tab. Perform the same tests under Administration -> Authority types. Note the differences between the two versions: - The biblio version has "Important," "Max length," checkboxes for "Visibility," and a text input for "Link." - The authority version has a dropdown for "Visibility" and "Koha link." -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33177 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 150189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150189&action=edit Screenshots - before and after + issues I've had a go at testing this change - which I think is a great idea! Things work as expected, however I have noted some layout and consistency things - which is why I have Failed QA. The document attached includes screenshots for the potential issues identified. Subfield editor - alignment of tabs ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ If you are on subfield 0: - the rest of the subfield tags align on the second row under the second subfield tag - this works fine for the second row of subfield tags - however, the third row is aligned under the first tab If you are on another subfield tag, the second row of tabs is aligned after that one, and then the third row is aligned under the first tab. See screenshot document - section 3. Subfield editor - spacing and layout directly under the tabs ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Bibliographic subfield: no space - just white background (I'm not sure whether there should be a space after the subfield tabs). Authority subfield: from basic constraints downwards, everything is indented - that is, not aligned with the first subfield tab. See screenshot documents - sections 1 and 2 (after screenshots). Subfield editor - spacing and layout for the sections ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Bibliographic subfield: no spacing between sections (Basic constraints, Advanced constraints, Other options (Choose one)). Authority subfield: spacing between sections - that is, each section has its own white background. See screenshot documents - sections 1 and 2 (after screenshots). Link vs Koha link ~~~~~~~~~~~~~~~~~ I don't know enough about these fields and find it confusing: - Bibliographic subfield: . before patch, has Link field (An index name, e.g. title or LocalNumber) and a dropdown list Koha link with no selectable options . after patch, just has Link - Authorities: . before patch has Koha field and a populated dropdown list . after patch has Koha link and a populated dropdown list See screenshot documents - sections 1 and 2 (before and after screenshots). Other things noticed ~~~~~~~~~~~~~~~~~~~~ These may be out of scope for this bug, but addressing these would improve consistency. Constraint column when listing subfields ---------------------------------------- The table becomes very wide when there are a lot of constraints, for an example see 100$a for BKS bibliographic framework (note that this was the case before the patch was applied). See screenshot documents - section 4. Action menu for subfields ------------------------- Maybe these should be worded the same? - Bibliographic: . Edit tag . View subfields . Edit subfields . Delete - Authority: . Subfields . Edit . Delete See screenshot document - section 5. Label names when modifying a tag -------------------------------- Maybe these should be the same as used for the subfield editor (see screenshot document - section 1 and 2). Bibliographic: - Label for lib: should this be "Text for librarian"? - Label for opac: should this be "Text for OPAC"? - Authorized value: hint text is straight after the dropdown list, maybe it should be under the input field - like it is for authorities. Authority: - Text for librarians: should this be "Text for librarian"? - Text for opac: should this be "Text for OPAC"? See screenshot document - section 6. List of tags ------------ Table listing - tag column: - For authorities: tag is bold in each row - For bibliographic: tag is not bold in each row (No screenshot.) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33177 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I'm finally giving this one another try. (In reply to David Nind from comment #2)

If you are on another subfield tag, the second row of tabs is aligned after that one, and then the third row is aligned under the first tab.

I don't think this is a consequence of my patch. In my tests the tabs wrap the same with my patch or without. Several of the comments about spacing an indentation I don't see. I'm revising the patch to make some corrections to the way the template handles differences between authority form fields and biblio form fields. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33177 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147994|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33177 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes.