https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33177 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 147994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147994&action=edit Bug 33177: Use include file for subfield constraints in both authority and bibliographic frameworks This patch creates a new include file, subfields-structure-form.inc, which can be used by both auth_subfields_structure.tt and marc_subfields_structure.tt. Conditional logic in the template handles the small differences between the two systems. To test, apply the patch and restart Koha services. - Go to Administration -> MARC bibliograhpic framework - In the "Actions" menu for one of your frameworks, choose "MARC structure." - In the "Actions" menu for one of the tags, choose "Edit subfields" - Test the subfield constraints entry form by making multiple changes and confirming that the changes are saved correctly. - Try making multiple changes under multiple tabs. - Try creating a new subfield under the "New" tab. Perform the same tests under Administration -> Authority types. Note the differences between the two versions: - The biblio version has "Important," "Max length," checkboxes for "Visibility," and a text input for "Link." - The authority version has a dropdown for "Visibility" and "Koha link." -- You are receiving this mail because: You are watching all bug changes.