http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> 2012-01-20 15:37:50 UTC --- Created attachment 7257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7257 1) Example : a repeatable field, with repeatable subfields -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 --- Comment #3 from Adrien SAURAT <adrien.saurat@biblibre.com> 2012-01-20 15:39:06 UTC --- Created attachment 7259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7259 3) The subfield is not created in the selected field -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 --- Comment #4 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 10884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10884&action=edit Proposed patch Proposed patch fixes several bugs in authority edition page. I also worked for authority edition page to be maximum similar to biblio edition page. I merged common javascript code into "cataloguing.js" file. It contains all cloning methods. Therefore, I also merged some javascript code from item edition (additem.tt, serials-edit.tt, batchMod-edit.tt). - I've add the type "text" on inputs that did not add this attribute (it is useful for js and is mandatory in XHTML). - I changed the code that tests if one is trying to remove the last field : I used JQuery instead of "fields_in_use" var. - I add cloning little images instead of "+" and "-". - Patch fixes a bug on indicators cloning in both biblio and authorities edition. Enjoy. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 --- Comment #5 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Here is a test plan : Same for Biblio and Authorities edition : ----------------------------------------- Create a new record. Go to a repeatable field with a repeatable subfield. I'll take as example 200$a. Cloning : Click on cloning image of subfield $a => subfield $a must be cloned. Click on cloning image of field 200 => field 200 must be cloned. In second field 200, click on cloning image of last subfield $a => subfield $a of the second field 200 must be cloned. Deleting : In second field 200, click on delete image of last subfield $a => last subfield $a of the second field 200 must be deleted. In second field 200, click on delete image of all subfields $a => the last one must not be deleted but empty. Click on delete image of first field 200 => the first field 200 is deleted. Click on delete image of field 200 => field 200 is not deleted but all subfields are empty. Saving : Recreate two fields 200, each one with two subfields $a. Edit indicators and subfields values with different texts. Save the record. Check if indicators and fields 200 are ok. Same for Item edition, serials edition and batch item modification : -------------------------------------------------------------------- Define an item subfield has repeatable. Go to edition page. Click on cloning image of subfield => subfield must be cloned. (There is no delete function). Edit some subfields with texts. Save and check if all values are saved. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 --- Comment #7 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Is something missing in my test plan (comment 5), or must be more explained ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 --- Comment #9 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- No problem. Feel free to ask for details. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 --- Comment #12 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 11338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11338&action=edit Proposed patch (follow-up) Asked patch. Fixes cloning problem. + uses subfield '@' replacing by '00' behavior like in biblios. + fixedfield variable was missing in subfields, in both authities and biblios, => test it with a field < 010. + fixes a missing random in id of indicator div. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11850&action=edit Problematic bib editor layout -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 --- Comment #16 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #15)

(In reply to comment #13)

...

Is the change to the display in the bibliographic editor intentional? Personally, I preferred the old display because it felt more consistent, and I can't see that the new display gains us anything. I'll post a screenshot in a moment.

I think authorities MARC editor should be as similar as possible that biblio MARC editor. That is why I made this changes.

Why don't you change the authorities MARC editor to match the bibliographic editor, rather than changing both of them, then? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 --- Comment #18 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #17)

...

Why don't you change the authorities MARC editor to match the bibliographic editor, rather than changing both of them, then? I think it is a bug that template is using a param (subfield_loo.fixedfield)

(In reply to comment #16) that does not exist.

I see. I would sign off on the patch if it did not change the bib editor. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455

Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

--- Comment #20 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> ---
(In reply to comment #18)
> I see. I would sign off on the patch if it did not change the bib editor.
Your right, bib editor is not the point of this bug.
I removed from follow-up patch the part : 
  + fixedfield variable was missing in subfields, in both authities and
biblios, => test it with a field < 010.

-- 
You are receiving this mail because:
You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11866|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11909&action=edit Bug 7455: Authority subfields are cloned in the wrong field (follow-up) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11908|0 |1 is obsolete| | --- Comment #24 from Mason James <mtj@kohaaloha.com> --- Created attachment 12216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12216&action=edit Bug 7455: Authority subfields are cloned in the wrong field (follow-up) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #26 from Paul Poulain <paul.poulain@biblibre.com> --- mmm... Mason (& others) : am I right if I say that http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11908 should not have been obsoleted, while one of the 2 follow-up should be ? atm, the 2 patches attached: * are too small to be relevant * are the same * does not apply so... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11909|0 |1 is obsolete| | --- Comment #28 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Comment on attachment 11909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11909 Bug 7455: Authority subfields are cloned in the wrong field (follow-up) Mason James, you forgot to put the existing follow-up patch on obsolete (u mixed with main patch I guess). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #29 from Paul Poulain <paul.poulain@biblibre.com> --- The patch does not apply anymore, sorry: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt Please rebase & resubmit (and switch back to passed QA) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11908|0 |1 is obsolete| | --- Comment #30 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 12313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12313&action=edit Proposed patch (rebased master) Main patch rebased master. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 --- Comment #32 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 12315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12315&action=edit Proposed patch (follow-up 2) After rebase of main patch, I noticed that bug 8332 has introduced a behavior I had to manage. So here is second follow-up. Note : 8332 introduces a source='auth' parameter in openAuth() js function only when called from authorities.tt. Since I moved this method into cataloguing.js to be mutualized between authorities et bilios edition, I added a source argument in this method. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4381 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #35 from Nicole C. Engard <nengard@gmail.com> --- I was just about to test and sign off on this, but am not experiencing this behavior. I tried in two different frameworks and repeated fields and subfields multiple times and everything stayed in the right place. Can you confirm that this is still a patch that needs to be signed off on? Maybe another patch fixed it? Nicole -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 --- Comment #37 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #35)

I was just about to test and sign off on this, but am not experiencing this behavior. I tried in two different frameworks and repeated fields and subfields multiple times and everything stayed in the right place. Can you confirm that this is still a patch that needs to be signed off on? Maybe another patch fixed it?

Nicole

I tried with actual master 3.09.00.061, problem is easy to reproduce using test plan in first comment. This problem occurs in authorities edition, not biblios. Mainly, follow-up 2 and 3 need signoff. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 --- Comment #39 from Nicole C. Engard <nengard@gmail.com> --- Is it possible that this is a UNIMARC only problem? Not MARC21? I did of course follow the first comment and looked at the screenshots, but do not have this problem at all. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12315|0 |1 is obsolete| | --- Comment #41 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 12827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12827&action=edit Proposed patch (follow-up 2) (rebased master) follow-up 2 rebased master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 --- Comment #44 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12983&action=edit Bug 7455: Authority subfields are cloned in the wrong field (follow-up) Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 --- Comment #46 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12985&action=edit Bug 7455: Authority subfields are cloned in the wrong field (follow-up 3) Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|koha.sekjal@gmail.com |mtj@kohaaloha.com --- Comment #48 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #47)

This patch can be passed QA I think, but as I've string freezed for the 3.10 release, I fear pushing it because the translator tool could be confused by string moves So I won't do anything for 3.10 If someone want to argue, feel free

passing QA... i've done some good tests of this, everything worked OK very impressive patch, well done! $ koha-qa.pl -c 4 testing 4 commit(s) (applied to commit 00539c2) * 10a8d0a Bug 7455: Authority subfields are cloned in the wrong field (follow-up 3) koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js * 3429d1c Bug 7455: Authority subfields are cloned in the wrong field (follow-up 2) authorities/authorities.pl cataloguing/addbiblio.pl koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt * cd1ba90 Bug 7455: Authority subfields are cloned in the wrong field (follow-up) authorities/authorities.pl koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js * 57a15f0 Bug 7455: Authority subfields are cloned in the wrong field cataloguing/additem.pl koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt tools/batchMod.pl * authorities/authorities.pl OK * cataloguing/addbiblio.pl OK * cataloguing/additem.pl OK * tools/batchMod.pl OK * koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-seOK * koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt OK -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12984|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12982|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4381 -- You are receiving this mail because: You are watching all bug changes.