[Bug 18952] New: Show internal note in acquisitions details tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Bug ID: 18952 Summary: Show internal note in acquisitions details tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org If the AcquisitionDetails system preference is used, there is an extra tab on the staff details page displaying information about the acquisition orders linked to this bibliographic record. It would be nice if the internal note from the order would be displayed there as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84751&action=edit Bug 18952: Add internal note to acq details tab Any important notes about an order are usually added to the internal note. This patch makes the note visible on the acq detail tab in the staff client. To test: - Add a basket - Order something - Add an internal note for the order - Go to the detail page of the ordered record - Switch to the Acquisition details tab - Verify that with the patch the internal note shows -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84751|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84755&action=edit Bug 18952: Add internal note to acq details tab Any important notes about an order are usually added to the internal note. This patch makes the note visible on the acq detail tab in the staff client. To test: - Add a basket - Order something - Add an internal note for the order - Go to the detail page of the ordered record - Switch to the Acquisition details tab - Verify that with the patch the internal note shows - Verify that the new column can be toggled using the column visibility settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Works well but needs one correction: missing_filter at line 773 ( <td>[% order.order_internalnote %]</td>) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #3)
Works well but needs one correction:
missing_filter at line 773 ( <td>[% order.order_internalnote %]</td>)
you are so right *hides* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84755|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84806&action=edit Bug 18952: Add internal note to acq details tab Any important notes about an order are usually added to the internal note. This patch makes the note visible on the acq detail tab in the staff client. To test: - Add a basket - Order something - Add an internal note for the order - Go to the detail page of the ordered record - Switch to the Acquisition details tab - Verify that with the patch the internal note shows - Verify that the new column can be toggled using the column visibility settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Since the patch and the change are so smal, I've amended the patch with the filter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84806|0 |1 is obsolete| | --- Comment #7 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 84901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84901&action=edit Bug 18952: Add internal note to acq details tab Any important notes about an order are usually added to the internal note. This patch makes the note visible on the acq detail tab in the staff client. To test: - Add a basket - Order something - Add an internal note for the order - Go to the detail page of the ordered record - Switch to the Acquisition details tab - Verify that with the patch the internal note shows - Verify that the new column can be toggled using the column visibility settings Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Maryse! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com | |, | |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84901|0 |1 is obsolete| | --- Comment #9 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 85195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85195&action=edit Bug 18952: Add internal note to acq details tab Any important notes about an order are usually added to the internal note. This patch makes the note visible on the acq detail tab in the staff client. To test: - Add a basket - Order something - Add an internal note for the order - Go to the detail page of the ordered record - Switch to the Acquisition details tab - Verify that with the patch the internal note shows - Verify that the new column can be toggled using the column visibility settings Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85195|0 |1 is obsolete| | --- Comment #10 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85825&action=edit Bug 18952: Add internal note to acq details tab Any important notes about an order are usually added to the internal note. This patch makes the note visible on the acq detail tab in the staff client. To test: - Add a basket - Order something - Add an internal note for the order - Go to the detail page of the ordered record - Switch to the Acquisition details tab - Verify that with the patch the internal note shows - Verify that the new column can be toggled using the column visibility settings Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Prior to this patch, release notes| |internal/vendor notes would | |not be visible in the | |acquisitions details tab | |which displays on each | |bibliographic record when | |the `AcquisitionDetails` | |system preferences is | |enabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the|Prior to this patch, |This enhancement makes release notes|internal/vendor notes would |internal and vendor notes |not be visible in the |visible in the acquisitions |acquisitions details tab |details tab that is |which displays on each |displayed for each |bibliographic record when |bibliographic record when |the `AcquisitionDetails` |the `AcquisitionDetails` |system preferences is |system preferences is |enabled. |enabled. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org