[Bug 18166] New: Show internal and vendor notes on Receipt page for already received orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 Bug ID: 18166 Summary: Show internal and vendor notes on Receipt page for already received orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: alexandre.breton@ccsr.qc.ca QA Contact: testopia@bugs.koha-community.org Created attachment 60623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60623&action=edit No notes for already received orders Hi, someone have reported something like a minor bug. 1) Go to acquisition module 2) Make a vendor search, Amazon for example 3) Create a new basket for it 4) Create a new order in it 5) Add an internal and a vendor note and save them 6) Close your basket 7) Return to the vendor basket(s) page and clic on "Receive shipment", then clic on your order on the board and clic on "Finish receiving" 8) Create a new invoice for the order (complete "Vendor invoice", "Shipping cost" and "Shipping fund"), clic "Next" and then clic "Save" 9) Return to "Pending orders" board to observe that internal and vendor infos appear 10) Clic on "Receipt" the order on the right 11) Clic on the "Receive?" case and save 11) The system will return on Receipt summary page and observe that the said infos don't appear anymore on the "Already received" board These notes are usefull to staff clients when they make a fast check up on received orders. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 Alexandre <alexandre.breton@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show internal and vendor |Show internal and vendor |notes on Receipt page for |notes for received orders |already received orders | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 --- Comment #1 from Alexandre <alexandre.breton@ccsr.qc.ca> --- Hi, Long story short, the internal and vendor notes will simply disappear after an order was received. However, these notes remain usefull after reception. Thanks for helping, Alexandre from CCSR -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 Patrick Robitaille <patrick.robitaille@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84949&action=edit Bug 18166: Show internal and vendor notes for receivied orders This copies the logic for showing, adding and editing vendor and internal notes from the pending orders to the received orders. To test: - In acquisitions create a basket with orders - Make your you have some internal and vendor notes - Close the basket and receive shipment - Create or reuse an invoice - Receive some of your orders - Verify that the notes don't show for received orders - Apply patch - Verify that the edit/change vendor/internal note links work the same on pending and received orders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84949|0 |1 is obsolete| | --- Comment #3 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> --- Created attachment 85188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85188&action=edit Bug 18166: Show internal and vendor notes for receivied orders This copies the logic for showing, adding and editing vendor and internal notes from the pending orders to the received orders. To test: - In acquisitions create a basket with orders - Make your you have some internal and vendor notes - Close the basket and receive shipment - Create or reuse an invoice - Receive some of your orders - Verify that the notes don't show for received orders - Apply patch - Verify that the edit/change vendor/internal note links work the same on pending and received orders Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jose-mario.monteiro-santos@ | |inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85188|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85329&action=edit Bug 18166: Show internal and vendor notes for receivied orders This copies the logic for showing, adding and editing vendor and internal notes from the pending orders to the received orders. To test: - In acquisitions create a basket with orders - Make your you have some internal and vendor notes - Close the basket and receive shipment - Create or reuse an invoice - Receive some of your orders - Verify that the notes don't show for received orders - Apply patch - Verify that the edit/change vendor/internal note links work the same on pending and received orders Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Prior to this patch, vendor release notes| |notes could be recorded but | |were not being displayed | |anywhere to the end user. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Prior to this patch, vendor |Prior to this patch, release notes|notes could be recorded but |internal and vendor notes |were not being displayed |would not be visible for |anywhere to the end user. |received orders. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Prior to this patch, |Prior to this patch, release notes|internal and vendor notes |internal and vendor notes |would not be visible for |would not be visible for |received orders. |received orders, but only | |for pending orders. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Prior to this patch, |This enhancement makes release notes|internal and vendor notes |internal and vendor notes |would not be visible for |visible for received |received orders, but only |orders. Previously these |for pending orders. |were only shown for pending | |orders. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org