[Bug 16065] New: Use Font Awesome icons in dialog when duplicate patron is suspected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16065 Bug ID: 16065 Summary: Use Font Awesome icons in dialog when duplicate patron is suspected Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/memberentry.pl OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org When adding a new patron, if a duplicate patron is suspected a dialog is shown. This dialog should use Font Awesome icons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16065 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16065 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49099&action=edit Bug 16065 - Use Font Awesome icons in dialog when duplicate patron is suspected This patch updates the new patron template to use Font Awesome icons in the dialog which is shown when a duplicate patron is suspected. The patch modifies the CSS rules for a dialog button with "white-space: pre-line" so that line breaks in button text markup are treated as line breaks on display. Allowing the text to wrap prevents the buttons from being too wide and stacking one below the other. To test, apply the patch and go to Patrons -> New patron. - Attempt to save a new patron with details matching an existing patron in order to trigger the duplicate patron warning. - Confirm that the resulting dialog is styled correctly. - Confirm the behavior of both the 'Edit existing' and 'Save as new' buttons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16065 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16066 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16066 [Bug 16066] JavaScript error on new patron form when duplicate is suspected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16065 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49099|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 49112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49112&action=edit Bug 16065 - Use Font Awesome icons in dialog when duplicate patron is suspected This patch updates the new patron template to use Font Awesome icons in the dialog which is shown when a duplicate patron is suspected. The patch modifies the CSS rules for a dialog button with "white-space: pre-line" so that line breaks in button text markup are treated as line breaks on display. Allowing the text to wrap prevents the buttons from being too wide and stacking one below the other. To test, apply the patch and go to Patrons -> New patron. - Attempt to save a new patron with details matching an existing patron in order to trigger the duplicate patron warning. - Confirm that the resulting dialog is styled correctly. - Confirm the behavior of both the 'Edit existing' and 'Save as new' buttons. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16065 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16065 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16065 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49112|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49174&action=edit Bug 16065 - Use Font Awesome icons in dialog when duplicate patron is suspected This patch updates the new patron template to use Font Awesome icons in the dialog which is shown when a duplicate patron is suspected. The patch modifies the CSS rules for a dialog button with "white-space: pre-line" so that line breaks in button text markup are treated as line breaks on display. Allowing the text to wrap prevents the buttons from being too wide and stacking one below the other. To test, apply the patch and go to Patrons -> New patron. - Attempt to save a new patron with details matching an existing patron in order to trigger the duplicate patron warning. - Confirm that the resulting dialog is styled correctly. - Confirm the behavior of both the 'Edit existing' and 'Save as new' buttons. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16065 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org